From: Leo Subject: Re: [PATCH v7 12/17] drm/dp_mst: Add branch bandwidth validation to MST atomic check Date: Tue, 26 Nov 2019 14:55:50 -0500 Message-ID: References: <20191116220128.16598-1-mikita.lipski@amd.com> <20191116220128.16598-13-mikita.lipski@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191116220128.16598-13-mikita.lipski-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: mikita.lipski-5C7GfCeVMHo@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Jerry Zuo , harry.wentland-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org SSdtIG5vdCB3ZWxsIHZlcnNlZCBpbiBNU1QgYncgdmFsaWRhdGlvbiwgd2hpY2ggbWlnaHQgZXhw bGFpbiBteSBjb25mdXNpb24gaGVyZSAtIHNvIGJlYXIgd2l0aCBtZSA6KQouLi4KCk9uIDIwMTkt MTEtMTYgNTowMSBwLm0uLCBtaWtpdGEubGlwc2tpQGFtZC5jb20gd3JvdGU6Cj4gRnJvbTogTWlr aXRhIExpcHNraSA8bWlraXRhLmxpcHNraUBhbWQuY29tPgo+IAo+IEFkZGluZyBQQk4gYXR0cmli dXRlIHRvIGRybV9kcF92Y3BpX2FsbG9jYXRpb24gc3RydWN0dXJlIHRvCj4ga2VlcCB0cmFjayBv ZiBob3cgbXVjaCBiYW5kd2lkdGggZWFjaCBQb3J0IHJlcXVpcmVzLgo+IEFkZGluZyBkcm1fZHBf bXN0X2F0b21pY19jaGVja19id19saW1pdCB0byB2ZXJpZnkgdGhhdAo+IHN0YXRlJ3MgYmFuZHdp ZHRoIG5lZWRzIGRvZXNuJ3QgZXhjZWVkIGF2YWlsYWJsZSBiYW5kd2lkdGguCj4gVGhlIGZ1bnRp b24gaXMgY2FsbGVkIGluIGRybV9kcF9tc3RfYXRvbWljX2NoZWNrIGFmdGVyCj4gZHJtX2RwX21z dF9hdG9taWNfY2hlY2tfdG9wb2xvZ3lfc3RhdGUgdG8gZnVsbHkgdmVyaWZ5IHRoYXQKPiB0aGUg cHJvcG9zZWQgdG9wb2xvZ3kgaXMgc3VwcG9ydGVkLgo+IAo+IENjOiBKZXJyeSBadW8gPEplcnJ5 Llp1b0BhbWQuY29tPgo+IENjOiBIYXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNv bT4KPiBDYzogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBN aWtpdGEgTGlwc2tpIDxtaWtpdGEubGlwc2tpQGFtZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1 L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5LmMgfCA2NyArKysrKysrKysrKysrKysrKysrKysrKysr Ky0KPiAgaW5jbHVkZS9kcm0vZHJtX2RwX21zdF9oZWxwZXIuaCAgICAgICB8ICAxICsKPiAgMiBm aWxlcyBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jIGIvZHJpdmVycy9n cHUvZHJtL2RybV9kcF9tc3RfdG9wb2xvZ3kuYwo+IGluZGV4IDk4Y2M5M2Q1ZGRkNy4uNTA3MmMx ZTNkY2ZlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHBfbXN0X3RvcG9sb2d5 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2RwX21zdF90b3BvbG9neS5jCj4gQEAgLTMy NDMsNyArMzI0Myw3IEBAIGludCBkcm1fZHBfYXRvbWljX2ZpbmRfdmNwaV9zbG90cyhzdHJ1Y3Qg ZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIHsKPiAgCXN0cnVjdCBkcm1fZHBfbXN0X3RvcG9s b2d5X3N0YXRlICp0b3BvbG9neV9zdGF0ZTsKPiAgCXN0cnVjdCBkcm1fZHBfdmNwaV9hbGxvY2F0 aW9uICpwb3MsICp2Y3BpID0gTlVMTDsKPiAtCWludCBwcmV2X3Nsb3RzLCByZXFfc2xvdHMsIHJl dDsKPiArCWludCBwcmV2X3Nsb3RzLCBwcmV2X2J3LCByZXFfc2xvdHMsIHJldDsKPiAgCj4gIAl0 b3BvbG9neV9zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X21zdF90b3BvbG9neV9zdGF0ZShzdGF0ZSwg bWdyKTsKPiAgCWlmIChJU19FUlIodG9wb2xvZ3lfc3RhdGUpKQo+IEBAIC0zMjU0LDYgKzMyNTQs NyBAQCBpbnQgZHJtX2RwX2F0b21pY19maW5kX3ZjcGlfc2xvdHMoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlLAo+ICAJCWlmIChwb3MtPnBvcnQgPT0gcG9ydCkgewo+ICAJCQl2Y3BpID0g cG9zOwo+ICAJCQlwcmV2X3Nsb3RzID0gdmNwaS0+dmNwaTsKPiArCQkJcHJldl9idyA9IHZjcGkt PnBibjsKPiAgCj4gIAkJCS8qCj4gIAkJCSAqIFRoaXMgc2hvdWxkIG5ldmVyIGhhcHBlbiwgdW5s ZXNzIHRoZSBkcml2ZXIgdHJpZXMKPiBAQCAtMzI2OSw4ICszMjcwLDEwIEBAIGludCBkcm1fZHBf YXRvbWljX2ZpbmRfdmNwaV9zbG90cyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g IAkJCWJyZWFrOwo+ICAJCX0KPiAgCX0KPiAtCWlmICghdmNwaSkKPiArCWlmICghdmNwaSkgewo+ ICAJCXByZXZfc2xvdHMgPSAwOwo+ICsJCXByZXZfYncgPSAwOwo+ICsJfQo+ICAKPiAgCWlmIChw Ym5fZGl2IDw9IDApCj4gIAkJcGJuX2RpdiA9IG1nci0+cGJuX2RpdjsKPiBAQCAtMzI4MCw2ICsz MjgzLDkgQEAgaW50IGRybV9kcF9hdG9taWNfZmluZF92Y3BpX3Nsb3RzKHN0cnVjdCBkcm1fYXRv bWljX3N0YXRlICpzdGF0ZSwKPiAgCURSTV9ERUJVR19BVE9NSUMoIltDT05ORUNUT1I6JWQ6JXNd IFtNU1QgUE9SVDolcF0gVkNQSSAlZCAtPiAlZFxuIiwKPiAgCQkJIHBvcnQtPmNvbm5lY3Rvci0+ YmFzZS5pZCwgcG9ydC0+Y29ubmVjdG9yLT5uYW1lLAo+ICAJCQkgcG9ydCwgcHJldl9zbG90cywg cmVxX3Nsb3RzKTsKPiArCURSTV9ERUJVR19BVE9NSUMoIltDT05ORUNUT1I6JWQ6JXNdIFtNU1Qg UE9SVDolcF0gUEJOICVkIC0+ICVkXG4iLAo+ICsJCQkgcG9ydC0+Y29ubmVjdG9yLT5iYXNlLmlk LCBwb3J0LT5jb25uZWN0b3ItPm5hbWUsCj4gKwkJCSBwb3J0LCBwcmV2X2J3LCBwYm4pOwo+ICAK PiAgCS8qIEFkZCB0aGUgbmV3IGFsbG9jYXRpb24gdG8gdGhlIHN0YXRlICovCj4gIAlpZiAoIXZj cGkpIHsKPiBAQCAtMzI5Miw2ICszMjk4LDcgQEAgaW50IGRybV9kcF9hdG9taWNfZmluZF92Y3Bp X3Nsb3RzKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQlsaXN0X2FkZCgmdmNw aS0+bmV4dCwgJnRvcG9sb2d5X3N0YXRlLT52Y3Bpcyk7Cj4gIAl9Cj4gIAl2Y3BpLT52Y3BpID0g cmVxX3Nsb3RzOwo+ICsJdmNwaS0+cGJuID0gcGJuOwo+ICAKPiAgCXJldCA9IHJlcV9zbG90czsK PiAgCXJldHVybiByZXQ7Cj4gQEAgLTM4MzcsNiArMzg0NCw1OSBAQCBzdGF0aWMgdm9pZCBkcm1f ZHBfbXN0X2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9wcml2YXRlX29iaiAqb2JqLAo+ICAJa2Zy ZWUobXN0X3N0YXRlKTsKPiAgfQo+ICAKPiArc3RhdGljIGJvb2wgZHJtX2RwX21zdF9wb3J0X2Rv d25zdHJlYW1fb2ZfYnJhbmNoKHN0cnVjdCBkcm1fZHBfbXN0X3BvcnQgKnBvcnQsCj4gKwkJCQkJ CSBzdHJ1Y3QgZHJtX2RwX21zdF9icmFuY2ggKmJyYW5jaCkKPiArewo+ICsJd2hpbGUgKHBvcnQt PnBhcmVudCkgewo+ICsJCWlmIChwb3J0LT5wYXJlbnQgPT0gYnJhbmNoKQo+ICsJCQlyZXR1cm4g dHJ1ZTsKPiArCj4gKwkJaWYgKHBvcnQtPnBhcmVudC0+cG9ydF9wYXJlbnQpCj4gKwkJCXBvcnQg PSBwb3J0LT5wYXJlbnQtPnBvcnRfcGFyZW50Owo+ICsJCWVsc2UKPiArCQkJYnJlYWs7Cj4gKwl9 Cj4gKwlyZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxpbmUKPiAraW50IGRybV9k cF9tc3RfYXRvbWljX2NoZWNrX2J3X2xpbWl0KHN0cnVjdCBkcm1fZHBfbXN0X2JyYW5jaCAqYnJh bmNoLAo+ICsJCQkJICAgICBzdHJ1Y3QgZHJtX2RwX21zdF90b3BvbG9neV9zdGF0ZSAqbXN0X3N0 YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RwX21zdF9wb3J0ICpwb3J0Owo+ICsJc3RydWN0IGRy bV9kcF92Y3BpX2FsbG9jYXRpb24gKnZjcGk7Cj4gKwlpbnQgcGJuX2xpbWl0ID0gMCwgcGJuX3Vz ZWQgPSAwOwo+ICsKPiArCWxpc3RfZm9yX2VhY2hfZW50cnkocG9ydCwgJmJyYW5jaC0+cG9ydHMs IG5leHQpIHsKPiArCQlpZiAocG9ydC0+bXN0Yikgewo+ICsJCQlpZiAoZHJtX2RwX21zdF9hdG9t aWNfY2hlY2tfYndfbGltaXQocG9ydC0+bXN0YiwgbXN0X3N0YXRlKSkKPiArCQkJCXJldHVybiAt RUlOVkFMOwo+ICsJCX0KPiArCQlpZiAocG9ydC0+YXZhaWxhYmxlX3BibiA+IDApCj4gKwkJCXBi bl9saW1pdCA9IHBvcnQtPmF2YWlsYWJsZV9wYm47CgpTaG91bGRuJ3QgdGhlIHBibl9saW1pdCBi ZSB0aGUgcGJuIGxpbWl0IG9mICp0aGlzKiBtc3RiJ3MgdXBzdHJlYW0gcG9ydCAoYnJhbmNoLT5w b3J0X3BhcmVudCkKYW5kIG5vdCB0aGUgZG93bnN0cmVhbSBwb3J0cz8gT3RoZXJ3aXNlLCB3b3Vs ZG4ndCB0aGlzIG1lYW4gd2UncmUgb25seSBjb25zaWRlcmluZyB0aGUgJ2xhc3QnCmRvd25zdHJl YW0gcG9ydCBpbiB0aGlzIG1zdGIgd2hlbiBzYXZpbmcgdGhlIHBibl9saW1pdD8gKG9yIHBlcmhh cHNlIHlvdSBtZWFudCB0byB1c2UgJys9JyByYXRoZXIKdGhhbiAnPScpCgo+ICsJfQo+ICsJRFJN X0RFQlVHX0FUT01JQygiW01TVCBCUkFOQ0g6JXBdIGJyYW5jaCBoYXMgJWQgUEJOIGF2YWlsYWJs ZVxuIiwKPiArCQkJCQkgYnJhbmNoLAo+ICsJCQkJCSBwYm5fbGltaXQpOwo+ICsKPiArCWxpc3Rf Zm9yX2VhY2hfZW50cnkodmNwaSwgJm1zdF9zdGF0ZS0+dmNwaXMsIG5leHQpIHsKPiArCQlpZiAo IXZjcGktPnBibikKPiArCQkJY29udGludWU7Cj4gKwo+ICsJCWlmIChkcm1fZHBfbXN0X3BvcnRf ZG93bnN0cmVhbV9vZl9icmFuY2godmNwaS0+cG9ydCwgYnJhbmNoKSkKPiArCQkJcGJuX3VzZWQg Kz0gdmNwaS0+cGJuOwo+ICsJfQoKSXQncyBub3QgY2xlYXIgdG8gbWUgaG93IHRoaXMgd2lsbCBi ZWhhdmUgd2hlbiByZWN1cnNpdmVseSBjYWxsZWQuCgpUaGUgYWJvdmUgaXRlcmF0aW9uIG92ZXIg YnJhbmNoLT5wb3J0cyBsb29rcyB0byBiZSBjaGVja2luZyB0aGF0IGEgZG93bnN0cmVhbSBNU1RC IGlzCmJhbmR3aWR0aC12YWxpZC4gV291bGRuJ3QgdGhpcyBpdGVyYXRpb24gaGVyZSByZXBlYXQg dGhlIHZhbGlkYXRpb24gd29yayBhZ2Fpbiwgc2luY2UKZHJtX2RwX21zdF9wb3J0X2Rvd25zdHJl YW1fb2ZfYnJhbmNoKCkgd2lsbCByZXR1cm4gdHJ1ZSBmb3IgKmFsbCogZG93bnN0cmVhbSBwb3J0 cwooaW5jbHVkaW5nIHRoZSBvbmVzIHdlIHJlY3Vyc2VkIG9uIGFib3ZlKT8gSXQgd291bGRuJ3Qg YmUgd3JvbmcgZXhhY3RseSwgYnV0IG5vdCBzdXJlIGlmCnRoYXQncyBpbnRlbmRlZC4KClRoYW5r cywKTGVvCgo+ICsJRFJNX0RFQlVHX0FUT01JQygiW01TVCBCUkFOQ0g6JXBdIGJyYW5jaCB1c2Vk ICVkIFBCTlxuIiwKPiArCQkJIGJyYW5jaCwKPiArCQkJIHBibl91c2VkKTsKPiArCWlmIChwYm5f dXNlZCA+IHBibl9saW1pdCkgewo+ICsJCURSTV9ERUJVR19BVE9NSUMoIltNU1QgQlJBTkNIOiVw XSBObyBhdmFpbGFibGUgYmFuZHdpZHRoXG4iLAo+ICsJCQkJIGJyYW5jaCk7Cj4gKwkJcmV0dXJu IC1FSU5WQUw7Cj4gKwl9Cj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGlubGluZSBp bnQKPiAgZHJtX2RwX21zdF9hdG9taWNfY2hlY2tfdG9wb2xvZ3lfc3RhdGUoc3RydWN0IGRybV9k cF9tc3RfdG9wb2xvZ3lfbWdyICptZ3IsCj4gIAkJCQkgICAgICAgc3RydWN0IGRybV9kcF9tc3Rf dG9wb2xvZ3lfc3RhdGUgKm1zdF9zdGF0ZSkKPiBAQCAtMzk2OCw2ICs0MDI4LDkgQEAgaW50IGRy bV9kcF9tc3RfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAg CQlyZXQgPSBkcm1fZHBfbXN0X2F0b21pY19jaGVja190b3BvbG9neV9zdGF0ZShtZ3IsIG1zdF9z dGF0ZSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJYnJlYWs7Cj4gKwkJcmV0ID0gZHJtX2RwX21zdF9h dG9taWNfY2hlY2tfYndfbGltaXQobWdyLT5tc3RfcHJpbWFyeSwgbXN0X3N0YXRlKTsKPiArCQlp ZiAocmV0KQo+ICsJCQlicmVhazsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gcmV0Owo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2RybS9kcm1fZHBfbXN0X2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2Rw X21zdF9oZWxwZXIuaAo+IGluZGV4IGIxYjAwZGUzMDgzYi4uNWExMTlhNDBlZDVhIDEwMDY0NAo+ IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9kcF9tc3RfaGVscGVyLmgKPiArKysgYi9pbmNsdWRlL2Ry bS9kcm1fZHBfbXN0X2hlbHBlci5oCj4gQEAgLTQzMSw2ICs0MzEsNyBAQCBzdHJ1Y3QgZHJtX2Rw X3BheWxvYWQgewo+ICBzdHJ1Y3QgZHJtX2RwX3ZjcGlfYWxsb2NhdGlvbiB7Cj4gIAlzdHJ1Y3Qg ZHJtX2RwX21zdF9wb3J0ICpwb3J0Owo+ICAJaW50IHZjcGk7Cj4gKwlpbnQgcGJuOwo+ICAJYm9v bCBkc2NfZW5hYmxlZDsKPiAgCXN0cnVjdCBsaXN0X2hlYWQgbmV4dDsKPiAgfTsKPiAKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5n IGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4