From: Dennis Dalessandro Subject: Re: [PATCH rdma-rc 01/15] IB/ipoib: Do not warn if IPoIB debugfs doesn't exist Date: Tue, 13 Feb 2018 11:06:02 -0500 Message-ID: References: <20180213101841.20101-1-leon@kernel.org> <20180213101841.20101-2-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180213101841.20101-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , Doug Ledford , Jason Gunthorpe Cc: RDMA mailing list , Alaa Hleihel , Matan Barak , Noa Osherovich List-Id: linux-rdma@vger.kernel.org On 2/13/2018 5:18 AM, Leon Romanovsky wrote: > struct ipoib_dev_priv *priv = ipoib_priv(dev); > > - WARN_ONCE(!priv->mcg_dentry, "null mcg debug file\n"); > - WARN_ONCE(!priv->path_dentry, "null path debug file\n"); > debugfs_remove(priv->mcg_dentry); > debugfs_remove(priv->path_dentry); > priv->mcg_dentry = priv->path_dentry = NULL; > Do we really want to keep sending stuff like this for RC? I get that it's a trivial patch and all, but it's not actually fixing anything. Just a console spam that only happens once. -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html