Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A76EEC10F0B for ; Thu, 18 Apr 2019 06:40:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80531214DA for ; Thu, 18 Apr 2019 06:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388085AbfDRGkK (ORCPT ); Thu, 18 Apr 2019 02:40:10 -0400 Received: from mga07.intel.com ([134.134.136.100]:41384 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733049AbfDRGkK (ORCPT ); Thu, 18 Apr 2019 02:40:10 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2019 23:40:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,364,1549958400"; d="scan'208";a="141646267" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.107]) ([10.239.13.107]) by fmsmga008.fm.intel.com with ESMTP; 17 Apr 2019 23:40:08 -0700 Subject: Re: [kbuild-all] [PATCH v3] gfs2: Convert gfs2 to fs_context To: Andrew Price , kbuild test robot Cc: cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, kbuild-all@01.org References: <20190327144600.671-1-anprice@redhat.com> <201903280254.VAUSqkQY%lkp@intel.com> From: Rong Chen Message-ID: Date: Thu, 18 Apr 2019 14:40:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 3/30/19 12:54 AM, Andrew Price wrote: > On 27/03/2019 18:14, kbuild test robot wrote: >> Hi Andrew, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on gfs2/for-next] >> [also build test ERROR on v5.1-rc2 next-20190327] >> [if your patch is applied to the wrong git tree, please drop us a >> note to help improve the system] >> >> url: >> https://github.com/0day-ci/linux/commits/Andrew-Price/gfs2-Convert-gfs2-to-fs_context/20190328-005647 >> base: >> https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git >> for-next > > These failures are due to the wrong base. The patch was based on David > Howells' mount-api-viro branch and not the gfs2 for-next one. Thanks for clarification! 0day-CI introduced '--base' option to record base tree info in format-patch. could you kindly add it to help robot to base on the right tree? please see https://stackoverflow.com/a/37406982 Best Regards, Rong Chen > > Andy > >> config: i386-randconfig-x008-201912 (attached as .config) >> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 >> reproduce: >>          # save the attached .config to linux build tree >>          make ARCH=i386 >> >> All error/warnings (new ones prefixed by >>): >> >>     fs/gfs2/ops_fstype.c: In function 'gfs2_get_tree': >>>> fs/gfs2/ops_fstype.c:1217:10: error: implicit declaration of >>>> function 'vfs_get_block_super'; did you mean 'vfs_get_super'? >>>> [-Werror=implicit-function-declaration] >>       error = vfs_get_block_super(fc, gfs2_fill_super); >>               ^~~~~~~~~~~~~~~~~~~ >>               vfs_get_super >>     fs/gfs2/ops_fstype.c: In function 'test_meta_super': >>>> fs/gfs2/ops_fstype.c:1565:12: error: 'struct fs_context' has no >>>> member named 'bdev' >>       return (fc->bdev == s->s_bdev); >>                 ^~ >>     fs/gfs2/ops_fstype.c: In function 'gfs2_meta_get_tree': >>     fs/gfs2/ops_fstype.c:1585:4: error: 'struct fs_context' has no >> member named 'bdev' >>       fc->bdev = path.dentry->d_sb->s_bdev; >>         ^~ >>     fs/gfs2/ops_fstype.c: In function 'test_meta_super': >>>> fs/gfs2/ops_fstype.c:1566:1: warning: control reaches end of >>>> non-void function [-Wreturn-type] >>      } >>      ^ >>     cc1: some warnings being treated as errors >> >> vim +1217 fs/gfs2/ops_fstype.c >> >>    1204 >>    1205    /** >>    1206     * gfs2_get_tree - Get the GFS2 superblock and root directory >>    1207     * @fc: The filesystem context >>    1208     * >>    1209     * Returns: 0 or -errno on error >>    1210     */ >>    1211    static int gfs2_get_tree(struct fs_context *fc) >>    1212    { >>    1213        struct gfs2_args *args = fc->fs_private; >>    1214        struct gfs2_sbd *sdp; >>    1215        int error; >>    1216 >>> 1217        error = vfs_get_block_super(fc, gfs2_fill_super); >>    1218        if (error) >>    1219            return error; >>    1220 >>    1221        sdp = fc->root->d_sb->s_fs_info; >>    1222        dput(fc->root); >>    1223        if (args->ar_meta) >>    1224            fc->root = dget(sdp->sd_master_dir); >>    1225        else >>    1226            fc->root = dget(sdp->sd_root_dir); >>    1227        return 0; >>    1228    } >>    1229 >> >> --- >> 0-DAY kernel test infrastructure                Open Source >> Technology Center >> https://lists.01.org/pipermail/kbuild-all Intel Corporation >> > _______________________________________________ > kbuild-all mailing list > kbuild-all@lists.01.org > https://lists.01.org/mailman/listinfo/kbuild-all