Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BEE0C5479D for ; Mon, 9 Jan 2023 08:00:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A887683D17; Mon, 9 Jan 2023 09:00:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="Gcr4aUbs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C805C81F28; Mon, 9 Jan 2023 09:00:12 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2042.outbound.protection.outlook.com [40.107.212.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1CB1D82161 for ; Mon, 9 Jan 2023 09:00:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQJZFLqpordozepM45/wo9PAt0znUDNztezPxCLMD4utA3Fa/GRQRuPoMVyS+j3eDh9p/S3TBVEtvfEQdFqUNqMAd7Spkg0lELTFMeYU1e2guLASoeYwTiJ0AX5LnlKHR/YmKK+mjaVP8ofdzXAb+0GOEczbjZPXujX0Gxxk7Adgcp8EtEXLZyU0eOY2IKJEImDDhhSNlERcgwPRRPRY2vXo9uc9iGe/raVAx5PjlA0lfr7JSg+KadWptbFlT3s3txah6UvIzJuumrp9734d85Ybrr1LfQiCTuPz7p1rpFqezqgv0h97pQm03RRtN8v7wOhffkJdLmPr6RMl2XUoog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BFvOu48YNRFe6q9KARCzfelZlGc014J4Esd72Ym3VCQ=; b=Dpyng+GwMFh7kIe/UYA4Tj7ETzan0Cp/lvXBMSDTnpM3ElCXBz3PxFZSWNBrhOOI5fkC4thJz++mtyCbXviiIxtOwKfVeGHd5GivtQB8ieJclXpZA9CnwCo+pDpdRgHyb7KPlg8mv1M9lniuQ9YWQzOXb9wi5PthkU6meMZG3kzb3qHs6TwIJ/1jdRlYJQJLC5OCUCROX9MpmxVYroKINOzAdU5nCjUbHNhI7jk9Wv0FeeEuI2CgMARyGHkp5tD6XCls2cP8IWmAzsdF3ObeGb//7Ay6UYlFy7slQjxjV+tOHWLdsX0k45yKT58oaPmf13H8omoaYLRTxMZD6NzlLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gigadevice.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFvOu48YNRFe6q9KARCzfelZlGc014J4Esd72Ym3VCQ=; b=Gcr4aUbsvWZgNHlHLW4y9hUQslq9BpRB/y5aw4O+lNvSB28CxaI0Qxj9Cb5qq0K8uiSnqfNNSlgfwxxwh83Wn5zd6m1yoV3nTrF5ZMZQQeLWtecWsPYC7zkerZCObsvUzNuZkeEbzJmOWC6wwKn4/3aUc5wSUXWi/MihjROGR2g= Received: from MW4PR03CA0311.namprd03.prod.outlook.com (2603:10b6:303:dd::16) by SA1PR12MB6846.namprd12.prod.outlook.com (2603:10b6:806:25d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Mon, 9 Jan 2023 07:59:59 +0000 Received: from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dd:cafe::e2) by MW4PR03CA0311.outlook.office365.com (2603:10b6:303:dd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:59:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5986.18 via Frontend Transport; Mon, 9 Jan 2023 07:59:58 +0000 Received: from [10.254.241.50] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 9 Jan 2023 01:59:54 -0600 Message-ID: Date: Mon, 9 Jan 2023 08:59:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 0/4] Enable gigadevice and add new part #s To: Vlim , Michal Simek , "u-boot@lists.denx.de" CC: "vigneshr@ti.com" , "jagan@amarulasolutions.com" , "michal.simek@xilinx.com" , "vikhyat.goyal@amd.com" , "ashok.reddy.soma@amd.com" References: <20221219224818.6801-1-vlim@gigadevice.com> <3d2a5e8b-0c35-b516-374c-61aabb326f5a@monstr.eu> <2e072563-2151-6f68-4359-7eeb6eaa3ec1@amd.com> <92659696-551b-6153-010b-754266fed452@amd.com> Content-Language: en-US From: Michal Simek In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT085:EE_|SA1PR12MB6846:EE_ X-MS-Office365-Filtering-Correlation-Id: a3ce0ebf-6e41-4c92-8b9e-08daf217810c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xt5NCY9xQ84hmPj2mSrDgWu9u4bPyWp6GixDT8I6tJndNb5BJwY+fHDZ+cL8OPXf3nUgw7lrlkyMUCS3VaX6nfw/cNf0WiTB/eQVeybGbAXA0LpeI2ehbGrspygK0nCuTSa6s7OyDNMIGwBjHYsKjDeL6lqlWb97e9K8jgwRA7Lf37FwJT9cqhq7QkhiRum6WPR4OdE3OcRUqyVFnHJXACat/AVcQfnzsTnQuMBI8U+oDI4r3nkCKNXs7S+jmziBFWvtS47C1n+W7L6bxaWlnm+U41c9Ywh8bjiRbH6G0xUkGbumvZNIhIp8Ree23XM/VqFbJZUdY8gGD32AsFgFTW/M6boJnU+SDFTJgwwGpBmOZNS712vxN8VlL3em5rBR6r9cb561C0vHexEeYo/FQIwl4Z0T0MYNxuPxtrY0LgD9+GVr+US9q8At6EqSwEB6091JzMm+071Kjt/joy0KfhMIzUSI5SJuS+wiUu05N87aJ0/uYFPjXP8JBs7C/CfAAd9Ttf6X5r6aqG610SFrCv9TyRbu/ywhKhDIPkNbYoGmzDXveCLLHFHu7e7bqudExBSAGI1V2tCTo2MEVvidTnIdMxo/4XrbTpLXhh2KcjMavn5JmzDnX/+yHgFkOP79AnCmyDHHpGdLEBbmWOqFUbna/fF/MCTn0zMjG8qM1h/aHqrQjuNylhVTAvHwRPwADeozTrxt4GZFab4yM4RG0NQyTXITwGLTCsepMTLZirlCflA9Lwv5A4ef8QzjxyBspjxFULn4IxdxAM2tlxQbEzvdcVD6aYVP39XLZ4fq8Do= X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(40460700003)(47076005)(426003)(41300700001)(54906003)(110136005)(16576012)(2616005)(316002)(336012)(36756003)(70206006)(4326008)(70586007)(8676002)(86362001)(36860700001)(82310400005)(31696002)(81166007)(356005)(82740400003)(44832011)(5660300002)(8936002)(40480700001)(83380400001)(2906002)(53546011)(31686004)(966005)(16526019)(186003)(26005)(478600001)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2023 07:59:58.8193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3ce0ebf-6e41-4c92-8b9e-08daf217810c X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6846 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 1/6/23 20:53, Vlim wrote: > Hi, Michal, > > > > On 1/5/23 20:47, Vlim wrote: >>> Regarding the location of the entry, I believe you want me to add the entry in >>> the alphabetical order? >> >> Not really. I want to you follow Kconfig layout which is what make savedefconfig >> && cp defconfig configs/ is for. >> >> Can you be more specific on this requirement? >> I believe this is pertaining to the defconfig files. >> Where is the correct line to insert the following entry? >> CONFIG_SPI_FLASH_GIGADEVICE=y > > Again. Just enable that option and run for example > make xilinx_zynqmp_virt_defconfig > > echo CONFIG_SPI_FLASH_GIGADEVICE=y >> .config > make savedefconfig > cp defconfig configs/xilinx_zynqmp_virt_defconfig > git commit -a -s > > And that's it. Your symbol will be added to proper location. > > I did the make command, but it says nothing to be done. > Do I need to install an additional software package in order to perform this > function? > > victor@victor-17Z990-R-AAC9U1:~/Desktop/u-boot-xlnx/configs$ make > zynq_cse_qspi_defconfig > make: Nothing to be done for 'zynq_cse_qspi_defconfig'. > victor@victor-17Z990-R-AAC9U1:~/Desktop/u-boot-xlnx/configs$ Please check that you use upstream tree without any your patches in. Here is how it should look like. [shm]$ git clone https://gitlab.denx.de/u-boot/u-boot.git Cloning into 'u-boot'... warning: redirecting to https://source.denx.de/u-boot/u-boot.git/ remote: Enumerating objects: 956, done. remote: Counting objects: 100% (798/798), done. remote: Compressing objects: 100% (245/245), done. remote: Total 566 (delta 449), reused 423 (delta 313), pack-reused 0 Receiving objects: 100% (566/566), 131.65 KiB | 1.13 MiB/s, done. Resolving deltas: 100% (449/449), completed with 146 local objects. [shm]$ cd u-boot/ [u-boot](master)$ ls api cmd disk env Kbuild MAINTAINERS README arch common doc examples Kconfig Makefile scripts board config.mk drivers fs lib net test boot configs dts include Licenses post tools [u-boot](master)$ arm64 [u-boot](master)$ make xilinx_zynqmp_virt_defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o YACC scripts/kconfig/zconf.tab.c LEX scripts/kconfig/zconf.lex.c HOSTCC scripts/kconfig/zconf.tab.o HOSTLD scripts/kconfig/conf # # configuration written to .config # [u-boot](master)$ echo CONFIG_SPI_FLASH_GIGADEVICE=y >> .config [u-boot](master)$ make savedefconfig scripts/kconfig/conf --savedefconfig=defconfig Kconfig .config:2307:warning: override: reassigning to symbol SPI_FLASH_GIGADEVICE [u-boot](master)$ cp defconfig configs/xilinx_zynqmp_virt_defconfig [u-boot](master)$ git diff diff --git a/configs/xilinx_zynqmp_virt_defconfig b/configs/xilinx_zynqmp_virt_defconfig index 4732c39bdbe1..b722850d6a5a 100644 --- a/configs/xilinx_zynqmp_virt_defconfig +++ b/configs/xilinx_zynqmp_virt_defconfig @@ -158,6 +158,7 @@ CONFIG_NAND_ARASAN=y CONFIG_SYS_NAND_ONFI_DETECTION=y CONFIG_SYS_NAND_MAX_CHIPS=2 CONFIG_SPI_FLASH_BAR=y +CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_SPI_FLASH_ISSI=y CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_SPANSION=y Thanks, Michal