Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19C0AC43334 for ; Mon, 13 Jun 2022 02:34:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3F96842EA; Mon, 13 Jun 2022 04:34:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="dExPpAy+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B14F084431; Mon, 13 Jun 2022 04:34:17 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0614.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::614]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1C2B2842A3 for ; Mon, 13 Jun 2022 04:34:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=US21mTEMOAiv8RvsLJdKl4Gvf9wINoKAS2QN4IzKp/F8FIRedcWulkNlh5oXDYS6Y1uZ5gh4WDgnCcHF+rHcZLOgwUSSXUWhKD2CcG2bPgXCJD5l8puZbF/KTNKWInb6Qp30b48zD6+b5h8AiUjBvx0/VAfQxrxWhmEhVtGZmHFtest6ew4wn4xvaHgyN2N7BY2SpCrBPKnoqwPWPQaGWnaZkWPGAE50tzvpMV5Fhn2XKzXJo5XCS2UvbnCWq5vCr6TdnMCfoHDkrhciCut1eTdj/Hod12LjtvCdN7SipGtciXnqp+opo/UDic4J7ukvGVesGO9FCYOdDH8mLAcvmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmizi15PbENyi7zAW06clZ14csri+a3lBREpCo2C1YQ=; b=dWrAI9dhS0TghaIbGD0rZ/UYCgq1jCh7dvDwQV7DuDtbaDAn11ZIU0PTKOGWFMGdAGe7XJ8rVC3NxXuqzP9qyoDJEcmck9kAHOVQqNb+NTHG3gPKbZrmYn7fgqw/6QivDQibfwuECtKUHbCoh94QSdH3XBZAx6wTBCRxyaJmtAqDWHA1VP17hc1D/5tniyMVRLd+p1LtqekmDbgxYXcWwhwwSTE8aXye2HT97n2qj3zJkRi2Qar9WFjyaKHpjvEkiKf/gcc2cjns9+lQ9ff3WzarxbzJnAha0B1zHPiQyIW74luy4g08Atp+krev1Rn9/N9g7x1Yja3tl4q/SEoLOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rmizi15PbENyi7zAW06clZ14csri+a3lBREpCo2C1YQ=; b=dExPpAy+BvhleemUlLSwFe8iL1haLEgbpCaVRketvWOtl0OVBU1Ab4Crx4/+HZONpPIXfCasNQWanRfhME6hJLzYcxsrD6a/ZH6rgibZ5jT9fcHKJGBCNuM1qT0NrCrsNIm7EGLnDwi/fMvm/Iu7TKo4TnTmo5W7u/FWnfu0PrU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by AM6PR04MB6054.eurprd04.prod.outlook.com (2603:10a6:20b:b5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.19; Mon, 13 Jun 2022 02:34:12 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::a892:e4a9:4769:13a5%8]) with mapi id 15.20.5332.015; Mon, 13 Jun 2022 02:34:12 +0000 Message-ID: Date: Mon, 13 Jun 2022 10:34:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 7/8] binman_sym: guard with CONFIG_IS_ENABLED(BINMAN_SYMBOLS) To: Alper Nebi Yasak Cc: "u-boot@lists.denx.de" , Peng Fan , "tharvey@gateworks.com" , "sbabic@denx.de" , "festevam@gmail.com" , "trini@konsulko.com" , Simon Glass References: <20220603071715.15212-1-peng.fan@oss.nxp.com> <20220603071715.15212-8-peng.fan@oss.nxp.com> <6c1ddda1-2763-07a0-95bd-1f8ba670af27@gmail.com> From: "Peng Fan (OSS)" In-Reply-To: <6c1ddda1-2763-07a0-95bd-1f8ba670af27@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SGXP274CA0012.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::24) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 800a348e-554b-47dd-6a28-08da4ce533c9 X-MS-TrafficTypeDiagnostic: AM6PR04MB6054:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0cpdJ/K+MMrL1yUbhESQ+6GHK6PHP8jbOMX6fO90YPfvXFkZtFNdksfugBGf2hv82HjOOsfycuOqZTyU6Y77SfyTlf88VZoQKvoRnjw4Rw3AwCVWt2jg/Seqcu+dhFWxkNxiejjFSpiijRr1G0CZBErCSkic33vBU3aLJITajIRMbA4USvYFQu73fhHDXrl3HeQBfcG5dBWn092XdocB/MN7asiVjD6aROLeFTSwNJZgeCNx76+2zjXdzeWnpEdoClY4DihJpdNZxCbO/Gt9Tt8uUDvflsO+McJ/lT7iLkK9C7nqjE5sq7+IfBA48Q4M5box/mcSfdGlWr9oNRRqyMhcS1wbn41a3l9sbHaKxcbf/j8hgeuU0PJpRmxvGMt+udLhdGrOc+yurT8+T2Li8eFDA+dHnIOUwLQMPl5rvVndyaudKSuGVvO8UdUj39UlA6daNTdOFkZoZ924ZURymOuAjL+Dp8dKk8bswLBzhwMvLKtSomHYY7hoLiGP0Xe2uiTSalPTASZUZgCwzUsQTQ6g11XPWPx20zl1mbqqEx6oAobGlJ4Nc2r2vBpfTOYXZSLn69sF9eV4fbzXa7EnQI27Ugg5SF/+fdF3fuG173Bf/5qQiHiMiE4XXsuE7vSwYlBmSnOugyrJzdW3oY76uSUwkAnYFomXKDzTgOnmd/Id+4JWLqFV6zqsislqvwDrDwRrM23gZPjKv9EChpmpUZ23oTamPBU9wePTA6rCB+eua1nwEllNYERupSAEr142NIHh9FsKlMC9bQE3v0niLQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR04MB9417.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(26005)(31686004)(6486002)(52116002)(4326008)(31696002)(6666004)(8676002)(508600001)(6506007)(53546011)(6512007)(6916009)(186003)(2616005)(2906002)(5660300002)(38350700002)(8936002)(38100700002)(66556008)(66476007)(66946007)(316002)(54906003)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3pvci9SWk1VVFEyZmgwRnJmRUY2Ny94eDNtMVZYZXIvMUhyYmRIYUQrTGlj?= =?utf-8?B?RDB0a1JydXBSWEtKZDljZVMwNVhPaE9tZDhtMEh4V3RMN0tJdndDMXE5cEhU?= =?utf-8?B?T3R3UDV1V0RyQ05oUkIwV0t0UENkVnlyRkFKRWduVnRDeWxPZC9wREt6NE9j?= =?utf-8?B?cnV5R3NDMjhmcW13QW9ESFpNY3M5MVNMN09JVTFrSjBtVlAvOW5neVJhTlBp?= =?utf-8?B?ZnJ3R0NsYmRwVXVsRit5OTl1dm5qNEhYNGhQaFliM3RvcUg2bWxvVXBINndH?= =?utf-8?B?bkhGREdRQXdGZEM5MGl5dWJMOVlCMkFJVkNkcnlFdVQ3Y2EveGMxai9uSHNa?= =?utf-8?B?Yk5NR0pZbmJyUXZzbDlFc3JlTVB5NG1JTDJ6SXlPNTBRcjJhbXVYUXZpWmlh?= =?utf-8?B?WkhvT0ZQMDlUQzkrMnY3Sms5K1lsdndZOENoYkZpVE1ZSWJjcU9OV0RuMXhL?= =?utf-8?B?bjBEMVpLUG9tZk80QVhIYTU4cnFobUdTdGF1QUtxd1FmLysrcmFtaklIZmx2?= =?utf-8?B?ODBQYzFCWFU5RTJMcUd1bzZpZ1dWN202djJIeXNGbXlMeVZpWWhXM3Y5YmlT?= =?utf-8?B?WHQwTnBlVlJDRTdQRGtVbEU1REViRWltNWFWT1dJa2lXMmNuQ0FkWU9iRUN2?= =?utf-8?B?K1Y3SnpDWTI0UUxscGt2d3hkclpmbWZrOEtpZXlQcnMvWUQ5Z2FWTWlTbU53?= =?utf-8?B?YU0wRVRjK1ozZDJiaDkzN09uSmxlOHRpR3ROenBnS2ExZHlYaWc5dE1NTGVQ?= =?utf-8?B?emJ4aE01b2pHZ0hMWitmcDdkS2VZRk1NRmNNMUNCTjgyWGUxT3FYMDYrbDgx?= =?utf-8?B?MGt2eVU0Wnk3Vk9aMWlEME9Yb2N2RXVJU1plRC9taDZKQ1VwdHlwdVU4NXln?= =?utf-8?B?d0t2c3Q2eXV3TitSaDBMVWRwVUxMTDhpTkJYMzVVQ2FsdTZxYUg4ZmRTWDNh?= =?utf-8?B?MElQVnhmbENkZkQwRGxTV2lWaFM4ZUg3bkNWQ09GREIyek4vVGpTWnRGajQ2?= =?utf-8?B?aEE0NHlNR3BncENsQWlOUVk4SEZwSWorTUJzQlZWc0VWOHhUb2VGR0ZER0lJ?= =?utf-8?B?aWxPYk1yK25yT241TTNEamI4ZVl0Tnl4VitXeUs5ZnpRMlpNa0FaemRBZUpU?= =?utf-8?B?OTJsREhKRFZ0Y2cvSXVhQllQZlZXUzRsWU1kT09IRUtlRHMrZjJMeGZXNnZx?= =?utf-8?B?eENJQmoxSTBVMUNKYkptajNHZUVzMUoyaHRnSXc5ZnB5WGhSVXN5Z1dyNEN0?= =?utf-8?B?eCtXbWFJUlhoTjE5UE1vcE4wZDJDZjExRmcvdmJmd2hiSCtWRXQvZ2VDWXNo?= =?utf-8?B?L3BVT0FRSWU5VnZ3M2MzTXMxd3BIRHZSY0NjcUhjK0dOWGRtK3NaS0Mrb3E4?= =?utf-8?B?ODdEcFRtTmhDVzRsMm44QzRQTXJVSWpRV29KQ1QvWk1FMVlXSmF3VmNnSmlL?= =?utf-8?B?Wnh5dEU0YVhiUGRrMG1KdXE3NWNnKzFsYm5GVGVxaVNzcGdGcDVHeC9lQ3ZZ?= =?utf-8?B?QVRSR1I4LzUyanM0dEJJVHJLd0llcFp6U3N3ZXZGWFArcjNXLzFTMTgvK203?= =?utf-8?B?STNwd0NIRUt3YU9Fby9BUjlyUk4vaGE3a0hWODAvU2lxVlpkb3NqUzluVFN6?= =?utf-8?B?U2R5RWFGUlB0QTdWV3RDUE1UQ0lUekY5a2lMdW9OSmMxVFRCRDVDNFcwb2Y0?= =?utf-8?B?Uy9JZkNoVGw4dEJ6TjAxQ2F6bkdXU1pyc1lmeVdXT3RSTi9DblN5WUMyOUh0?= =?utf-8?B?UnpyaXE0Q1BzUFozbjIrdllHb2tmSm1keFM0Tzk5aVg4ZXRGMml5WnlEa3Y3?= =?utf-8?B?VmptOXhjZHJWV2hkdDkxRXVyMmRnVzJXaUluQ1FsWG9kZEwyMkFBaWs1ZDU1?= =?utf-8?B?Qjk1eDBUME9nR0Q2bXJ1V0o5VGZwdkFzSEplOE5qM2dRa3VZMkF0bGJESnpB?= =?utf-8?B?NCs4Z0J5VFZJUDdxYkhpT0hUN0RTVnRFdkhpUTE2eEVob054SUY4YmFaVUNj?= =?utf-8?B?SS83cDNBd0xaZXlaR3ZRbVRmdFZHdGRpaUgzbnF5djJvZ3dQeEVNYml4S3NV?= =?utf-8?B?RmpUb01LTjVHT3ErRjNwZVRLQ1VWZkVUeGFVZEV3ejBOQ1NsRUszSGtnYTFj?= =?utf-8?B?Ulp4NHMvNG1WY3ZxbC81c2tWUk9aRlpzcCt6SkYxL2NaUnhQOUNmeEhncldh?= =?utf-8?B?RnVBMlV0VTFvNFZhTXp3UWJqa2hFNXRnLy84czAyVVEwd0FxeTFydUl2MStX?= =?utf-8?B?UnZuRVhRRmdpZHlMeGhHZThpS3Y2djhpNm12RkRGdEVUdCtQamtoZ2krd0ky?= =?utf-8?B?TkFqZWg0ai83cUhNSVRibXFRMW1URlFVRzkwUHJIcHVjMGlCaXZuUT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 800a348e-554b-47dd-6a28-08da4ce533c9 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 02:34:12.7499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DbnwI5TZyL6NO4d5S2KmKGKjB18k/BplwykTHdVD3M+Hx+FEzbnYjRdA2WmznbRurQFVyk572KALKOPOLXo69w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6054 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean 在 2022/6/11 20:44, Alper Nebi Yasak 写道: > On 11/06/2022 13:32, Peng Fan (OSS) wrote: >> 在 2022/6/11 0:47, Alper Nebi Yasak 写道: >>> I have sent a patch [1] that fixes the build error mentioned here, which >>> should be used instead of this patch. Please: >>> >>> - Rebase on top of that series [1] >>> - Maybe drop config changes in 1/8 and 2/8 (they're now unnecessary) >>> - Disable CONFIG_SPL/TPL/VPL_BINMAN_SYMBOLS for i.MX8M boards >>> - Change the if statement to if (IS_ENABLED(CONFIG_BINMAN)) in patch 5/8 >> This not work, BINMAN has been enabled for packing images, but we have >> not generated some i.MX binman symbols >> for getting exact blob size. So I use binman symbols to get exact blob >> size in this patchset. > CONFIG_IS_ENABLED(BINMAN) doesn't work, but IS_ENABLED(CONFIG_BINMAN) > worked for me. I see all 8 symbols in spl/u-boot-spl.sym. I can send you > a git branch if you want? But now with your suggestion, that means all i.MX8M boards should use the i.MX binman symbols, that is not expected. The i.MX driver code is expected to support w/o i.MX binman symbols. Thanks, Peng > >> Thanks, >> Peng. >> >>> - Drop this patch 7/8