Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BDBE944F for ; Thu, 22 May 2025 17:16:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934191; cv=none; b=J521Eh6a3MLAb6KGbZhqi70A9Nd3A/hPZtgtcOkQnOmMMu5eNOYyXmGDEG/6FpYTb4cidlPKX1ngTBiCBBW+beX7UMz5HX/NnawQGsa1cXSGBC7SMF8KcqwvfNqua05yKOhDSaVwMfW24QnchSClvtg5lA+TAYPcQGjKdvY6SaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934191; c=relaxed/simple; bh=UX6OGyVq84s6QC/hCLkAkebOv1L9BkoeCqP2OzBZX3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c9sClR/RE96MXdwps7yvhDOvfmpbKGoQF05cegNTgGLIsGICLXjpUfqbc5vi650iyzstJR+Up48z7ScEYDJv2LLBU3wd1obP8a+4Q5YTdlXn8Lo/n7Cbav15UFo2kZ6xqMoRyp8LN8035gr3B9bip55Q1SkNbyHrgfToGx6tB8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s5icyqMF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s5icyqMF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A098C4CEE4; Thu, 22 May 2025 17:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747934190; bh=UX6OGyVq84s6QC/hCLkAkebOv1L9BkoeCqP2OzBZX3Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s5icyqMFX2d/TDnnih04agEtLFFRYQ5lvL26KYb3VvxyDWE8GlHgPTrANPIQDieT2 wdEEmnGBN+F2v60/M/+nZXx0lahAgMMsYVj4C4SLSTTy+gDHXnRGNsees1kflWgvP+ ZGQ3aVPtCQv5Lk338kXZM7cFnDJ9SV2y4GPwDbAwrAZOT1AyWNRhfDgiI5ACbmHIUx 7IwbooBVTQKCf+YnnnD5ptLP6HS5Vfpsa5ktEQ7vsV1KN2cuLkSf9DEn6PY0OGQ3cM eHHtaormctGIqrQ6mo6NdkZcg9iAynSaZYAyNaO6Yu+PB/9OVG2LSX294NBPnfGYaP zq1dfb2x+M8yQ== Date: Thu, 22 May 2025 10:16:29 -0700 From: Luis Chamberlain To: Chuck Lever Cc: kdevops@lists.linux.dev, Chuck Lever Subject: Re: [RFC PATCH 2/5] Move the guestfs install-deps to the guestfs playbook Message-ID: References: <20250522133137.989457-1-cel@kernel.org> <20250522133137.989457-3-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 22, 2025 at 01:13:33PM -0400, Chuck Lever wrote: > Almost true. Check redhat/main.yml -- there is a little extra logic > there. Ahhh. > Also, I've done that kind of de-duplication in the past, and half > the time I end up undo-ing it because more logic is needed at a > later point. I see... > Thinking ahead (always dangerous). Good to know, ok so we'll need to live with this, and have to just take this up in the future with the ansible community long term. Luis