Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5589619047C for ; Thu, 22 May 2025 17:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934109; cv=none; b=HQ2z8LdhwMmyfr4bDiPYtJyHC0DsyurCjQO/1PN9TGg0vytJXwDq/wNyGR+zGuir5yLRRDREfCLU25jPSCfmxQ0g4+fxGdG0q3eRUBBpLDJet/aylTqwA8TwZ1HhigVffwAIIjfJuO6g7nb5b92g6mOGKuJ03NCnJP58klKpvYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747934109; c=relaxed/simple; bh=4wxgkKY+LHtpRoBzmj3+uszwo+a52M9taEYlgLfOEf0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ao6IB4PgGcMzc+8GmmXxnivBxNi2FWBfs/a2BLai9nIMIYZoyfQGpsCI+62e4D3TtNxc9O4hX8KUsSjabOkvGwmJGXt+g6rmoAtAw8Po1KYdUYIRQ+yBTtNA8qgty9Iza1Z18aF2EimZqFSIpBCP25Ls6VqgrutbYQk+IHctpOM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jO4KCWvQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jO4KCWvQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B21C0C4CEE4; Thu, 22 May 2025 17:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747934108; bh=4wxgkKY+LHtpRoBzmj3+uszwo+a52M9taEYlgLfOEf0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jO4KCWvQ9vh+4qLxsXRuzkLoslDgYs7AwnGZ0wr4qL0HuygPjY25IPUfG0Q0q18Mb +xuVRtypQCn2NW16WvD0UFEnjVFIjTgwxAngmAdJSHxoTBggcS7Zq0NRUr/IdTIM7N C3JuWRMmuuM6cIrLaXITobFscHflpNlmFTpnAPHsGS8s+eRSdZGHt3RazDaMarBO6R DvAYJq+rc/hjmTOL/gbRdaYRYrnNTGVRNc8eSGYnBwkEGmoRrEsWZf0XAGTITtuEIE eJDVbxMm0jQyKPqqO5pwIwSZbSOxTBeJPWKlDQJveUU/8YhT4j0yuAmV6pjvUnP4Fx dQnroSbVmww2w== Date: Thu, 22 May 2025 10:15:05 -0700 From: Luis Chamberlain To: Chuck Lever Cc: kdevops@lists.linux.dev, Chuck Lever Subject: Re: [RFC PATCH 3/5] guestfs: Move console-related steps to guestfs role Message-ID: References: <20250522133137.989457-1-cel@kernel.org> <20250522133137.989457-4-cel@kernel.org> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 22, 2025 at 01:11:08PM -0400, Chuck Lever wrote: > On 5/22/25 1:09 PM, Luis Chamberlain wrote: > > On Thu, May 22, 2025 at 09:31:35AM -0400, cel@kernel.org wrote: > >> From: Chuck Lever > >> > >> These steps are relocated because my plan is to remove the > >> bringup_guestfs role eventually. > >> > >> Signed-off-by: Chuck Lever > > > > For 4 and 5: > > > > But just one nit-pick: it says move, but its not deleting the code it > > is moving. > > > > Reviewed-by: Luis Chamberlain > > > > LUis > > I'm planning to include a patch at the end that removes the > bringup_guestfs role. But fair enough, I will change the verb > to "copy". Fine by me, nuke nuke nuke! Luis