Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A07ABC54FB3 for ; Mon, 26 May 2025 15:06:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0426010E389; Mon, 26 May 2025 15:06:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="K01z/23h"; dkim-atps=neutral Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1550310E36A for ; Mon, 26 May 2025 15:06:46 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43d0618746bso18648115e9.2 for ; Mon, 26 May 2025 08:06:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748272005; x=1748876805; darn=lists.freedesktop.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=AsxP/yrbCPSbZ83V0+fVOhQsYXVYOwthunL0kF0vIsw=; b=K01z/23hJSu66V/yO+ePf873jyGV7St/fjtE6fkxBOEickyREkeGiSuRAsBYT0sM0s 8Uh9Chx8x1/ieZ/h5n9gcWsuaFKYhdYBFopzdvYaQTJ7ovICiwQHCCVj3WiOpA8vzB6D OtLdCOTGG6zQ/0SxkIElgxvB7veKu78N/YIMyeHf4VZfhHH/vpUPjJuiSUdazvpsNfyW r0YqAg9wLbl8FXXpDpbFgCxXQse1bM8wS2qW4HUXdez8LyYlfiMHm64D6esG64LVphKt l3Y1GLrUUQ6RXzl3D8YZtRmzJFNIN8Z6jMOt7t88+j5LcBV6AZp4g5RnC8XoalQsnWOs j5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748272005; x=1748876805; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AsxP/yrbCPSbZ83V0+fVOhQsYXVYOwthunL0kF0vIsw=; b=b4+7ZB4hzb74vF9PabuvT9nmO7++nV2VEdR+kGmtOUSnNaHPsaZKEbZTz+n5VapBnb JksQTXSBsqB+b8AzBpEDvBJU8fBvWIMAxw4nNr4I4WctUkgk7ZbxvVxT7ad8AUnBe7yx Nmcm++GW0DV45YnM+6jNHdyyX5Sm7KxO7e3oUe7FlCFpE4dj554Quioc1vmY632zQCAC hHuBk/OyFwnTpz9Ug0TUyENXnY/QLHZNlMJumHiM/+cpQewN6TMfipIoRs3tLjUs34TE A/dovILrQgzdghqmD29lQJsp6+oBSgx0Z6Px8QqHg6blYznawczg239FKCkB02vNaHQR BuyQ== X-Forwarded-Encrypted: i=1; AJvYcCWLrVlX7TkUIoOEVgITRt3gg2fh+8HhlyUq7A90jXh+EfIQAKOBwIlUK5Khj7zeLwmkPtr6ojDx8Xw=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwWNIZ+uO9aRmWrtw/x4INhFcUcVFTVj4wdPyM8ib53H7aBU9Hu +jXZv954oQJbc5ZutVk0ymd4Zqz6N9RVAnCSgM5BemSgiJ31u+WdPYyEef8D69Jqu48= X-Gm-Gg: ASbGncuun884vAT2qm+2QfHJHPoplZAWpFaSma/E57Yv30VMGWvwVTuCO/qBzMQr/8n Ygtk5K1UB6y7BQAR5A4H1xeoan+Q2kmR6d/zG4p+gg4ywBnTTPdk9ZLmH2pYxa/r6M7guB1Ough 3VBtXxI0f5XuZ1Ek4p2NxikeygSa4gkG74J6rQNVgsa5v33hdY+elm+apLXEmOIoXv/gXZsDPkV WgaWXSBZfNw6hFC1FC7ijZkF86jbm9OgcxxnRTWg53JVFImI0vcWDBm2bV1NHgpTNR3xBn6oXpZ co+FCt/3SeUsKW9gsrCSlv72X6q9iU/qq8h9lIP7Tib2WkeuvqPH4/74 X-Google-Smtp-Source: AGHT+IEmpGGfCTizmw750bW2UHXz8nV74n5esSCo0a+sMC/xgp1YN+TIDC/fQbCXlSt4LUEblX/RAQ== X-Received: by 2002:a05:600c:a08b:b0:43c:fe15:41dd with SMTP id 5b1f17b1804b1-44c932023e7mr83381235e9.6.1748272004714; Mon, 26 May 2025 08:06:44 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a4d1ed8740sm5658629f8f.83.2025.05.26.08.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 08:06:44 -0700 (PDT) Date: Mon, 26 May 2025 18:06:38 +0300 From: Dan Carpenter To: Himal Prasad Ghimiray , Jason Gunthorpe Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [bug report] drm/xe/svm: Implement prefetch support for SVM ranges Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Himal Prasad Ghimiray, Commit 09ba0a8f06cd ("drm/xe/svm: Implement prefetch support for SVM ranges") from May 13, 2025 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/xe/xe_vm.c:2922 prefetch_ranges() warn: passing positive error code 's32min-(-96),(-94)-(-15),(-13)-(-12),(-10)-(-2),1' to 'ERR_PTR' drivers/gpu/drm/xe/xe_vm.c 2917 2918 err = xe_svm_range_get_pages(vm, svm_range, &ctx); 2919 if (err) { 2920 if (err == -EOPNOTSUPP || err == -EFAULT || err == -EPERM) 2921 err = -ENODATA; --> 2922 drm_dbg(&vm->xe->drm, "Get pages failed, asid=%u, gpusvm=%p, errno=%pe\n", 2923 vm->usm.asid, &vm->svm.gpusvm, ERR_PTR(err)); The comments on walk_page_range() say it can return > 0 on success but the comments on hmm_range_fault() say it can never return > 0. Smatch does a naive reading of the code and thinks that it can return > 0. Presumably the comments are correct but the code is too tricky for me. I can easily silence this in Smatch by adding deleting the positive returns from hmm_range_fault() from the cross function DB. Can someone confirm that's the correct thing to do? 2924 return err; 2925 } 2926 xe_svm_range_debug(svm_range, "PREFETCH - RANGE GET PAGES DONE"); 2927 } 2928 2929 return err; 2930 } regards, dan carpenter