Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0E0BC71135 for ; Fri, 13 Jun 2025 08:31:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F1F110E8FF; Fri, 13 Jun 2025 08:31:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="YTjeCD2N"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D6AD10E917; Fri, 13 Jun 2025 08:31:41 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8419649744; Fri, 13 Jun 2025 08:31:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEE25C4CEE3; Fri, 13 Jun 2025 08:31:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749803499; bh=PhXGaZgbkCZl0Qw7juh6JslVX5LbmhMjhkWF1wlyr2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YTjeCD2NjIZnoNrJi7YyFBzbUmCQCNE2KVpwRGUERxrbmRlOiY76rMj70yOavvf6W a185agi8M6VubOnc+Kp90bZN0hWo8zTTVUt+OWytoyW2L8BughH4J9ZwsQEDxLWQSx WU0UI+f911Qr7HBgaSErFPBYFl4kAOxB3pqd0VkMBC6tErIe9i9xzREmfLB2RROJhU F+++B1dGUanDM/Kq7xlj6WeYdqwgCOyk8+5SKueWOJC98HcpqQEHxpqwVtNxbgSd6b CGXMFiMltRTvywuKVybYn+IBTOZP9c2rOJw1f3sNzIWwgoCWx9TKVBnPhyt31+oxIZ z2UXNc1QpUkIw== Date: Fri, 13 Jun 2025 10:31:35 +0200 From: Danilo Krummrich To: Pierre-Eric Pelloux-Prayer Cc: Christian =?iso-8859-1?Q?K=F6nig?= , Pierre-Eric Pelloux-Prayer , alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org, Philipp Stanner , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1] drm/amdgpu: give each kernel job a unique id Message-ID: References: <5f71cfd0-fd38-491c-8255-bdd3e0fb19dc@amd.com> <0783c4ab-e26e-4c90-93f5-342e761cee29@damsy.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0783c4ab-e26e-4c90-93f5-342e761cee29@damsy.net> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 13, 2025 at 09:51:27AM +0200, Pierre-Eric Pelloux-Prayer wrote: > If the theoretical overlap with client drm id is a concern, adding code to > drm_file_alloc() to not use the last 0xff ids would be easy. Not the theoretical overlap is not of any concern for me. What I dislike is drivers silently relying on DRM API internals. > btw maybe other drivers also use kernel jobs with the same semantics, in > which case we might want to move the special IDs definition to a shared > place. Exactly, if kernel IDs are a thing we agree makes sense, we should provide a common API to properly obtain a kernel ID, regardless of whether it's an atomic or IDA.