Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB1D2F83CB for ; Tue, 12 Aug 2025 17:55:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021328; cv=none; b=hhQHXArLdUFrGFblYF2COBae9RatBhLiE/ITaMGjuyeKWvGc3H/mo4muMBDa/HoPreDjzkGldigkUGruA3ubRg46c1ixVN+gJWSBnK7Gw6s7QCFoqYlqHgT0ahdmZIuYTU3+o9Y1I5GBBIL2Afg1gv5MrmU8qOZah0j0kef9YIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755021328; c=relaxed/simple; bh=kWTi2SgUd0nsUJ+xu5akZ/Qy88KshZVAxEcizguu4O0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VX+0+xQF67hI/DKSgiYFE2wPuPHdbnExMUlWdDATW02dk2R2fpqLJHoyU9JZLtH7m+PH6Pst06urhOqnT3eL2AyoChqdm0vhkF9IJWtqquakpj9zVh3q2c3S/AO1U5iTB9JySZ+gGmxzcTBS9zr71AqhUlr91SjrXTk9M5/MS2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=HGDXmrfS; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="HGDXmrfS" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2407235722bso57599125ad.1 for ; Tue, 12 Aug 2025 10:55:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1755021326; x=1755626126; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=sFniR6OHeJpzq5CzpOsoDrSOVnI61AYAux8BFNCWE1k=; b=HGDXmrfS2amW9k1mX0QArY9VENrBecOCehI6DpW/A2Zcbi+tPFWfw+qLExTQoOng7E 2zAVRnZn62JlE85yJOTnb73JGmdog61lE5orsIDAFGcqYzL8xeIpZ4RxGe3i6SsHweza Z5RW/A7+AFXz2EmvcXi/DQsJlnVfA+X2r/OXgm0sM2nPfVvsMKD1PP2WUaPzukKcbLvz /RFjqd0/OQld2tBfFRLCuxoyyGKChl2xkg818Ui1B9yqB9ihZ7Mguqznuz7RiqelsZCK oGz3xQs9dDr4c+QZB6B4JG+m5cDCvYdp+T3T75WvLy0YJYas59VTARKroBebBwa02lmr YjKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755021326; x=1755626126; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sFniR6OHeJpzq5CzpOsoDrSOVnI61AYAux8BFNCWE1k=; b=WwzjvM7rXw0Ta8bm2Y+iaFUx9qI78AFA6p7NxYburp7xZMlnMUnxOp7vmGBl7RUAYg JSiziQ9LSnpJ//tpLWrlPs4mE2eEOMX4FCAbGa96OV6d8cg4aJQh8n2mjIX7Bpd4zdTi iFbO21WYFHH77WAh01WeuUemM+QDQLugQOX//ThKXfWiUBICBof0rUOyawi10OibcYxX hwJtBTUy6Cet3siflMcvp5fSRDnsT2UjitKRg+JsLmG3rGsRUhPEC9B2htr5dtjVm35k TbOEV5wwO0145Hi5n9DHmNQ3XO0+B2nZx+0BWrDMwv9Z2+BMDXPgWRrzUHeZKXmHzyEs tisQ== X-Forwarded-Encrypted: i=1; AJvYcCV15O9haOWfPi6qlKGH78wZI+LJmyEv2n3wkB1cgTdGUdx6LTyb/Lzwlp98X/dG7D9626egLRRWlydgrjP6nrg=@vger.kernel.org X-Gm-Message-State: AOJu0YyADifZmSZ03BkbTHml7ZyjoXPcDF47cRAkImM76OMSMEW4tMJu l4iZXspJFn3FpJ3x5r9qpfF9D3dWAkLGYiWZQuvPMlbkQ3d4c/MZFSb2319iwgPxOWA= X-Gm-Gg: ASbGnctkzqIap4teU82WStEmU/dfB93d7Eemozpd58Mrfj3xy5g6fCrxoKeNobzccqa p6jDqYodXNcEOiZIW8AKpDb33apdBhQ3KTPWpBDzfQBben9DGxM+szsdWmo8IpxiBxdr1QRx1BC NVnd6IKcRQ9VfmdT/OpZqqi+/77WrhysNNHh8lEzmi8RAoIzY8S1nURzD3il9Hs80WSE6MpSGv6 Ii4xLbSebj6bZQPi8pmQpuc4szWTJeFdNPe5327NxTJwgLqSXzCaMV+98JTocUl7YeZGjAZ4oTx gt1Tnh7WleP/So0ES83ubBmjo9SUHIlzw6RTkjPHb4dXc9pveEqi7hzbDkOm6YHi9Ep74kCu/63 eLyeMkF168Cv7lliIWZQ/2mlU14PHlOLL5xScuOVottLz2PNkyESVTg/QQV5mBDT2sj0SEThz X-Google-Smtp-Source: AGHT+IGrcruxL8w5AP1FRZ8Qi0WJHmfwtLu4/b8EI7R/ZKX+1vBpTxr9Y6qv46OQyMfLzdTGsMzToA== X-Received: by 2002:a17:902:d50b:b0:235:ed01:18cd with SMTP id d9443c01a7336-2430d21d8cdmr1308655ad.44.1755021326024; Tue, 12 Aug 2025 10:55:26 -0700 (PDT) Received: from MacBook-Air.local (c-73-222-201-58.hsd1.ca.comcast.net. [73.222.201.58]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8976a1csm308425625ad.78.2025.08.12.10.55.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 10:55:25 -0700 (PDT) Date: Tue, 12 Aug 2025 10:55:23 -0700 From: Joe Damato To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org, willemb@google.com, petrm@nvidia.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v2] selftests: drv-net: wait for carrier Message-ID: Mail-Followup-To: Joe Damato , Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org, shuah@kernel.org, willemb@google.com, petrm@nvidia.com, linux-kselftest@vger.kernel.org References: <20250812142054.750282-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: linux-kselftest@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250812142054.750282-1-kuba@kernel.org> On Tue, Aug 12, 2025 at 07:20:54AM -0700, Jakub Kicinski wrote: > On fast machines the tests run in quick succession so even > when tests clean up after themselves the carrier may need > some time to come back. > > Specifically in NIPA when ping.py runs right after netpoll_basic.py > the first ping command fails. > > Since the context manager callbacks are now common NetDrvEpEnv > gets an ip link up call as well. > > Signed-off-by: Jakub Kicinski > --- > v2: > - add an empty __del__ > v1: https://lore.kernel.org/20250808225741.1095702-1-kuba@kernel.org > > CC: shuah@kernel.org > CC: willemb@google.com > CC: petrm@nvidia.com > CC: linux-kselftest@vger.kernel.org > --- > .../selftests/drivers/net/lib/py/__init__.py | 2 +- > .../selftests/drivers/net/lib/py/env.py | 41 +++++++++---------- > tools/testing/selftests/net/lib/py/utils.py | 18 ++++++++ > 3 files changed, 39 insertions(+), 22 deletions(-) Reviewed-by: Joe Damato