Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4A2635 for ; Sun, 31 Aug 2025 22:28:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756679331; cv=none; b=d0Diq1zJZyXjkYpFOSD+SHMoOaOjOmQGfIEde+/YW4Eq+Z01UigpU7KZ0zdtuzfZvEnMQeWn/0/b4G1h8ryjHJ0CNnynYBnbz5YvB5Qn7gAjS0mXCnVfV8RwBOMNAbXG/BIRlWkCYMw4AvbgXxpCuEAGG6NRIRrIuQ+gjWEQGzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756679331; c=relaxed/simple; bh=qhe/iIMuVAD1Jhb5k9Hv4ZC0qexXWN81b9RlumNB4wo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZBvvme60lV3xZbJWiUV1J5zZNFM1W0zQUA8TYP5mGZS2SaYdSFz56d0xPbsPYDDfnyMm8SlFrFTlpvOS6QaMiLz2tYBJ8RDsxKRjfgWaMGXcfHz9kItnXzzd9WszQJRkYMcvPbgXqR0qZ3Z7NzzkeZL0vrkJUto2F1Eh0AVu2AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1usqXS-000000004Co-44ii; Sun, 31 Aug 2025 22:28:43 +0000 Date: Sun, 31 Aug 2025 23:28:40 +0100 From: Daniel Golle To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marcin Wojtas , netdev@vger.kernel.org, Paolo Abeni Subject: Re: [PATCH net-next] net: mvpp2: add xlg pcs inband capabilities Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sun, Aug 31, 2025 at 06:01:51PM +0100, Russell King (Oracle) wrote: > Add PCS inband capabilities for XLG in the Marvell PP2 driver, so > phylink knows that 5G and 10G speeds have no inband capabilities. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Daniel Golle > --- > The lack of this patch meant that I didn't see the problems with 10G > SFP modules, as phylink becomes permissive without these capabilities, > thereby causing a weakness in my run-time testing. > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 8ebb985d2573..35d1184458fd 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -6222,6 +6222,12 @@ static struct mvpp2_port *mvpp2_pcs_gmac_to_port(struct phylink_pcs *pcs) > return container_of(pcs, struct mvpp2_port, pcs_gmac); > } > > +static unsigned int mvpp2_xjg_pcs_inband_caps(struct phylink_pcs *pcs, > + phy_interface_t interface) > +{ > + return LINK_INBAND_DISABLE; > +} > + > static void mvpp2_xlg_pcs_get_state(struct phylink_pcs *pcs, > unsigned int neg_mode, > struct phylink_link_state *state) > @@ -6256,6 +6262,7 @@ static int mvpp2_xlg_pcs_config(struct phylink_pcs *pcs, unsigned int neg_mode, > } > > static const struct phylink_pcs_ops mvpp2_phylink_xlg_pcs_ops = { > + .pcs_inband_caps = mvpp2_xjg_pcs_inband_caps, > .pcs_get_state = mvpp2_xlg_pcs_get_state, > .pcs_config = mvpp2_xlg_pcs_config, > }; > -- > 2.47.2 > >