Received: from fhigh-b3-smtp.messagingengine.com (fhigh-b3-smtp.messagingengine.com [202.12.124.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F0E1799F for ; Wed, 8 Oct 2025 04:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.154 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759897715; cv=none; b=YpGkwAMlaIQo0/5cpgGFHVZ21AtsEuPbb0nK5YNcwZtSa58EzHWyzHqOSBzLOs5Du848t6Dz8CkyAMFS9z6IBC1Xk2VJOJdoDId7QOZYGNVAtTYs6kPiKbN+RjkAcJ2n5RYzJqvr18ya6M2/DxZRh32LyN+59Kd3AZS/nFLaYas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759897715; c=relaxed/simple; bh=DnwWIHadH8pODn7axAY4NtwDoxEGMXb8L9XeRkozn3I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UOTTklLsnA+fChKlOAF2kte7y+k1KD3EokigvYKDQAhKNL4cEKjwsTMaXwlGYGqx0dBuYNt4ufx9D57FlN84st7zDjMfAcZvbhnaR5eVzDceUWyU2CwPR3WrsQME0THZSczVbd5tT/N3R/p/yb+2jJhXfelGAih6mhI1/BbsE5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=bwSznurr; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=SfazEBUZ; arc=none smtp.client-ip=202.12.124.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="bwSznurr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SfazEBUZ" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id CB20D7A0134; Wed, 8 Oct 2025 00:28:30 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-12.internal (MEProxy); Wed, 08 Oct 2025 00:28:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1759897710; x=1759984110; bh=KcEtHu1sH8 sASMsr8VueyEPZ/mGd5rsAfAttWqWyoQ0=; b=bwSznurrSjT+o9ohSiY2Wxxy6X kO0c1XMaNOmaAFUq62jhgTm5gy5E94DZKxPRIJIwkGILHanXGOWtsASIdCBQH2dC nhsLU1Ogmz9QYQBsOXAndBpg/gxnTz66X9vCslnEDbQ/NIFZCFHIWI9OYc/tFsq7 0trkGNe59IB6AjJTZGq/OPalRGVpQk9Q62mhrJBQW0qdXzeahZTb48RaQijd1ql3 5cGEKuDW+DNQ6VWq8V3/bjbatO1yKjf25jSrL1o1TOPe5N/72c+Wgvlpdj/pNuph zY5771YhwtvgDx+ASEKS9up6WMR7RfrJAhpC5aAtMN5fR+uGLYDz7pP8Kg2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759897710; x=1759984110; bh=KcEtHu1sH8sASMsr8VueyEPZ/mGd5rsAfAt tWqWyoQ0=; b=SfazEBUZF9gZRC+mTXtjOctf0zqrRXrxDRO95Bx4uFyT7ZTfVom w7XXuhAlPXGJIjxCkKwvFxxbMWSyi8gdc5oqpMMJfzm0IxHeLANXcZYtJmHgEoLO f55x9naumx04UQJOjRDgq/tw8dx5UWkDGz7rn7n8XmjaclhUQsqiLWIWlC+tHCz+ 7AK/erSLQHzod1Wmo7G/zMfV6J1hNHH4yY5srnYIWAMVTsanFIg1+oFkvz+24SyU 93q4HZ1YnUAmY2TTzMABM6SRZoRyTzjGYgeCjHQX7QIHJ1uDyYURO6k6PeJ4fkUa 2gEI4wPu7Ctxn+NoT9eURHKQ+k21ck3WoAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddutddvfeegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheprfgrthhrihgt khcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvghrnh epveekkeffhfeitdeludeigfejtdetvdelvdduhefgueegudfghfeukefhjedvkedtnecu vehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkh hsrdhimhdpnhgspghrtghpthhtohepiedpmhhouggvpehsmhhtphhouhhtpdhrtghpthht ohepmhgvsehtthgrhihlohhrrhdrtghomhdprhgtphhtthhopehgihhtshhtvghrsehpoh gsohigrdgtohhmpdhrtghpthhtohepghhithesvhhgvghrrdhkvghrnhgvlhdrohhrghdp rhgtphhtthhopehjlhhtohgslhgvrhesghhmrghilhdrtghomhdprhgtphhtthhopehpvg hffhesphgvfhhfrdhnvghtpdhrtghpthhtohepnhgvfihrvghnsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Oct 2025 00:28:29 -0400 (EDT) Received: by mail (OpenSMTPD) with ESMTPSA id c500a672 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 8 Oct 2025 04:28:28 +0000 (UTC) Date: Wed, 8 Oct 2025 06:28:24 +0200 From: Patrick Steinhardt To: Taylor Blau Cc: git@vger.kernel.org, Jeff King , Junio C Hamano , Elijah Newren , Justin Tobler Subject: Re: [PATCH 21/49] builtin/repack.c: factor our "generated_pack_install" Message-ID: References: <96d27261e75fd2ae46d9633b3d4eff243dbcc187.1759097191.git.me@ttaylorr.com> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Oct 07, 2025 at 04:26:26PM -0400, Taylor Blau wrote: > On Tue, Sep 30, 2025 at 01:21:46AM +0200, Patrick Steinhardt wrote: > > On Sun, Sep 28, 2025 at 06:08:31PM -0400, Taylor Blau wrote: > > > + for_each_string_list_item(item, &names) > > > + generated_pack_install((struct generated_pack *)item->util, > > > > This cast should be unnecessary, right? `item->util` is a void pointer, > > so C should do the cast implicitly. > > It's unnecessary, but I dislike implicit casts from 'void*' to any other > type. This makes it clearer how we're supposed to interpret the value in > item->util, but I'm happy to change it to use the implicit cast if you > feel strongly about it. I think it's common practice to not have such an explicit cast in our code base. But in any case, I don't feel strongly about this. Patrick