Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECF23279784 for ; Thu, 23 Oct 2025 06:40:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761201603; cv=none; b=tmF8mza0WYpMioPnuzusYRUaroVoLHOUVDBezb6MH0SfokQ/SaFWy8YcAJskihob5EGEwsrQM/BNhuj2Z1C3emG6Ms/Suxv8NFu+fzc/ZSoJahCS8PaniZ2cjqdb4xmXEdzbBpA4Ftux6Mcgt0uQJa2OOeX6/tI02EFNgvJB9Xo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761201603; c=relaxed/simple; bh=Y6/cVWozQEm7XgXzQwkSZ4yo+vMKovKzDu+4MKdy4Ao=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hHup5YIkxgRHsJQ+CBJd57aX+LeZahyf/O14jYeKmWc4hzQbaIejLqk8E1HUzTZEH+8n35WzX3DCTRlBNkPOtz3QScD4nFApeCsg7fcPcFIVvtfvscBN2LKiRlkULPJ/7H5lPPUZXwm6yh5fweI/6u08PKDLUf+UQoQKENdpPIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=yPypZO/c; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="yPypZO/c" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=65JbCq98auAx0swzsecpZ4JeIShnUcBYRbYR2M0ONFI=; b=yPypZO/cNEM7pjhukgRcK1fxJj iwnI4D88yUcuI/lZ6vS8KVS9S4j/JTj3YdGPxB22i/w5m0beNwNPrgRRZNj9gE11HyLA7x0hDxMUh AKoX3FV57IxaRP8zax3CeJnGdu+M6pRBKYLGYFoimCq/7yRKDvOhAUY5mq2JQqdFBKHhBqSSfyJgH xSVv1neEVVeGDAKPrd807VWwkAduz8ZAo6eaivQlnek8YdCUDCCaKbG9YUYhoiJdWztNnnbI78UsE 5Up/NjpDZbhB1EDgdTL2d1hE/Xg9l5wSi/ls3u8A5Mnl85KVs/VapgFYiFW7NGdDKZAR+HFobHI+u 0hXINj5g==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vBozP-00000005Ea8-3uAB; Thu, 23 Oct 2025 06:39:59 +0000 Date: Wed, 22 Oct 2025 23:39:59 -0700 From: Christoph Hellwig To: Tom Talpey Cc: Chuck Lever , NeilBrown , Jeff Layton , Olga Kornievskaia , Dai Ngo , linux-nfs@vger.kernel.org, Chuck Lever , Mike Snitzer Subject: Re: [RFC PATCH] NFSD: Make FILE_SYNC WRITEs comply with spec Message-ID: References: <20251022162237.26727-1-cel@kernel.org> <63c79d16-fec8-47f2-ace3-0b8fd4f41528@talpey.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <63c79d16-fec8-47f2-ace3-0b8fd4f41528@talpey.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Wed, Oct 22, 2025 at 01:22:52PM -0400, Tom Talpey wrote: > There needs to be some statement of the performance consequences of > removing this "optimization". I'm going to predict it's significant > on rotating media, and should not go unmeasured. This has absolutely nothing to do with rotating media. The only difference is for pure overwrites. If you have e.g. a database workload that zeroes once and then overwrites you will see a difference on SSD and HDD. For anything that extends files, fills holes etc you won't see any difference.