Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2AF6D2ECF5 for ; Mon, 19 Jan 2026 23:49:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vhyzX-0005gL-Ne; Mon, 19 Jan 2026 18:49:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhyzV-0005ed-He for qemu-devel@nongnu.org; Mon, 19 Jan 2026 18:49:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vhyzT-0005Ix-O3 for qemu-devel@nongnu.org; Mon, 19 Jan 2026 18:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768866537; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o5TTMkR003byE3MegXTYzfMukmv3rzdulck90/5WROs=; b=EqqUsO9YIyTI7kyLwRUy+GV8kO2TwK2CVT0JqZnR6cNNWpcQd4zpPYyHGLpHsu/AWzueDn 96cEEzIsYPt6oDhZFIgVukEQD4tY0X7QeWR7Ve0jzzoREz0cMYupAUaIjNV1cafvt955/O r6uB+yIubHldSBi4KAuF5UTrp3sy5Rg= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-576-ALS6P5z_PAmNSas2FT0MGg-1; Mon, 19 Jan 2026 18:48:52 -0500 X-MC-Unique: ALS6P5z_PAmNSas2FT0MGg-1 X-Mimecast-MFC-AGG-ID: ALS6P5z_PAmNSas2FT0MGg_1768866531 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CB994180045C; Mon, 19 Jan 2026 23:48:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.53]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A52919560A2; Mon, 19 Jan 2026 23:48:48 +0000 (UTC) Date: Mon, 19 Jan 2026 23:48:45 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Michael Tokarev Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] gitlab: preserve base rules for container template Message-ID: References: <20260119135528.2738108-1-berrange@redhat.com> <9fe709ba-e2e9-419f-82b0-219fc96121ed@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9fe709ba-e2e9-419f-82b0-219fc96121ed@tls.msk.ru> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jan 19, 2026 at 11:28:58PM +0300, Michael Tokarev wrote: > On 1/19/26 16:55, Daniel P. Berrangé wrote: > > When extending the container template to allow scheduled piplines in > > upstream context, we must ensure that all the existing rules defined > > by .base_job_template are preserved. > > > > Fortunately since the new rule for scheduled pipelines can come at > > the head of all other rules, not in the middle, we can just the obscure > > '!reference' syntax to pull in all the pre-existing rules as a single > > block. > > > > This fixes > > > > * stable branches using the wrong tag name in container images > > * pushes to forks unconditionally running container builds > > I wont pretend I know what "!reference" means in yaml. But this > change seems to fix both issues, and does not look like it breaks > something. Think of it as a symlink to the "rules" definition in the ".base_job_template": https://docs.gitlab.com/ci/yaml/yaml_optimization/#reference-tags With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|