Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5559E274B51 for ; Wed, 28 Jan 2026 11:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599343; cv=none; b=m+t4lWtcRVTAEQoWvjnTb0RVPRLpzf4jVsWXKD+DG7g3DWvMZEw3dRXgLNTjkoOe51WB2sQuLYznKTu3MvzwZg0DDZ93uN5HAQBdm3jGujt/OEGukVWZCvNj//NNwnyvKiKeYaZNzp0LSwJOvVdqZONY44PfGXAK7bcFhRPCHKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599343; c=relaxed/simple; bh=XNI1PdxzUMCdX20UCO6iHB0ZsB5uIDvd2qbamyYZI5A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8+JFOnqTvKi4lX0PB9+HSeQf8VmDC/6P2ojGTZ3DhjniijV/h3snLT4K8msNJOwSKjCVgAl5LL7s7aqPbNDsAAt/cQ7Oeg9eJxALmAw024BzuTbIIZkAxnZb4q6Bx7/yMErUaJg5mK72R6oVxmZyJcrG3vJWJbRpRwh2md0Qus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U+KcOV2J; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U+KcOV2J" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12336c0a8b6so2375400c88.1 for ; Wed, 28 Jan 2026 03:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769599341; x=1770204141; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QJUI8NJKVSDnIT+QSuw3y5qsdf/HcwP4R02WUPv/Zns=; b=U+KcOV2JO58Jj7i04m+T8AYbKXUUCEDwamVIz8AFpmgLIcrimxphPntYYDUeFPVG8z SCNXgWq3X87/5LOJZ7sCg1F7fkivA2ocgM738bj1F7a5pPFX30VoBdgRuKfsTqWR7Y2l OphdO3BJ2zE+stG0BOtAABDHpc01m+NFWTwtYVLU53O03vT7JkfXMAFARlXe/EbknLW3 bgY+MMavaPS2Yk4lEhob+AYRNqNruMWCH1ZKXM8c2hFYYWrE1xudFz9/wdYfXYyRPnHy nBSKjjtx46l7aF8cSyhpSFn7Uy2zMYwP2MUDxxG7KCi70/65nKe/fY2ZTWzfDGf5fvre Na4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599341; x=1770204141; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QJUI8NJKVSDnIT+QSuw3y5qsdf/HcwP4R02WUPv/Zns=; b=OT9rgf8pG7GmUDrEmTb1oJ0tpb5Symet00P0tC4pERRgWmqfPzoagMyUasQZmkfuLO xH5wK8vqnIp7alH28e0+Wnb7TIyHCsrxhcDBHeK5fGMHwhFubSWImWF44EYg2TrZjbkb WquHBZEWDRzHP/PZ5gf8mlisIe+ypMNgcdSPzijyIfFOyzQmtO/kuADOT4g5496egd+u BZh/abx79EIioVORfffgYOJ/v54//D9ldUgTVh9jpZgGbEisr80wfKO0+mdJYf1by8R7 UPROxH4DM+W4y2M0oSmA9zGe7ZQ14ejY1FH7OXn5EQEbca7wtX+v4t+jpdAK5G/kmvMh wG4w== X-Forwarded-Encrypted: i=1; AJvYcCUIBHy2qunEhdzs0bSYg9JfingUsHX5JgcRQ1Fp5P+G9tLJ4Vr3lklYcXhCdV/pPmnnL8OlfQ5Aa3SZ@vger.kernel.org X-Gm-Message-State: AOJu0YyixprQHImGiCluo46N2M/LRt5o6cT3+q5m7B/6hWFcdEb6fQRj QJQuvSBj2NHNH5nc17GMVHyRszFBJWokRY+IKl3TU77GdP4MG6B2/HG7 X-Gm-Gg: AZuq6aLvV6q4PiqbzBFOm7/2jP4tJV09r1WliyOyWpdaOzwvmHMWl6VuZbOKJCUAAPT b6SVnl50nkw7fhznlt4VSHPImAI0UlMr23GfVjm+GZUW7M63Xbk7chBK44ZsOJW4i4xV967/mY8 eugBOxk2EyNrYAe7+1TD7LBhX05t3JpEHFf8jzlutfZCcqrOhomj+6bF883sB/CBZoIizqp8n1y J+bvEn+jtHOXIMdr0Mp6kqc3uz75bZdDmOFEQRccVCLyigqtcDwhY1NWNca5j5fI7Uf/pepvfgZ 1d0SbDNoOEvK6HTqw/31h77NhtK+VM/7DXMjGuqB7NOXiYpVQryPBz4CPpO+VqZCzOqTDibwXGM tl1v3ITM4ysyOOA6LqLjI3fVo1bI3Zajscl8/KL8+0v8xjDjvuxmnUMu4zNBNA1XyfNJpe6ITrr rw2xxYO6Jm5w== X-Received: by 2002:a05:7022:eb47:20b0:11d:fd26:234e with SMTP id a92af1059eb24-124a0070cbdmr2385944c88.16.1769599341399; Wed, 28 Jan 2026 03:22:21 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a16cf8d6sm2140833eec.3.2026.01.28.03.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 03:22:20 -0800 (PST) Date: Wed, 28 Jan 2026 19:22:02 +0800 From: Inochi Amaoto To: Vivian Wang , Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , "Russell King (Oracle)" , Yao Zi , Yanteng Si , Lad Prabhakar , Maxime Chevallier , Choong Yong Liang , Chen-Yu Tsai , Shangjuan Wei , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260128072931.875041-1-inochiama@gmail.com> <20260128072931.875041-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jan 28, 2026 at 05:16:46PM +0800, Vivian Wang wrote: > Hi Inochi, > > I have some comments below. > > On 1/28/26 15:29, Inochi Amaoto wrote: > > The etherenet controller on Spacemit K3 SoC is Synopsys DesignWare > Typo: etherenet -> ethernet > > MAC (version 5.40a), with the following special point: > Nit: point -> points  Thanks > > 1. The rate of the tx clock line is auto changed when the mac speed > > rate is changed, and no need for changing the input tx clock. > > 2. This controller require a extra syscon device to configure the > > interface type, enable wake up interrupt and delay configuration > > if needed. > > > > Add Spacemit dwmac driver support on the Spacemit K3 SoC. > > > > Signed-off-by: Inochi Amaoto > > --- > > drivers/net/ethernet/stmicro/stmmac/Kconfig | 12 + > > drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + > > .../ethernet/stmicro/stmmac/dwmac-spacemit.c | 218 ++++++++++++++++++ > > 3 files changed, 231 insertions(+) > > create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c > > > > [...] > > > > + > > +/* dline register bits */ > > +#define RGMII_RX_DLINE_EN BIT(0) > > +#define RGMII_RX_DLINE_STEP GENMASK(5, 4) > > +#define RGMII_RX_DLINE_CODE GENMASK(15, 8) > > +#define RGMII_TX_DLINE_EN BIT(16) > > +#define RGMII_TX_DLINE_STEP GENMASK(21, 20) > > +#define RGMII_TX_DLINE_CODE GENMASK(31, 24) > > + > > +#define MAX_DLINE_DELAY_CODE 0xff > > +#define MAX_WORKED_DELAY 2800 > > + > > +/* Note: the delay step value is at 0.1ps */ > > +static const unsigned int k3_delay_step_10x[4] = { > > + 367, 493, 559, 685 > > +}; > > + > > +static int spacemit_dwmac_set_delay(struct regmap *apmu, > > + unsigned int dline_offset, > > + unsigned int tx_code, unsigned int tx_config, > > + unsigned int rx_code, unsigned int rx_config) > > +{ > > + unsigned int mask, val; > > + > > + mask = RGMII_TX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN | > > + RGMII_RX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN; > > + val = FIELD_PREP(RGMII_TX_DLINE_STEP, tx_config) | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN | > > + FIELD_PREP(RGMII_RX_DLINE_STEP, rx_config) | > > + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN; > > + > > + return regmap_update_bits(apmu, dline_offset, mask, val); > > +} > > + > > +static int spacemit_dwmac_detected_delay_value(unsigned int delay, > > + unsigned int *config) > > +{ > > + unsigned int best_delay = 0; > > + unsigned int best_config = 0; > > + int best_code = 0; > > + int i; > > + > > + if (delay == 0) > > + return 0; > > + > > + if (delay > MAX_WORKED_DELAY) > > + return -EINVAL; > > + > > + /* > > + * Note K3 require a specific factor for calculate > > + * the delay, in this scenario it is 0.9. So the > > + * formula is code * step / 10 * 0.9 > > + */ > > + for (i = 0; i < ARRAY_SIZE(k3_delay_step_10x); i++) { > > + unsigned int step = k3_delay_step_10x[i]; > > + int code = DIV_ROUND_CLOSEST(delay * 10 * 10, step * 9); > > + unsigned int tmp = code * step * 9 / 10 / 10; > > + > > + if (abs(tmp - delay) < abs(best_delay - delay)) { > > + best_code = code; > > + best_delay = tmp; > > + best_config = i; > > + } > > + } > > + > > + *config = best_config; > > + > > + return best_code; > > Is this really necessary? For K1 I just used the smallest step size. > > It seems to me you have, for the smallest step size, about 36.7ps * 0.9 > = 33ps per step. Theoretically speaking that lets you fine tune the > delay to within 1% of the 2ns total required RGMII delay (MAC + PCB + > PHY). In practice this number shouldn't be that marginal.  > I think it is reasonable, I will take you advice and use the smallest step size. Regards, Inochi