Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 230F8E68158 for ; Tue, 17 Feb 2026 09:55:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vsHni-0006B6-TG; Tue, 17 Feb 2026 04:55:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsHnh-00069P-0J for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:55:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vsHne-0000nw-VK for qemu-devel@nongnu.org; Tue, 17 Feb 2026 04:55:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771322121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5e0wSzLvMMSKsnTKlgNh2OH56IjGtiZR5DVzAEfqZIM=; b=fPjWlt636A6rPx9yN6iQHE9qJ9j4unPA6849v17FGngLqhhKoxk5to36/IJOrtR3Ym7dXx HNJsLE+O7Rdk8BMcx8E2ZnaluqL2PD+GkZVIcWp00vVenUHdu3At7kgPD9Dn22MaLIfXVX TSyHK4ttzEG79v5kuzDOk3q+GAAkOdk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-kNvYwMHZM7-8Qw1nOw9lmg-1; Tue, 17 Feb 2026 04:55:20 -0500 X-MC-Unique: kNvYwMHZM7-8Qw1nOw9lmg-1 X-Mimecast-MFC-AGG-ID: kNvYwMHZM7-8Qw1nOw9lmg_1771322119 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3C831800454; Tue, 17 Feb 2026 09:55:18 +0000 (UTC) Received: from angien.pipo.sk (unknown [10.44.34.119]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 905CA180034A; Tue, 17 Feb 2026 09:55:16 +0000 (UTC) Date: Tue, 17 Feb 2026 10:55:13 +0100 From: Peter Krempa To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Cc: Peter Xu , qemu-devel@nongnu.org, Juraj Marcin , Fabiano Rosas , Markus Armbruster , Prasad Pandit Subject: Re: [PATCH v2 0/2] migration: feature removals for 11.0 Message-ID: References: <20260115225503.3083355-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=pkrempa@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 17, 2026 at 09:47:08 +0000, Daniel P. Berrangé wrote: > On Tue, Feb 17, 2026 at 10:29:38AM +0100, Peter Krempa wrote: > > On Thu, Jan 15, 2026 at 17:55:01 -0500, Peter Xu wrote: > > > v2: > > > - Added R-bs > > > - Updated description for removing zero-blocks [Markus] > > > - Squashed the "fd: to file" test removal into the 2nd patch > > > - I dropped the COLO patch, I have a local patch to remove colo migration > > > completely, but looks like we won't do it.. Let's leave it for later but > > > do the rest first > > > > > > This series removes two deprecated features for 11.0. > > > > > > Please review, thanks. > > > > > > Peter Xu (2): > > > migration: Remove zero-blocks capability > > > migration: Remove fd: support on files > > > > > > docs/about/deprecated.rst | 20 ------------- > > > > Note that per the 'MAINTAINERS' file, changes to any deprecations ought > > to be CC'd to the libvirt list for visibility. > > > > In this case we've forgotten about the deprecation and didn't fix it > > before the qemu cahnge was pushed. I'll send out patches soon, but keep > > in mind to *always* CC the libvirt list with deprecations. > > I'm suprised to see libvirt broken at all here. > > AFAIR, the 'fd:' protocol inadvertantly gained support for targetting > plain files, which the deprecation aimed to then revert (remove). The > actual removal though seems to have targetted anything which is not a > socket, which includes pipes, which libvirt was using. Libvirt is using pipes for *most* cases, but not all. There is one code path (virsh restore without compression or cache bypass, when residing on an actual filesystem (not a root squashed NFS)) which still can pass a file FD to the migration code as 'fd:'. In all other cases we do pass in a pipe in one way or another (via the compression program, virFileWrapper (mandatorily used on equivalents of 'virsh save', or the helper process used to access root-squashed NFS). The code is not easy to follow because there are numerous layers where the wrapping of the file into a pipe can happen, one of which is right next to the migration code. I'll soon post patches. Anyways, my point was that notifications about deprecated and removed features ought to be CCd to the libvirt list regardless of perceived impact on libvirt.