From: "flichtenheld (Code Review)" Date: Wed, 29 Jan 2025 12:15:46 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="S+MZRG8aKeg="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: options: add IPv4 support to '--show-gateway ' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: cron2 Cc: plaisthos , openvpn-devel --S+MZRG8aKeg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/881?usp=3Demail ) Change subject: options: add IPv4 support to '--show-gateway ' ...................................................................... Patch Set 1: Code-Review-2 (3 comments) Patchset: PS1: Doesn't work for me File doc/man-sections/advanced-options.rst: http://gerrit.openvpn.net/c/openvpn/+/881/comment/4991ae80_16c9b46c : PS1, Line 12: --show-gateway IPv4-target Please also update usage information File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/881/comment/2277d987_7a2196d9 : PS1, Line 5875: get_default_gateway(&rgi, remote_ipv4, &net_ctx); Does not seem to work for me. It always displays the system default gateway= , not the gateway for the IP address. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/881?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic438c583a782035ecb9b5ea65702a768ae2585f5 Gerrit-Change-Number: 881 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Comment-Date: Wed, 29 Jan 2025 12:15:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --S+MZRG8aKeg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, plaisthos.

Patch set 1:Code-Review -2=

Vi= ew Change

3 comments:

  • Patchset:

  • File doc/man-sections/advanced-options= .rst:

  • File src/openvpn/options.c:

    • Patch Set #1, Line 5875: get_default_gateway(&= amp;rgi, remote_ipv4, &net_ctx);

      Does not seem to work for me. It always disp= lays the system default gateway, not the gateway for the IP address.

To view, visit change 881. To unsubscribe, or for help writi= ng mail filters, visit setti= ngs.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ic438c583a782035ecb9b5ea6570= 2a768ae2585f5
Gerrit-Change-Number: 881
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Comment-Date: Wed, 29 Jan 2025 12:15:46= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--S+MZRG8aKeg=--