From: Oscar Mateo Subject: Re: [PATCH 3/6] drm/i915/icl: new context descriptor support Date: Tue, 6 Mar 2018 14:27:24 -0800 Message-ID: References: <20180302161501.28594-1-mika.kuoppala@linux.intel.com> <20180302161501.28594-3-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 906B16E358 for ; Tue, 6 Mar 2018 22:27:25 +0000 (UTC) In-Reply-To: <20180302161501.28594-3-mika.kuoppala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mika Kuoppala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAzLzIvMjAxOCA4OjE0IEFNLCBNaWthIEt1b3BwYWxhIHdyb3RlOgo+IEZyb206IERhbmll bGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+Cj4KPiBT dGFydGluZyBmcm9tIEdlbjExIHRoZSBjb250ZXh0IGRlc2NyaXB0b3IgZm9ybWF0IGhhcyBiZWVu IHVwZGF0ZWQgaW4KPiB0aGUgSFcuIFRoZSBod19pZCBmaWVsZCBoYXMgYmVlbiBjb25zaWRlcmFi bHkgcmVkdWNlZCBpbiBzaXplIGFuZCBlbmdpbmUKPiBjbGFzcyBhbmQgaW5zdGFuY2UgZmllbGRz IGhhdmUgYmVlbiBhZGRlZC4KPgo+IFRoZXJlIGlzIGEgc2xpZ2h0IG5hbWUgY2xhc2hpbmcgaXNz dWUgYmVjYXVzZSB0aGUgZmllbGQgdGhhdCB3ZSBjYWxsCj4gaHdfaWQgaXMgYWN0dWFsbHkgY2Fs bGVkIFNXIENvbnRleHQgSUQgaW4gdGhlIHNwZWNzIGZvciBHZW4xMSsuCj4KPiBXaXRoIHRoZSBj dXJyZW50IHNpemUgb2YgdGhlIGh3X2lkIGZpZWxkIHdlIGNhbiBoYXZlIGEgbWF4aW11bSBvZiAy awo+IGNvbnRleHRzIGF0IGFueSB0aW1lLCBidXQgd2UgY291bGQgdXNlIHRoZSBzd19jb3VudGVy IGZpZWxkICh3aGljaCBpcyBzdwo+IGRlZmluZWQpIHRvIGluY3JlYXNlIHRoYXQgYmVjYXVzZSB0 aGUgSFcgcmVxdWlyZW1lbnQgaXMgdGhhdAo+IGVuZ2luZV9pZCArIHN3IGlkICsgc3dfY291bnRl ciBpcyBhIHVuaXF1ZSBudW1iZXIuCj4gR3VDIHVzZXMgYSBzaW1pbGFyIG1ldGhvZCB0byBzdXBw b3J0IG1vcmUgY29udGV4dHMgYnV0IGRvZXMgaXRzIHRyYWNraW5nCj4gYXQgbHJjIGxldmVsLiBU byBhdm9pZCBkb2luZyBhbiBpbXBsZW1lbnRhdGlvbiB0aGF0IHdpbGwgbmVlZCB0byBiZQo+IHJl d29ya2VkIG9uY2UgR3VDIHN1cHBvcnQgbGFuZHMsIGRlZmVyIGl0IGZvciBub3cgYW5kIG1hcmsg aXQgYXMgVE9ETy4KPgo+IHYyOiByZWJhc2VkLCBhZGQgZG9jdW1lbnRhdGlvbiwgZml4IEdFTjEx X0VOR0lORV9JTlNUQU5DRV9TSElGVAo+IHYzOiByZWJhc2VkLCBicmluZyBiYWNrIGxvc3QgY29k ZSBmcm9tIGk5MTVfZ2VtX2NvbnRleHQuYwo+IHY0OiBtYWtlIFRPRE8gY29tbWVudCBtb3JlIGdl bmVyaWMKPiB2NTogYmUgY29uc2lzdGVudCB3aXRoIGJpdCBvcmRlcmluZywgYWRkIGV4dHJhIGNo ZWNrcyAoQ2hyaXMpCj4KPiBDYzogT3NjYXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4K PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1pa2Eg S3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IERhbmllbGUgQ2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+ Cgp2NSBzdGlsbCBsb29rcyBnb29kIHRvIG1lOgpSZXZpZXdlZC1ieTogT3NjYXIgTWF0ZW8gPG9z Y2FyLm1hdGVvQGludGVsLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oICAgICAgICAgfCAgMSArCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9j b250ZXh0LmMgfCAxMSArKysrKysrKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oICAgICAgICAgfCAgNiArKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Vu Z2luZV9jcy5jICB8ICAzICsrKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMg ICAgICAgIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gICA1IGZpbGVz IGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiBpbmRleCAxMGM5ZTVlNjE5YWIuLjhlMmU2NTg1NTQ5ZCAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yMTAzLDYgKzIxMDMsNyBAQCBzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSB7Cj4gICAJCSAqLwo+ICAgCQlzdHJ1Y3QgaWRhIGh3X2lkYTsKPiAgICNkZWZp bmUgTUFYX0NPTlRFWFRfSFdfSUQgKDE8PDIxKSAvKiBleGNsdXNpdmUgKi8KPiArI2RlZmluZSBH RU4xMV9NQVhfQ09OVEVYVF9IV19JRCAoMTw8MTEpIC8qIGV4Y2x1c2l2ZSAqLwo+ICAgCX0gY29u dGV4dHM7Cj4gICAKPiAgIAl1MzIgZmRpX3J4X2NvbmZpZzsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9nZW1fY29udGV4dC5jCj4gaW5kZXggYTczMzQwYWU5NDE5Li5mMmNiZWE3Y2Y5NDAgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fY29udGV4dC5jCj4gQEAgLTIxMSw5ICsy MTEsMTUgQEAgc3RhdGljIHZvaWQgY29udGV4dF9jbG9zZShzdHJ1Y3QgaTkxNV9nZW1fY29udGV4 dCAqY3R4KQo+ICAgc3RhdGljIGludCBhc3NpZ25faHdfaWQoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LCB1bnNpZ25lZCAqb3V0KQo+ICAgewo+ICAgCWludCByZXQ7Cj4gKwl1bnNp Z25lZCBpbnQgbWF4Owo+ICsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ICsJ CW1heCA9IEdFTjExX01BWF9DT05URVhUX0hXX0lEOwo+ICsJZWxzZQo+ICsJCW1heCA9IE1BWF9D T05URVhUX0hXX0lEOwo+ICAgCj4gICAJcmV0ID0gaWRhX3NpbXBsZV9nZXQoJmRldl9wcml2LT5j b250ZXh0cy5od19pZGEsCj4gLQkJCSAgICAgMCwgTUFYX0NPTlRFWFRfSFdfSUQsIEdGUF9LRVJO RUwpOwo+ICsJCQkgICAgIDAsIG1heCwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKHJldCA8IDApIHsK PiAgIAkJLyogQ29udGV4dHMgYXJlIG9ubHkgcmVsZWFzZWQgd2hlbiBubyBsb25nZXIgYWN0aXZl Lgo+ICAgCQkgKiBGbHVzaCBhbnkgcGVuZGluZyByZXRpcmVzIHRvIGhvcGVmdWxseSByZWxlYXNl IHNvbWUKPiBAQCAtMjIxLDcgKzIyNyw3IEBAIHN0YXRpYyBpbnQgYXNzaWduX2h3X2lkKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdW5zaWduZWQgKm91dCkKPiAgIAkJICovCj4g ICAJCWk5MTVfcmV0aXJlX3JlcXVlc3RzKGRldl9wcml2KTsKPiAgIAkJcmV0ID0gaWRhX3NpbXBs ZV9nZXQoJmRldl9wcml2LT5jb250ZXh0cy5od19pZGEsCj4gLQkJCQkgICAgIDAsIE1BWF9DT05U RVhUX0hXX0lELCBHRlBfS0VSTkVMKTsKPiArCQkJCSAgICAgMCwgbWF4LCBHRlBfS0VSTkVMKTsK PiAgIAkJaWYgKHJldCA8IDApCj4gICAJCQlyZXR1cm4gcmV0Owo+ICAgCX0KPiBAQCAtNDYzLDYg KzQ2OSw3IEBAIGludCBpOTE1X2dlbV9jb250ZXh0c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiAgIAo+ICAgCS8qIFVzaW5nIHRoZSBzaW1wbGUgaWRhIGludGVyZmFj ZSwgdGhlIG1heCBpcyBsaW1pdGVkIGJ5IHNpemVvZihpbnQpICovCj4gICAJQlVJTERfQlVHX09O KE1BWF9DT05URVhUX0hXX0lEID4gSU5UX01BWCk7Cj4gKwlCVUlMRF9CVUdfT04oR0VOMTFfTUFY X0NPTlRFWFRfSFdfSUQgPiBJTlRfTUFYKTsKPiAgIAlpZGFfaW5pdCgmZGV2X3ByaXYtPmNvbnRl eHRzLmh3X2lkYSk7Cj4gICAKPiAgIAkvKiBsb3dlc3QgcHJpb3JpdHk7IGlkbGUgdGFzayAqLwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IGluZGV4IDQ1YWUwNWQwZmU3OC4uOWE2MmQyMGJlYThl IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gQEAgLTM5MTIsNiArMzkxMiwxMiBAQCBl bnVtIHsKPiAgIAo+ICAgI2RlZmluZSBHRU44X0NUWF9JRF9TSElGVCAzMgo+ICAgI2RlZmluZSBH RU44X0NUWF9JRF9XSURUSCAyMQo+ICsjZGVmaW5lIEdFTjExX1NXX0NUWF9JRF9TSElGVCAzNwo+ ICsjZGVmaW5lIEdFTjExX1NXX0NUWF9JRF9XSURUSCAxMQo+ICsjZGVmaW5lIEdFTjExX0VOR0lO RV9DTEFTU19TSElGVCA2MQo+ICsjZGVmaW5lIEdFTjExX0VOR0lORV9DTEFTU19XSURUSCAzCj4g KyNkZWZpbmUgR0VOMTFfRU5HSU5FX0lOU1RBTkNFX1NISUZUIDQ4Cj4gKyNkZWZpbmUgR0VOMTFf RU5HSU5FX0lOU1RBTkNFX1dJRFRIIDYKPiAgIAo+ICAgI2RlZmluZSBDSFZfQ0xLX0NUTDEJCQlf TU1JTygweDEwMTEwMCkKPiAgICNkZWZpbmUgVkxWX0NMS19DVEwyCQkJX01NSU8oMHgxMDExMDQp Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCA5MTFmYzA4NjU4 YzUuLjRiYTEzOWMyN2ZiYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9j cy5jCj4gQEAgLTIzNCw2ICsyMzQsOSBAQCBpbnRlbF9lbmdpbmVfc2V0dXAoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgCUdFTV9CVUdfT04oaW5mby0+Y2xhc3MgPj0gQVJS QVlfU0laRShpbnRlbF9lbmdpbmVfY2xhc3NlcykpOwo+ICAgCWNsYXNzX2luZm8gPSAmaW50ZWxf ZW5naW5lX2NsYXNzZXNbaW5mby0+Y2xhc3NdOwo+ICAgCj4gKwlCVUlMRF9CVUdfT04oTUFYX0VO R0lORV9DTEFTUyA+PSBCSVQoR0VOMTFfRU5HSU5FX0NMQVNTX1dJRFRIKSk7Cj4gKwlCVUlMRF9C VUdfT04oTUFYX0VOR0lORV9JTlNUQU5DRSA+PSBCSVQoR0VOMTFfRU5HSU5FX0lOU1RBTkNFX1dJ RFRIKSk7Cj4gKwo+ICAgCWlmIChHRU1fV0FSTl9PTihpbmZvLT5jbGFzcyA+IE1BWF9FTkdJTkVf Q0xBU1MpKQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xy Yy5jCj4gaW5kZXggYTk2Mjg4Yzg1Y2I5Li5lNTBkODZhZjEzNDUgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9scmMuYwo+IEBAIC0yMDQsNiArMjA0LDE4IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBu ZWVkX3ByZWVtcHQoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgICog ICAgICBiaXRzIDMyLTUyOiAgICBjdHggSUQsIGEgZ2xvYmFsbHkgdW5pcXVlIHRhZwo+ICAgICog ICAgICBiaXRzIDUzLTU0OiAgICBtYnosIHJlc2VydmVkIGZvciB1c2UgYnkgaGFyZHdhcmUKPiAg ICAqICAgICAgYml0cyA1NS02MzogICAgZ3JvdXAgSUQsIGN1cnJlbnRseSB1bnVzZWQgYW5kIHNl dCB0byAwCj4gKyAqCj4gKyAqIFN0YXJ0aW5nIGZyb20gR2VuMTEsIHRoZSB1cHBlciBkd29yZCBv ZiB0aGUgZGVzY3JpcHRvciBoYXMgYSBuZXcgZm9ybWF0Ogo+ICsgKgo+ICsgKiAgICAgIGJpdHMg MzItMzY6ICAgIHJlc2VydmVkCj4gKyAqICAgICAgYml0cyAzNy00NzogICAgU1cgY29udGV4dCBJ RAo+ICsgKiAgICAgIGJpdHMgNDg6NTM6ICAgIGVuZ2luZSBpbnN0YW5jZQo+ICsgKiAgICAgIGJp dCA1NDogICAgICAgIG1ieiwgcmVzZXJ2ZWQgZm9yIHVzZSBieSBoYXJkd2FyZQo+ICsgKiAgICAg IGJpdHMgNTUtNjA6ICAgIFNXIGNvdW50ZXIKPiArICogICAgICBiaXRzIDYxLTYzOiAgICBlbmdp bmUgY2xhc3MKPiArICoKPiArICogZW5naW5lIGluZm8sIFNXIGNvbnRleHQgSUQgYW5kIFNXIGNv dW50ZXIgbmVlZCB0byBmb3JtIGEgdW5pcXVlIG51bWJlcgo+ICsgKiAoQ29udGV4dCBJRCkgcGVy IGxyYy4KPiAgICAqLwo+ICAgc3RhdGljIHZvaWQKPiAgIGludGVsX2xyX2NvbnRleHRfZGVzY3Jp cHRvcl91cGRhdGUoc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPiBAQCAtMjEyLDEyICsy MjQsMzIgQEAgaW50ZWxfbHJfY29udGV4dF9kZXNjcmlwdG9yX3VwZGF0ZShzdHJ1Y3QgaTkxNV9n ZW1fY29udGV4dCAqY3R4LAo+ICAgCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSA9ICZjdHgtPmVu Z2luZVtlbmdpbmUtPmlkXTsKPiAgIAl1NjQgZGVzYzsKPiAgIAo+IC0JQlVJTERfQlVHX09OKE1B WF9DT05URVhUX0hXX0lEID4gKDE8PEdFTjhfQ1RYX0lEX1dJRFRIKSk7Cj4gKwlCVUlMRF9CVUdf T04oTUFYX0NPTlRFWFRfSFdfSUQgPiAoQklUKEdFTjhfQ1RYX0lEX1dJRFRIKSkpOwo+ICsJQlVJ TERfQlVHX09OKEdFTjExX01BWF9DT05URVhUX0hXX0lEID4gKEJJVChHRU4xMV9TV19DVFhfSURf V0lEVEgpKSk7Cj4gICAKPiAgIAlkZXNjID0gY3R4LT5kZXNjX3RlbXBsYXRlOwkJCQkvKiBiaXRz ICAwLTExICovCj4gKwlHRU1fQlVHX09OKGRlc2MgJiBHRU5NQVNLX1VMTCg2MywgMTIpKTsKPiAr Cj4gICAJZGVzYyB8PSBpOTE1X2dndHRfb2Zmc2V0KGNlLT5zdGF0ZSkgKyBMUkNfSEVBREVSX1BB R0VTICogUEFHRV9TSVpFOwo+ICAgCQkJCQkJCQkvKiBiaXRzIDEyLTMxICovCj4gLQlkZXNjIHw9 ICh1NjQpY3R4LT5od19pZCA8PCBHRU44X0NUWF9JRF9TSElGVDsJCS8qIGJpdHMgMzItNTIgKi8K PiArCUdFTV9CVUdfT04oZGVzYyAmIEdFTk1BU0tfVUxMKDYzLCAzMikpOwo+ICsKPiArCWlmIChJ TlRFTF9HRU4oY3R4LT5pOTE1KSA+PSAxMSkgewo+ICsJCUdFTV9CVUdfT04oY3R4LT5od19pZCA+ PSBCSVQoR0VOMTFfU1dfQ1RYX0lEX1dJRFRIKSk7Cj4gKwkJZGVzYyB8PSAodTY0KWN0eC0+aHdf aWQgPDwgR0VOMTFfU1dfQ1RYX0lEX1NISUZUOwo+ICsJCQkJCQkJCS8qIGJpdHMgMzctNDcgKi8K PiArCj4gKwkJZGVzYyB8PSAodTY0KWVuZ2luZS0+aW5zdGFuY2UgPDwgR0VOMTFfRU5HSU5FX0lO U1RBTkNFX1NISUZUOwo+ICsJCQkJCQkJCS8qIGJpdHMgNDgtNTMgKi8KPiArCj4gKwkJLyogVE9E TzogZGVjaWRlIHdoYXQgdG8gZG8gd2l0aCBTVyBjb3VudGVyIChiaXRzIDU1LTYwKSAqLwo+ICsK PiArCQlkZXNjIHw9ICh1NjQpZW5naW5lLT5jbGFzcyA8PCBHRU4xMV9FTkdJTkVfQ0xBU1NfU0hJ RlQ7Cj4gKwkJCQkJCQkJLyogYml0cyA2MS02MyAqLwo+ICsJfSBlbHNlIHsKPiArCQlHRU1fQlVH X09OKGN0eC0+aHdfaWQgPj0gQklUKEdFTjhfQ1RYX0lEX1dJRFRIKSk7Cj4gKwkJZGVzYyB8PSAo dTY0KWN0eC0+aHdfaWQgPDwgR0VOOF9DVFhfSURfU0hJRlQ7CS8qIGJpdHMgMzItNTIgKi8KPiAr CX0KPiAgIAo+ICAgCWNlLT5scmNfZGVzYyA9IGRlc2M7Cj4gICB9CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK