From: "MaxF (Code Review)" Date: Fri, 27 Dec 2024 18:32:47 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="HF7aTiJX8MA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Add methods to read/write packet ids for epoch data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: flichtenheld , stipa , openvpn-devel --HF7aTiJX8MA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open= vpn/+/803?usp=3Demail ) Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 8: (5 comments) Patchset: PS8: Nitpicks about comments, code looks good to me. File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/c836da37_30744229 : PS8, Line 49: Maks Mask http://gerrit.openvpn.net/c/openvpn/+/803/comment/ecbf03a7_cb2058dd : PS8, Line 331: packed I'm thinking this is a typo. Or is it actually a packed struct? http://gerrit.openvpn.net/c/openvpn/+/803/comment/8101af1b_44e6d50f : PS8, Line 333: epcoh epoch File tests/unit_tests/openvpn/test_packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/230d5a2f_40d775b3 : PS8, Line 241: /* test writing/checking the 48 bit overflow */ I don't get it, what overflow? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: MaxF Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Fri, 27 Dec 2024 18:32:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --HF7aTiJX8MA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

View C= hange

5 comments:

T= o view, visit change 803. To unsubscribe, or for help writing mail filters, visi= t settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bc= d0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: MaxF <max@...2606...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:32:47= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--HF7aTiJX8MA=--