Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C955C54ED0 for ; Fri, 23 May 2025 03:06:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uIIjB-0006L6-KZ; Thu, 22 May 2025 23:05:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIIj8-0006KK-4V; Thu, 22 May 2025 23:05:42 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uIIj4-000681-OL; Thu, 22 May 2025 23:05:41 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54MNW3mR024545; Fri, 23 May 2025 03:05:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=bcKvGZytaqfv2ruuVKsxkcSGuVKWVq z2c90fCuIWfwE=; b=NyybVFgf08TZEk8I3w9EFMuogrX1KIVjCiOhGc0MtKDj1K J9Q8I2bhQNlhX7MkhYG63R0JeW2gZ4Bc4D4C+u1wgAHXdwA/XD+cPbWfCENnKe5a OeQ7IstoMxsZAdWipnpKhmKiKwCfT1bRXp+nbFusHXjLQfPjAZQwWl5TBkEaKVFT w3y8UQIJw/EynbXQcPRG2J1APS4HzZlinELNFE/W6c3rir7MQcZlecWyROZTh/6k Eu1GrJQ5lcI50x342u8gjO6A49uNzqCcdMMX/0QH2vb02fchYK5wKoy/xHnda5BE ow46a69NcmoFHq0EAttj15u7doXNnz7C7JiFmFRA== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46sxhwdc6g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 03:05:35 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54N28RK8032014; Fri, 23 May 2025 03:05:34 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46rwmqcky6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 03:05:34 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54N35W6Y33030674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 May 2025 03:05:33 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DDAFB58059; Fri, 23 May 2025 03:05:32 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E325D5805D; Fri, 23 May 2025 03:05:31 +0000 (GMT) Received: from [9.61.243.208] (unknown [9.61.243.208]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 May 2025 03:05:31 +0000 (GMT) Content-Type: multipart/alternative; boundary="------------tZG990njYq6xxF8NDTFCO6Ci" Message-ID: Date: Thu, 22 May 2025 23:05:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event To: Anthony Krowiak , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, borntraeger@linux.ibm.com, alex.williamson@redhat.com, thuth@redhat.com References: <20250512180230.50129-1-rreyes@linux.ibm.com> <20250512180230.50129-4-rreyes@linux.ibm.com> <8a80ca26-69f3-4d7c-85c1-19d269fea504@linux.ibm.com> Content-Language: en-US From: Rorie Reyes In-Reply-To: <8a80ca26-69f3-4d7c-85c1-19d269fea504@linux.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDAyMiBTYWx0ZWRfX2UFVjt4JFt2B UouSyOU7hhBz5O3/J/Ve1G7WwGzlpvr05Cg3UgEKkP67XwYZVNpEvr5jwzc9kR8v6hmi6DfHKSj wybV5xOY2B9j+9L7WR7FX56fyNqolUuAHj/RyHvsC4izmuP5J6skJ42R7jburcMNbOLjK6aVOqr qqi6+CDLDiIp7ci39SURoV0yZVALxpf7Naw8bNevW7+CEV9IEx2Hu/rpkp3eBXC116nGE2u0TSg Kzc3jyDXxBxCqn/LHNHx2S5Kcq9ySRVJYVSgRqfALZSX3VFP+hN87rES1onyNTv5w9A+v5t9w3e GTiVMvCc6Df4a4l5SWVHcJ/Lk6xCoY9jyx/W4c5XvQafylCYclIvfTmf3VnR95cpzCm+scAtpP7 dJdlTJJYS+A4j2J3iso4HEhr2rvpe9nFESqyxNYD0Ka8x0dIgHySYPknO6//tl1UMRNju1t6 X-Proofpoint-GUID: EzQYw9Iu84fJ61FGHpKsr1jBBejmJMjt X-Authority-Analysis: v=2.4 cv=O685vA9W c=1 sm=1 tr=0 ts=682fe5ff cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=dt9VzEwgFbYA:10 a=sWKEhP36mHoA:10 a=r77TgQKjGQsHNAKrUKIA:9 a=VnNF1IyMAAAA:8 a=yEqbreF_wN8NoTZK8aoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=eOMxQ1cS9dQaMRMiKsEA:9 a=KOmEWWFEuJVDpoQE:21 a=_W_S_7VecoQA:10 a=lqcHg5cX4UMA:10 X-Proofpoint-ORIG-GUID: EzQYw9Iu84fJ61FGHpKsr1jBBejmJMjt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_01,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505230022 Received-SPF: pass client-ip=148.163.156.1; envelope-from=rreyes@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This is a multi-part message in MIME format. --------------tZG990njYq6xxF8NDTFCO6Ci Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/22/25 3:02 PM, Anthony Krowiak wrote: > > > > On 5/22/25 9:35 AM, Cédric Le Goater wrote: >> On 5/12/25 20:02, Rorie Reyes wrote: >>> These functions can be invoked by the function that handles >>> interception >>> of the CHSC SEI instruction for requests indicating the >>> accessibility of >>> one or more adjunct processors has changed. >>> >>> Signed-off-by: Rorie Reyes >>> --- >>>   hw/vfio/ap.c                 | 39 >>> ++++++++++++++++++++++++++++++++++++ >>>   include/hw/s390x/ap-bridge.h | 22 ++++++++++++++++++++ >>>   2 files changed, 61 insertions(+) >>> >>> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c >>> index 5ea5dd9cca..4f88f80c54 100644 >>> --- a/hw/vfio/ap.c >>> +++ b/hw/vfio/ap.c >>> @@ -96,6 +96,45 @@ static void vfio_ap_cfg_chg_notifier_handler(void >>> *opaque) >>>     } >>>   +int ap_chsc_sei_nt0_get_event(void *res) >>> +{ >>> +    ChscSeiNt0Res *nt0_res  = (ChscSeiNt0Res *)res; >>> +    APConfigChgEvent *cfg_chg_event; >>> + >>> +    if (!ap_chsc_sei_nt0_have_event()) { >>> +        return 1; >>> +    } >>> + >>> +    cfg_chg_event = QTAILQ_FIRST(&cfg_chg_events); >>> +    memset(nt0_res, 0, sizeof(*nt0_res)); >>> + >>> +    QTAILQ_REMOVE(&cfg_chg_events, cfg_chg_event, next); >>> +    g_free(cfg_chg_event); >>> + >>> +    /* >>> +     * If there are any AP configuration change events in the queue, >>> +     * indicate to the caller that there is pending event info in >>> +     * the response block >>> +     */ >>> +    if (ap_chsc_sei_nt0_have_event()) { >>> +        nt0_res->flags |= PENDING_EVENT_INFO_BITMASK; >>> +    } >>> + >>> +    nt0_res->length = sizeof(ChscSeiNt0Res); >>> +    nt0_res->code = NT0_RES_RESPONSE_CODE; >>> +    nt0_res->nt = NT0_RES_NT_DEFAULT; >>> +    nt0_res->rs = NT0_RES_RS_AP_CHANGE; >>> +    nt0_res->cc = NT0_RES_CC_AP_CHANGE; >>> + >>> +    return 0; >>> + >> >> extra white line ^ >> >> and returning a bool would make more sense. > > It may make more sense from a readability standpoint, > but if you look at the caller (chsc_sei_nt0_get_event in > target/s390x/ioinst.c), > it returns an int, so it can simply return whatever is returned from this > function. On the other hand, it really doesn't make a difference, so if > you feel strongly about this, then it can be changed to a bool. > > I think I'd rather keep the returns as is because I've went through several changes that uses a bool return and my code doesn't work as designed. The ap config doesn't update in real time which allows the polling time to take over when notifying the guest. Would it suffice to document the following in ap-bridge.h (the comment bellow) >> >>> +} >>> + >>> +int ap_chsc_sei_nt0_have_event(void) >>> +{ >>> +    return !QTAILQ_EMPTY(&cfg_chg_events); >> >> same here for the bool. > > same as above > >> >>> +} >>> + >>>   static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev, >>>                                             unsigned int irq, Error >>> **errp) >>>   { >>> diff --git a/include/hw/s390x/ap-bridge.h >>> b/include/hw/s390x/ap-bridge.h >>> index 470e439a98..f4d838bf99 100644 >>> --- a/include/hw/s390x/ap-bridge.h >>> +++ b/include/hw/s390x/ap-bridge.h >>> @@ -16,4 +16,26 @@ >>>     void s390_init_ap(void); >>>   +typedef struct ChscSeiNt0Res { >>> +    uint16_t length; >>> +    uint16_t code; >>> +    uint8_t reserved1; >>> +    uint16_t reserved2; >>> +    uint8_t nt; >>> +#define PENDING_EVENT_INFO_BITMASK 0x80; >>> +    uint8_t flags; >>> +    uint8_t reserved3; >>> +    uint8_t rs; >>> +    uint8_t cc; >>> +} QEMU_PACKED ChscSeiNt0Res; >>> + >>> +#define NT0_RES_RESPONSE_CODE 1; >>> +#define NT0_RES_NT_DEFAULT    0; >>> +#define NT0_RES_RS_AP_CHANGE  5; >>> +#define NT0_RES_CC_AP_CHANGE  3; >>> + >>> +int ap_chsc_sei_nt0_get_event(void *res); >> >> Documentation would be nice to have since a "return 1" means failure. > > True. > Since I want to keep the return as is, will this documentation suffice? /** * ap_chsc_sei_nt0_get_event - Retrieve the next pending AP config * change event * @res:Pointer to a ChscSeiNt0Res struct to be filled with event * data * * This function checks for any pending AP config change events and, * if present, populates the provided response structure with the * appropriate SEI NT0 fields. * * Return: * 0 - An event was available and written to @res * 1 - No event was available */ >> >>> + >>> +int ap_chsc_sei_nt0_have_event(void); >>> +>   #endif >> >> >> Thanks, >> >> C. >> >> > --------------tZG990njYq6xxF8NDTFCO6Ci Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 5/22/25 3:02 PM, Anthony Krowiak wrote:



On 5/22/25 9:35 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.

Signed-off-by: Rorie Reyes <rreyes@linux.ibm.com>
---
  hw/vfio/ap.c                 | 39 ++++++++++++++++++++++++++++++++++++
  include/hw/s390x/ap-bridge.h | 22 ++++++++++++++++++++
  2 files changed, 61 insertions(+)

diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 5ea5dd9cca..4f88f80c54 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -96,6 +96,45 @@ static void vfio_ap_cfg_chg_notifier_handler(void *opaque)
    }
  +int ap_chsc_sei_nt0_get_event(void *res)
+{
+    ChscSeiNt0Res *nt0_res  = (ChscSeiNt0Res *)res;
+    APConfigChgEvent *cfg_chg_event;
+
+    if (!ap_chsc_sei_nt0_have_event()) {
+        return 1;
+    }
+
+    cfg_chg_event = QTAILQ_FIRST(&cfg_chg_events);
+    memset(nt0_res, 0, sizeof(*nt0_res));
+
+    QTAILQ_REMOVE(&cfg_chg_events, cfg_chg_event, next);
+    g_free(cfg_chg_event);
+
+    /*
+     * If there are any AP configuration change events in the queue,
+     * indicate to the caller that there is pending event info in
+     * the response block
+     */
+    if (ap_chsc_sei_nt0_have_event()) {
+        nt0_res->flags |= PENDING_EVENT_INFO_BITMASK;
+    }
+
+    nt0_res->length = sizeof(ChscSeiNt0Res);
+    nt0_res->code = NT0_RES_RESPONSE_CODE;
+    nt0_res->nt = NT0_RES_NT_DEFAULT;
+    nt0_res->rs = NT0_RES_RS_AP_CHANGE;
+    nt0_res->cc = NT0_RES_CC_AP_CHANGE;
+
+    return 0;
+

extra white line ^

and returning a bool would make more sense.

It may make more sense from a readability standpoint,
but if you look at the caller (chsc_sei_nt0_get_event in target/s390x/ioinst.c),
it returns an int, so it can simply return whatever is returned from this
function. On the other hand, it really doesn't make a difference, so if
you feel strongly about this, then it can be changed to a bool.


I think I'd rather keep the returns as is because I've went through several changes that uses a bool return and my code doesn't work as designed. The ap config doesn't update in real time which allows the polling time to take over when notifying the guest. Would it suffice to document the following in ap-bridge.h (the comment bellow)

+}
+
+int ap_chsc_sei_nt0_have_event(void)
+{
+    return !QTAILQ_EMPTY(&cfg_chg_events);

same here for the bool.

same as above


+}
+
  static bool vfio_ap_register_irq_notifier(VFIOAPDevice *vapdev,
                                            unsigned int irq, Error **errp)
  {
diff --git a/include/hw/s390x/ap-bridge.h b/include/hw/s390x/ap-bridge.h
index 470e439a98..f4d838bf99 100644
--- a/include/hw/s390x/ap-bridge.h
+++ b/include/hw/s390x/ap-bridge.h
@@ -16,4 +16,26 @@
    void s390_init_ap(void);
  +typedef struct ChscSeiNt0Res {
+    uint16_t length;
+    uint16_t code;
+    uint8_t reserved1;
+    uint16_t reserved2;
+    uint8_t nt;
+#define PENDING_EVENT_INFO_BITMASK 0x80;
+    uint8_t flags;
+    uint8_t reserved3;
+    uint8_t rs;
+    uint8_t cc;
+} QEMU_PACKED ChscSeiNt0Res;
+
+#define NT0_RES_RESPONSE_CODE 1;
+#define NT0_RES_NT_DEFAULT    0;
+#define NT0_RES_RS_AP_CHANGE  5;
+#define NT0_RES_CC_AP_CHANGE  3;
+
+int ap_chsc_sei_nt0_get_event(void *res);

Documentation would be nice to have since a "return 1" means failure.

True.

Since I want to keep the return as is, will this documentation suffice?


/**
* ap_chsc_sei_nt0_get_event - Retrieve the next pending AP config
* change event
* @res: Pointer to a ChscSeiNt0Res struct to be filled with event
* data
*
* This function checks for any pending AP config change events and,
* if present, populates the provided response structure with the
* appropriate SEI NT0 fields.
*
* Return:
* 0 - An event was available and written to @res
* 1 - No event was available
*/


+
+int ap_chsc_sei_nt0_have_event(void);
+>   #endif


Thanks,

C.



--------------tZG990njYq6xxF8NDTFCO6Ci--