From: Oscar Mateo Subject: Re: [PATCH 1/2] drm/i915/cnl: Add support slice/subslice/eu configs Date: Tue, 19 Sep 2017 14:21:30 -0700 Message-ID: References: <20170919210243.16209-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5553F6E183 for ; Tue, 19 Sep 2017 21:21:31 +0000 (UTC) In-Reply-To: <20170919210243.16209-1-rodrigo.vivi@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , intel-gfx@lists.freedesktop.org Cc: Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwOS8xOS8yMDE3IDAyOjAyIFBNLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gRnJvbTogQmVu IFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0Pgo+Cj4gQ2Fubm9ubGFrZSBTbGljZSBhbmQgU3Vi c2xpY2UgaW5mb3JtYXRpb24gaGFzIGNoYW5nZWQuCj4KPiBUaGlzIHBhdGNoIGluaXRpYWxseSBw cm92aWRlZCBieSBCZW4gYWRkcyB0aGUgcHJvcGVyIHNzZXUKPiBpbml0aWFsaXphdGlvbi4KPgo+ IHYyOiBUaGlzIHYyIGRvbmUgYnkgUm9kcmlnbyBpbmNsdWRlczoKPiAgICAgIC0gRml4IG9uIFRv dGFsIHNsaWNlcyBjb3VudCBieSBhdm9pZGluZyBbMV1bMl0gYW5kIFsyXVsyXS4KPiAgICAgIC0g SW5jbHVzaW9uIG9mIEVVIFBlciBTdWJzbGljZS4KPiAgICAgIC0gQ29tbWl0IG1lc3NhZ2UuCj4g djM6IFRoaXMgdjMgZG9uZSBieSBSb2RyaWdvIGluY2x1ZGVzOgo+ICAgICAgLSBIYW5kbGUgYWxs IHBvc3NpYmxlIGJpdHMgYW5kIGV4dHJhIGZ1c2UgcmVnaXN0ZXIuCj4gICAgICAtIFVzZSBJTlRF TF9HRU4gbWFjcm8uCj4gICAgICAtIEZ1bGx5IGFzc3VtZSB1bmlmb3JtIGRpc3RyaWJ1dGlvbiBz byByZW1vdmUgdW5pb24KPiAgICAgICAgd2l0aCBldV9wZXJfc3Vic2xpY2UgYW5kIGFkZCBwcm9w ZXIgdGhlIGNvbW1lbnQuCj4gdjQ6IFRoaXMgdjQgZG9uZSBieSBSb2RyaWdvIGluY2x1ZGVzOgo+ ICAgICAgLSBDb25zaWRlciBhbGwgYml0cyBhdmFpbGFibGU6IDYgYml0cyBmb3Igc2xpY2VzIFsy NzoyMl0KPiAgICAgICAgYW5kIDQgZm9yIHN1YnNsaWNlcyBbMjE6MThdLgo+Cj4gQ2M6IE9zY2Fy IE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogQmVuIFdpZGF3 c2t5IDxiZW5AYndpZGF3c2submV0Pgo+IFNpZ25lZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9k cmlnby52aXZpQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmggICAgICAgICAgfCAgOCArKysrKysrCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kZXZpY2VfaW5mby5jIHwgMzcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KPiAg IDIgZmlsZXMgY2hhbmdlZCwgNDQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggOTRiNDBhNDY5YWZkLi45ZjRiOGZhZjI5ODIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBAQCAtMjczMCw2ICsyNzMwLDExIEBAIGVudW0g aTkxNV9wb3dlcl93ZWxsX2lkIHsKPiAgICNkZWZpbmUgICBHRU45X0YyX1NTX0RJU19TSElGVAkJ MjAKPiAgICNkZWZpbmUgICBHRU45X0YyX1NTX0RJU19NQVNLCQkoMHhmIDw8IEdFTjlfRjJfU1Nf RElTX1NISUZUKQo+ICAgCj4gKyNkZWZpbmUgICBHRU4xMF9GMl9TX0VOQV9TSElGVAkJMjIKPiAr I2RlZmluZSAgIEdFTjEwX0YyX1NfRU5BX01BU0sJCSgweDNmIDw8IEdFTjEwX0YyX1NfRU5BX1NI SUZUKQo+ICsjZGVmaW5lICAgR0VOMTBfRjJfU1NfRElTX1NISUZUCQkxOAo+ICsjZGVmaW5lICAg R0VOMTBfRjJfU1NfRElTX01BU0sJCSgweGYgPDwgR0VOMTBfRjJfU1NfRElTX1NISUZUKQoKSG1t bW0uLi4gSSB0aG91Z2h0IHlvdSB3ZXJlIGdvaW5nIHRvIHJlYWQgbGVzcyByZWdpc3RlcnMgZm9y IHRoZSBFVSAKY291bnQsIGJ1dCB5ZXMsIHRoaXMgYWxzbyB3b3JrcyA6KQoKPiArCj4gICAjZGVm aW5lIEdFTjhfRVVfRElTQUJMRTAJCV9NTUlPKDB4OTEzNCkKPiAgICNkZWZpbmUgICBHRU44X0VV X0RJUzBfUzBfTUFTSwkJMHhmZmZmZmYKPiAgICNkZWZpbmUgICBHRU44X0VVX0RJUzBfUzFfU0hJ RlQJCTI0Cj4gQEAgLTI3NDUsNiArMjc1MCw5IEBAIGVudW0gaTkxNV9wb3dlcl93ZWxsX2lkIHsK PiAgIAo+ICAgI2RlZmluZSBHRU45X0VVX0RJU0FCTEUoc2xpY2UpCQlfTU1JTygweDkxMzQgKyAo c2xpY2UpKjB4NCkKPiAgIAo+ICsjZGVmaW5lIEdFTjEwX0VVX0RJU0FCTEUzCQlfTU1JTygweDkx NDApCj4gKyNkZWZpbmUgICBHRU4xMF9FVV9ESVNfU1NfTUFTSwkJMHhmZgo+ICsKPiAgICNkZWZp bmUgR0VONl9CU0RfU0xFRVBfUFNNSV9DT05UUk9MCV9NTUlPKDB4MTIwNTApCj4gICAjZGVmaW5l ICAgR0VONl9CU0RfU0xFRVBfTVNHX0RJU0FCTEUJKDEgPDwgMCkKPiAgICNkZWZpbmUgICBHRU42 X0JTRF9TTEVFUF9GTFVTSF9ESVNBQkxFCSgxIDw8IDIpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kZXZpY2VfaW5mby5jCj4gaW5kZXggNDM4MzFiMDliNDdhLi44NTY5MzgxMWMxYjAgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYwo+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMKPiBAQCAtODIsNiAr ODIsMzkgQEAgdm9pZCBpbnRlbF9kZXZpY2VfaW5mb19kdW1wKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdikKPiAgICN1bmRlZiBQUklOVF9GTEFHCj4gICB9Cj4gICAKPiArc3RhdGlj IHZvaWQgZ2VuMTBfc3NldV9pbmZvX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ICt7Cj4gKwlzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSA9ICZta3dyaXRlX2Rldmlj ZV9pbmZvKGRldl9wcml2KS0+c3NldTsKPiArCWNvbnN0IHUzMiBmdXNlMiA9IEk5MTVfUkVBRChH RU44X0ZVU0UyKTsKPiArCj4gKwlzc2V1LT5zbGljZV9tYXNrID0gKGZ1c2UyICYgR0VOMTBfRjJf U19FTkFfTUFTSykgPj4KPiArCQkJICAgIEdFTjEwX0YyX1NfRU5BX1NISUZUOwo+ICsJc3NldS0+ c3Vic2xpY2VfbWFzayA9ICgxIDw8IDMpIC0gMTsKCkJ1dCB0aGlzIHNob3VsZCBiZSBub3c6ICgx IDw8IDQpIC0gMSAob3IgbWF5YmUgdXNlIGEgbG9jYWwgc3NfbWF4IGZvciAKY2xhcml0eSwgbGlr ZSBpbiB0aGUgb3RoZXIgcGF0Y2gpCgo+ICsJc3NldS0+c3Vic2xpY2VfbWFzayAmPSB+KChmdXNl MiAmIEdFTjEwX0YyX1NTX0RJU19NQVNLKSA+Pgo+ICsJCQkJIEdFTjEwX0YyX1NTX0RJU19TSElG VCk7Cj4gKwo+ICsJc3NldS0+ZXVfdG90YWwgPSBod2VpZ2h0MzIofkk5MTVfUkVBRChHRU44X0VV X0RJU0FCTEUwKSk7Cj4gKwlzc2V1LT5ldV90b3RhbCArPSBod2VpZ2h0MzIofkk5MTVfUkVBRChH RU44X0VVX0RJU0FCTEUxKSk7Cj4gKwlzc2V1LT5ldV90b3RhbCArPSBod2VpZ2h0MzIofkk5MTVf UkVBRChHRU44X0VVX0RJU0FCTEUyKSk7Cj4gKwlzc2V1LT5ldV90b3RhbCArPSBod2VpZ2h0OCh+ KEk5MTVfUkVBRChHRU4xMF9FVV9ESVNBQkxFMykgJgo+ICsJCQkJICAgICBHRU4xMF9FVV9ESVNf U1NfTUFTSykpOwo+ICsKPiArCS8qCj4gKwkgKiBDTkwgaXMgZXhwZWN0ZWQgdG8gYWx3YXlzIGhh dmUgYSB1bmlmb3JtIGRpc3RyaWJ1dGlvbgo+ICsJICogb2YgRVUgYWNyb3NzIHN1YnNsaWNlcyB3 aXRoIHRoZSBleGNlcHRpb24gdGhhdCBhbnkgb25lCj4gKwkgKiBFVSBpbiBhbnkgb25lIHN1YnNs aWNlIG1heSBiZSBmdXNlZCBvZmYgZm9yIGRpZQo+ICsJICogcmVjb3ZlcnkuCj4gKwkgKi8KPiAr CXNzZXUtPmV1X3Blcl9zdWJzbGljZSA9IHNzZXVfc3Vic2xpY2VfdG90YWwoc3NldSkgPwo+ICsJ CQkJRElWX1JPVU5EX1VQKHNzZXUtPmV1X3RvdGFsLAo+ICsJCQkJCSAgICAgc3NldV9zdWJzbGlj ZV90b3RhbChzc2V1KSkgOiAwOwo+ICsKPiArCS8qIE5vIHJlc3RyaWN0aW9ucyBvbiBQb3dlciBH YXRpbmcgKi8KPiArCXNzZXUtPmhhc19zbGljZV9wZyA9IDE7Cj4gKwlzc2V1LT5oYXNfc3Vic2xp Y2VfcGcgPSAxOwo+ICsJc3NldS0+aGFzX2V1X3BnID0gMTsKPiArfQo+ICsKPiAgIHN0YXRpYyB2 b2lkIGNoZXJyeXZpZXdfc3NldV9pbmZvX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICAgewo+ICAgCXN0cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1ID0gJm1rd3JpdGVf ZGV2aWNlX2luZm8oZGV2X3ByaXYpLT5zc2V1Owo+IEBAIC00MDksOCArNDQyLDEwIEBAIHZvaWQg aW50ZWxfZGV2aWNlX2luZm9fcnVudGltZV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAgIAkJY2hlcnJ5dmlld19zc2V1X2luZm9faW5pdChkZXZfcHJpdik7Cj4gICAJ ZWxzZSBpZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSkKPiAgIAkJYnJvYWR3ZWxsX3NzZXVfaW5m b19pbml0KGRldl9wcml2KTsKPiAtCWVsc2UgaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5nZW4g Pj0gOSkKPiArCWVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPT0gOSkKPiAgIAkJZ2VuOV9z c2V1X2luZm9faW5pdChkZXZfcHJpdik7Cj4gKwllbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYp ID49IDEwKQo+ICsJCWdlbjEwX3NzZXVfaW5mb19pbml0KGRldl9wcml2KTsKPiAgIAo+ICAgCURS TV9ERUJVR19EUklWRVIoInNsaWNlIG1hc2s6ICUwNHhcbiIsIGluZm8tPnNzZXUuc2xpY2VfbWFz ayk7Cj4gICAJRFJNX0RFQlVHX0RSSVZFUigic2xpY2UgdG90YWw6ICV1XG4iLCBod2VpZ2h0OChp bmZvLT5zc2V1LnNsaWNlX21hc2spKTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=