Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id EAA0B4207D7 for ; Fri, 20 Nov 2020 08:59:38 +0100 (CET) To: Christoph Hellwig , Jens Axboe References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-73-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Fri, 20 Nov 2020 08:59:37 +0100 MIME-Version: 1.0 In-Reply-To: <20201116145809.410558-73-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, linux-block@vger.kernel.org, "Martin K. Petersen" , Minchan Kim , linux-fsdevel@vger.kernel.org, Paolo Bonzini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Subject: Re: [Drbd-dev] [PATCH 72/78] block: use disk_part_iter_exit in disk_part_iter_next List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 11/16/20 3:58 PM, Christoph Hellwig wrote: > Call disk_part_iter_exit in disk_part_iter_next instead of duplicating > the functionality. > > Signed-off-by: Christoph Hellwig > --- > block/genhd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/genhd.c b/block/genhd.c > index 999f7142b04e7d..56bc37e98ed852 100644 > --- a/block/genhd.c > +++ b/block/genhd.c > @@ -230,8 +230,7 @@ struct hd_struct *disk_part_iter_next(struct disk_part_iter *piter) > int inc, end; > > /* put the last partition */ > - disk_put_part(piter->part); > - piter->part = NULL; > + disk_part_iter_exit(piter); > > /* get part_tbl */ > rcu_read_lock(); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer