From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 2/3] drm/amdkfd: avoid HMM change cause circular lock dependency v2 Date: Tue, 5 Feb 2019 12:42:51 +0100 Message-ID: References: <20190204182237.2641-1-Philip.Yang@amd.com> <20190204182237.2641-3-Philip.Yang@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190204182237.2641-3-Philip.Yang-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Yang, Philip" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMDQuMDIuMTkgdW0gMTk6MjMgc2NocmllYiBZYW5nLCBQaGlsaXA6Cj4gVGhlcmUgaXMgY2ly Y3VsYXIgbG9jayBiZXR3ZWVuIGdmeCBhbmQga2ZkIHBhdGggd2l0aCBITU0gY2hhbmdlOgo+IGxv Y2soZHFtKSAtPiBibzo6cmVzZXJ2ZSAtPiBhbWRncHVfbW5fbG9jawo+Cj4gVG8gYXZvaWQgdGhp cywgbW92ZSBpbml0L3VuaW50X21xZCgpIG91dCBvZiBsb2NrKGRxbSksIHRvIHJlbW92ZSBuZXN0 ZWQKPiBsb2NraW5nIGJldHdlZW4gbW1hcF9zZW0gYW5kIGJvOjpyZXNlcnZlLiBUaGUgbG9ja2lu ZyBvcmRlcgo+IGlzOiBibzo6cmVzZXJ2ZSAtPiBhbWRncHVfbW5fbG9jayhwLT5tbikKCkluIGdl bmVyYWwgdGhpcyBzb3VuZHMgY29ycmVjdCB0byBtZSwgYnV0IGFwYXJ0IGZyb20gdGhhdCBJIGRv bid0IGtub3cgCnRoZSBjb2RlIHdlbGwgZW5vdWdoIHRvIGZ1bGx5IGp1ZGdlLgoKPgo+IENoYW5n ZS1JZDogSTJlYzA5YTQ3NTcxZjZiNGM4ZWFlZjkzZjIyYzBhNjAwZjVmNzAxNTMKPiBTaWduZWQt b2ZmLWJ5OiBQaGlsaXAgWWFuZyA8UGhpbGlwLllhbmdAYW1kLmNvbT4KCkFja2VkLWJ5OiBDaHJp c3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cgo+IC0tLQo+ICAgLi4uL2Ry bS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVldWVfbWFuYWdlci5jIHwgMzIgKysrKysrKysrKy0t LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZp Y2VfcXVldWVfbWFuYWdlci5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRrZmQva2ZkX2Rldmlj ZV9xdWV1ZV9tYW5hZ2VyLmMKPiBpbmRleCA4MzcyNTU2YjUyZWIuLmVmZTBkM2MwMjE1YiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGtmZC9rZmRfZGV2aWNlX3F1ZXVlX21h bmFnZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1ka2ZkL2tmZF9kZXZpY2VfcXVl dWVfbWFuYWdlci5jCj4gQEAgLTExNTYsMjEgKzExNTYsMTcgQEAgc3RhdGljIGludCBjcmVhdGVf cXVldWVfY3BzY2goc3RydWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIHN0cnVjdCBxdWV1 ZSAqcSwKPiAgIAlpbnQgcmV0dmFsOwo+ICAgCXN0cnVjdCBtcWRfbWFuYWdlciAqbXFkX21ncjsK PiAgIAo+IC0JcmV0dmFsID0gMDsKPiAtCj4gLQlkcW1fbG9jayhkcW0pOwo+IC0KPiAgIAlpZiAo ZHFtLT50b3RhbF9xdWV1ZV9jb3VudCA+PSBtYXhfbnVtX29mX3F1ZXVlc19wZXJfZGV2aWNlKSB7 Cj4gICAJCXByX3dhcm4oIkNhbid0IGNyZWF0ZSBuZXcgdXNlcm1vZGUgcXVldWUgYmVjYXVzZSAl ZCBxdWV1ZXMgd2VyZSBhbHJlYWR5IGNyZWF0ZWRcbiIsCj4gICAJCQkJZHFtLT50b3RhbF9xdWV1 ZV9jb3VudCk7Cj4gICAJCXJldHZhbCA9IC1FUEVSTTsKPiAtCQlnb3RvIG91dF91bmxvY2s7Cj4g KwkJZ290byBvdXQ7Cj4gICAJfQo+ICAgCj4gICAJaWYgKHEtPnByb3BlcnRpZXMudHlwZSA9PSBL RkRfUVVFVUVfVFlQRV9TRE1BKSB7Cj4gICAJCXJldHZhbCA9IGFsbG9jYXRlX3NkbWFfcXVldWUo ZHFtLCAmcS0+c2RtYV9pZCk7Cj4gICAJCWlmIChyZXR2YWwpCj4gLQkJCWdvdG8gb3V0X3VubG9j azsKPiArCQkJZ290byBvdXQ7Cj4gICAJCXEtPnByb3BlcnRpZXMuc2RtYV9xdWV1ZV9pZCA9Cj4g ICAJCQlxLT5zZG1hX2lkIC8gZ2V0X251bV9zZG1hX2VuZ2luZXMoZHFtKTsKPiAgIAkJcS0+cHJv cGVydGllcy5zZG1hX2VuZ2luZV9pZCA9Cj4gQEAgLTExODEsNiArMTE3Nyw5IEBAIHN0YXRpYyBp bnQgY3JlYXRlX3F1ZXVlX2Nwc2NoKHN0cnVjdCBkZXZpY2VfcXVldWVfbWFuYWdlciAqZHFtLCBz dHJ1Y3QgcXVldWUgKnEsCj4gICAJaWYgKHJldHZhbCkKPiAgIAkJZ290byBvdXRfZGVhbGxvY2F0 ZV9zZG1hX3F1ZXVlOwo+ICAgCj4gKwkvKiBEbyBpbml0X21xZCBiZWZvcmUgZHFtX2xvY2soZHFt KSB0byBhdm9pZCBjaXJjdWxhciBsb2NraW5nIG9yZGVyOgo+ICsJICogbG9jayhkcW0pIC0+IGJv OjpyZXNlcnZlCj4gKwkgKi8KPiAgIAltcWRfbWdyID0gZHFtLT5vcHMuZ2V0X21xZF9tYW5hZ2Vy KGRxbSwKPiAgIAkJCWdldF9tcWRfdHlwZV9mcm9tX3F1ZXVlX3R5cGUocS0+cHJvcGVydGllcy50 eXBlKSk7Cj4gICAKPiBAQCAtMTE4OCw2ICsxMTg3LDcgQEAgc3RhdGljIGludCBjcmVhdGVfcXVl dWVfY3BzY2goc3RydWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIHN0cnVjdCBxdWV1ZSAq cSwKPiAgIAkJcmV0dmFsID0gLUVOT01FTTsKPiAgIAkJZ290byBvdXRfZGVhbGxvY2F0ZV9kb29y YmVsbDsKPiAgIAl9Cj4gKwo+ICAgCS8qCj4gICAJICogRXZpY3Rpb24gc3RhdGUgbG9naWM6IHdl IG9ubHkgbWFyayBhY3RpdmUgcXVldWVzIGFzIGV2aWN0ZWQKPiAgIAkgKiB0byBhdm9pZCB0aGUg b3ZlcmhlYWQgb2YgcmVzdG9yaW5nIGluYWN0aXZlIHF1ZXVlcyBsYXRlcgo+IEBAIC0xMTk2LDkg KzExOTYsNyBAQCBzdGF0aWMgaW50IGNyZWF0ZV9xdWV1ZV9jcHNjaChzdHJ1Y3QgZGV2aWNlX3F1 ZXVlX21hbmFnZXIgKmRxbSwgc3RydWN0IHF1ZXVlICpxLAo+ICAgCQlxLT5wcm9wZXJ0aWVzLmlz X2V2aWN0ZWQgPSAocS0+cHJvcGVydGllcy5xdWV1ZV9zaXplID4gMCAmJgo+ICAgCQkJCQkgICAg cS0+cHJvcGVydGllcy5xdWV1ZV9wZXJjZW50ID4gMCAmJgo+ICAgCQkJCQkgICAgcS0+cHJvcGVy dGllcy5xdWV1ZV9hZGRyZXNzICE9IDApOwo+IC0KPiAgIAlkcW0tPmFzaWNfb3BzLmluaXRfc2Rt YV92bShkcW0sIHEsIHFwZCk7Cj4gLQo+ICAgCXEtPnByb3BlcnRpZXMudGJhX2FkZHIgPSBxcGQt PnRiYV9hZGRyOwo+ICAgCXEtPnByb3BlcnRpZXMudG1hX2FkZHIgPSBxcGQtPnRtYV9hZGRyOwo+ ICAgCXJldHZhbCA9IG1xZF9tZ3ItPmluaXRfbXFkKG1xZF9tZ3IsICZxLT5tcWQsICZxLT5tcWRf bWVtX29iaiwKPiBAQCAtMTIwNiw2ICsxMjA0LDggQEAgc3RhdGljIGludCBjcmVhdGVfcXVldWVf Y3BzY2goc3RydWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIHN0cnVjdCBxdWV1ZSAqcSwK PiAgIAlpZiAocmV0dmFsKQo+ICAgCQlnb3RvIG91dF9kZWFsbG9jYXRlX2Rvb3JiZWxsOwo+ICAg Cj4gKwlkcW1fbG9jayhkcW0pOwo+ICsKPiAgIAlsaXN0X2FkZCgmcS0+bGlzdCwgJnFwZC0+cXVl dWVzX2xpc3QpOwo+ICAgCXFwZC0+cXVldWVfY291bnQrKzsKPiAgIAlpZiAocS0+cHJvcGVydGll cy5pc19hY3RpdmUpIHsKPiBAQCAtMTIzMyw5ICsxMjMzLDcgQEAgc3RhdGljIGludCBjcmVhdGVf cXVldWVfY3BzY2goc3RydWN0IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sIHN0cnVjdCBxdWV1 ZSAqcSwKPiAgIG91dF9kZWFsbG9jYXRlX3NkbWFfcXVldWU6Cj4gICAJaWYgKHEtPnByb3BlcnRp ZXMudHlwZSA9PSBLRkRfUVVFVUVfVFlQRV9TRE1BKQo+ICAgCQlkZWFsbG9jYXRlX3NkbWFfcXVl dWUoZHFtLCBxLT5zZG1hX2lkKTsKPiAtb3V0X3VubG9jazoKPiAtCWRxbV91bmxvY2soZHFtKTsK PiAtCj4gK291dDoKPiAgIAlyZXR1cm4gcmV0dmFsOwo+ICAgfQo+ICAgCj4gQEAgLTEzOTgsOCAr MTM5Niw2IEBAIHN0YXRpYyBpbnQgZGVzdHJveV9xdWV1ZV9jcHNjaChzdHJ1Y3QgZGV2aWNlX3F1 ZXVlX21hbmFnZXIgKmRxbSwKPiAgIAkJCXFwZC0+cmVzZXRfd2F2ZWZyb250cyA9IHRydWU7Cj4g ICAJfQo+ICAgCj4gLQltcWRfbWdyLT51bmluaXRfbXFkKG1xZF9tZ3IsIHEtPm1xZCwgcS0+bXFk X21lbV9vYmopOwo+IC0KPiAgIAkvKgo+ICAgCSAqIFVuY29uZGl0aW9uYWxseSBkZWNyZW1lbnQg dGhpcyBjb3VudGVyLCByZWdhcmRsZXNzIG9mIHRoZSBxdWV1ZSdzCj4gICAJICogdHlwZQo+IEBA IC0xNDEwLDYgKzE0MDYsOSBAQCBzdGF0aWMgaW50IGRlc3Ryb3lfcXVldWVfY3BzY2goc3RydWN0 IGRldmljZV9xdWV1ZV9tYW5hZ2VyICpkcW0sCj4gICAKPiAgIAlkcW1fdW5sb2NrKGRxbSk7Cj4g ICAKPiArCS8qIERvIHVuaW5pdF9tcWQgYWZ0ZXIgZHFtX3VubG9jayhkcW0pIHRvIGF2b2lkIGNp cmN1bGFyIGxvY2tpbmcgKi8KPiArCW1xZF9tZ3ItPnVuaW5pdF9tcWQobXFkX21nciwgcS0+bXFk LCBxLT5tcWRfbWVtX29iaik7Cj4gKwo+ICAgCXJldHVybiByZXR2YWw7Cj4gICAKPiAgIGZhaWxl ZDoKPiBAQCAtMTYzMSw3ICsxNjMwLDExIEBAIHN0YXRpYyBpbnQgcHJvY2Vzc190ZXJtaW5hdGlv bl9jcHNjaChzdHJ1Y3QgZGV2aWNlX3F1ZXVlX21hbmFnZXIgKmRxbSwKPiAgIAkJcXBkLT5yZXNl dF93YXZlZnJvbnRzID0gZmFsc2U7Cj4gICAJfQo+ICAgCj4gLQkvKiBsYXN0bHksIGZyZWUgbXFk IHJlc291cmNlcyAqLwo+ICsJZHFtX3VubG9jayhkcW0pOwo+ICsKPiArCS8qIExhc3RseSwgZnJl ZSBtcWQgcmVzb3VyY2VzLgo+ICsJICogRG8gdW5pbml0X21xZCgpIGFmdGVyIGRxbV91bmxvY2sg dG8gYXZvaWQgY2lyY3VsYXIgbG9ja2luZy4KPiArCSAqLwo+ICAgCWxpc3RfZm9yX2VhY2hfZW50 cnlfc2FmZShxLCBuZXh0LCAmcXBkLT5xdWV1ZXNfbGlzdCwgbGlzdCkgewo+ICAgCQltcWRfbWdy ID0gZHFtLT5vcHMuZ2V0X21xZF9tYW5hZ2VyKGRxbSwKPiAgIAkJCWdldF9tcWRfdHlwZV9mcm9t X3F1ZXVlX3R5cGUocS0+cHJvcGVydGllcy50eXBlKSk7Cj4gQEAgLTE2NDUsNyArMTY0OCw2IEBA IHN0YXRpYyBpbnQgcHJvY2Vzc190ZXJtaW5hdGlvbl9jcHNjaChzdHJ1Y3QgZGV2aWNlX3F1ZXVl X21hbmFnZXIgKmRxbSwKPiAgIAl9Cj4gICAKPiAgIG91dDoKPiAtCWRxbV91bmxvY2soZHFtKTsK PiAgIAlyZXR1cm4gcmV0dmFsOwo+ICAgfQo+ICAgCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2FtZC1nZngK