From: "mrbff (Code Review)" Date: Thu, 28 Nov 2024 15:57:36 +0000 In-Reply-To: References: Reply-To: marco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tUuep63wA3M="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , stipa , plaisthos , openvpn-devel --tUuep63wA3M= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 5: (2 comments) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/808/comment/d57bba5b_c9eabd40 : PS4, Line 817: src/openvpn/platform.c > buffer.c and platform.c are always added by foreach loop above. So they a= re redundant here. Done File src/openvpn/options.h: http://gerrit.openvpn.net/c/openvpn/+/808/comment/17c2f5d7_5fb82784 : PS4, Line 791: #define PUF_TYPE_UNDEF 0 /** undefined filter type */ > You didn't resolve the conflict correctly when rebasing. Please copy the = new code here. you are right, sorry! -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 5 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: stipa Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Thu, 28 Nov 2024 15:57:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --tUuep63wA3M= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, stipa. <= /p>

View C= hange

2 comments:

    =
  • File CMakeLists.txt:

    • Patch Set #4, Line 817: src/openvpn/platform.c

      buffer.c and platform.c are always added by foreach loo= p above. So they are redundant here.

      Done

  • File src/openvpn/options.h:

    • Patch Set #4, Line 791: #define PUF_TYPE_UNDEF 0 /** undef= ined filter type */

      You didn't resolve the confli= ct correctly when rebasing. Please copy the new code here.

      =

      you are right, s= orry!

To view, visit change 808. To unsubscribe, or fo= r help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 5
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: stipa <lstipakov@...277...> <= /div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Thu, 28 Nov 2024 15:57:36= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--tUuep63wA3M=--