Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2ED91D4A60A for ; Fri, 16 Jan 2026 07:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yu0jn8jm2n1dkDHVZT2M5vZAAWPa36+CBjxCNEHcarQ=; b=J/CwR2Wpt2ebKtFPy+++amowPS ge8mcwYevGxyHV5uIviR64U9k5cJipDIgLSqku+qRxhkuY77HKwIPYOz7jWpZUDbnPiHHhFP4R+3F C9DY5g15eF0XlAcRwAcGWS/MVg7wPtC8t3AqNQO+qHbDkN0kV9SZBT43DeP5yIWH64jx/cMX8368c Ti1AUm8R7K4l4IFMbrBcMYTPheWGFq+ehMDGUpJvt0mLXLD9mWvE/uEvkua7rQVLsQnYuUvqO9eLG rYiDA4LxArDWOzuJeHQEDYz9dE/+010AmNkWolzT0Ve+xaAzq6B3KDj/9MEvyrBxonEYzvuIhpPUJ 3PDiTaIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vgeTa-0000000Dhtn-2bck; Fri, 16 Jan 2026 07:42:34 +0000 Received: from smtpout-04.galae.net ([185.171.202.116]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vgeTV-0000000DhtP-2SeC for linux-arm-kernel@lists.infradead.org; Fri, 16 Jan 2026 07:42:34 +0000 Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 8F44DC1F1F5; Fri, 16 Jan 2026 07:41:59 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 3BFAA60732; Fri, 16 Jan 2026 07:42:26 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3447610B682A5; Fri, 16 Jan 2026 08:42:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768549345; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=yu0jn8jm2n1dkDHVZT2M5vZAAWPa36+CBjxCNEHcarQ=; b=vj1GLVy4mLMrVpEO5LpZbGlurcpuETR5klnfjVo+8fv/PjmgKPiXfjNUNxcn7nIpwwXmV5 i3Ns43oQtBAphJKcvvkbmCKRQIdJby4QyhiTQ6xzBDysgft/nDLQaO24ofhZoH+HFpk1TN VzK3u8D62QnWMvD7slJev5FpqOu9oueArL39PBNgDf4UcoOY0SNi/oJnx2XsT2wunUdap8 Bo3dahe/gopBzNTzHixtjt3t+539bTS7uiJu0bt848VAQBWT8OZ68DC3+XKcYVr2eJsb0/ L6pFWlt/ecYPkEP0+iKG4OTiuWpxKBsD0ruaNwZmuZwQPfcWVjSrNYqAQqUZ0A== Message-ID: Date: Fri, 16 Jan 2026 08:42:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: stmmac: fix dwmac4 transmit performance regression To: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit Cc: Alexandre Torgue , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni References: From: Maxime Chevallier Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260115_234229_777923_5B5E622C X-CRM114-Status: GOOD ( 24.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On 16/01/2026 01:49, Russell King (Oracle) wrote: > dwmac4's transmit performance dropped by a factor of four due to an > incorrect assumption about which definitions are for what. This > highlights the need for sane register macros. > > Commit 8409495bf6c9 ("net: stmmac: cores: remove many xxx_SHIFT > definitions") changed the way the txpbl value is merged into the > register: > > value = readl(ioaddr + DMA_CHAN_TX_CONTROL(dwmac4_addrs, chan)); > - value = value | (txpbl << DMA_BUS_MODE_PBL_SHIFT); > + value = value | FIELD_PREP(DMA_BUS_MODE_PBL, txpbl); > > With the following in the header file: > > #define DMA_BUS_MODE_PBL BIT(16) > -#define DMA_BUS_MODE_PBL_SHIFT 16 > > The assumption here was that DMA_BUS_MODE_PBL was the mask for > DMA_BUS_MODE_PBL_SHIFT, but this turns out not to be the case. > > The field is actually six bits wide, buts 21:16, and is called > TXPBL. > > What's even more confusing is, there turns out to be a PBLX8 > single bit in the DMA_CHAN_CONTROL register (0x1100 for channel 0), > and DMA_BUS_MODE_PBL seems to be used for that. However, this bit > et.al. was listed under a comment "/* DMA SYS Bus Mode bitmap */" > which is for register 0x1004. > > Fix this up by adding an appropriately named field definition under > the DMA_CHAN_TX_CONTROL() register address definition. > > Move the RPBL mask definition under DMA_CHAN_RX_CONTROL(), correctly > renaming it as well. > > Also move the PBL bit definition under DMA_CHAN_CONTROL(), correctly > renaming it. > > This removes confusion over the PBL fields. > > Signed-off-by: Russell King (Oracle) Good job finding the problem ! However you need a Fixes tag, even though ths is is for net-next. It would also have been nice to be in CC, I spent some time on the bisect... Besides that, problem solved on an imx8mp setup :) Tested-by: Maxime Chevallier Reviewed-by: Maxime Chevallier Maxime > --- > drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c | 8 ++++---- > drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 7 ++++--- > 2 files changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c > index 7036beccfc85..aaa83e9ff4f0 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c > @@ -52,7 +52,7 @@ static void dwmac4_dma_init_rx_chan(struct stmmac_priv *priv, > u32 rxpbl = dma_cfg->rxpbl ?: dma_cfg->pbl; > > value = readl(ioaddr + DMA_CHAN_RX_CONTROL(dwmac4_addrs, chan)); > - value = value | FIELD_PREP(DMA_BUS_MODE_RPBL_MASK, rxpbl); > + value = value | FIELD_PREP(DMA_CHAN_RX_CTRL_RXPBL_MASK, rxpbl); > writel(value, ioaddr + DMA_CHAN_RX_CONTROL(dwmac4_addrs, chan)); > > if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT) && likely(dma_cfg->eame)) > @@ -73,7 +73,7 @@ static void dwmac4_dma_init_tx_chan(struct stmmac_priv *priv, > u32 txpbl = dma_cfg->txpbl ?: dma_cfg->pbl; > > value = readl(ioaddr + DMA_CHAN_TX_CONTROL(dwmac4_addrs, chan)); > - value = value | FIELD_PREP(DMA_BUS_MODE_PBL, txpbl); > + value = value | FIELD_PREP(DMA_CHAN_TX_CTRL_TXPBL_MASK, txpbl); > > /* Enable OSP to get best performance */ > value |= DMA_CONTROL_OSP; > @@ -98,7 +98,7 @@ static void dwmac4_dma_init_channel(struct stmmac_priv *priv, > /* common channel control register config */ > value = readl(ioaddr + DMA_CHAN_CONTROL(dwmac4_addrs, chan)); > if (dma_cfg->pblx8) > - value = value | DMA_BUS_MODE_PBL; > + value = value | DMA_CHAN_CTRL_PBLX8; > writel(value, ioaddr + DMA_CHAN_CONTROL(dwmac4_addrs, chan)); > > /* Mask interrupts by writing to CSR7 */ > @@ -116,7 +116,7 @@ static void dwmac410_dma_init_channel(struct stmmac_priv *priv, > /* common channel control register config */ > value = readl(ioaddr + DMA_CHAN_CONTROL(dwmac4_addrs, chan)); > if (dma_cfg->pblx8) > - value = value | DMA_BUS_MODE_PBL; > + value = value | DMA_CHAN_CTRL_PBLX8; > > writel(value, ioaddr + DMA_CHAN_CONTROL(dwmac4_addrs, chan)); > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > index 5f1e2916f099..9d9077a4ac9f 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h > @@ -24,8 +24,6 @@ > > #define DMA_SYS_BUS_MODE 0x00001004 > > -#define DMA_BUS_MODE_PBL BIT(16) > -#define DMA_BUS_MODE_RPBL_MASK GENMASK(21, 16) > #define DMA_BUS_MODE_MB BIT(14) > #define DMA_BUS_MODE_FB BIT(0) > > @@ -68,19 +66,22 @@ static inline u32 dma_chanx_base_addr(const struct dwmac4_addrs *addrs, > > #define DMA_CHAN_CONTROL(addrs, x) dma_chanx_base_addr(addrs, x) > > +#define DMA_CHAN_CTRL_PBLX8 BIT(16) > #define DMA_CONTROL_SPH BIT(24) > > #define DMA_CHAN_TX_CONTROL(addrs, x) (dma_chanx_base_addr(addrs, x) + 0x4) > > #define DMA_CONTROL_EDSE BIT(28) > +#define DMA_CHAN_TX_CTRL_TXPBL_MASK GENMASK(21, 16) > #define DMA_CONTROL_TSE BIT(12) > #define DMA_CONTROL_OSP BIT(4) > #define DMA_CONTROL_ST BIT(0) > > #define DMA_CHAN_RX_CONTROL(addrs, x) (dma_chanx_base_addr(addrs, x) + 0x8) > > -#define DMA_CONTROL_SR BIT(0) > +#define DMA_CHAN_RX_CTRL_RXPBL_MASK GENMASK(21, 16) > #define DMA_RBSZ_MASK GENMASK(14, 1) > +#define DMA_CONTROL_SR BIT(0) > > #define DMA_CHAN_TX_BASE_ADDR_HI(addrs, x) (dma_chanx_base_addr(addrs, x) + 0x10) > #define DMA_CHAN_TX_BASE_ADDR(addrs, x) (dma_chanx_base_addr(addrs, x) + 0x14)