From: "flichtenheld (Code Review)"
Date: Mon, 22 Apr 2024 11:46:20 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, reynir@...2756...
Message-ID:
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="ceCjRPcfAiU="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Only
schedule_exit() once
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: reynir
Cc: plaisthos , openvpn-devel
--ceCjRPcfAiU=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, reynir.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/555?usp=3Demail )
Change subject: Only schedule_exit() once
......................................................................
Patch Set 1:
(2 comments)
File src/openvpn/forward.c:
http://gerrit.openvpn.net/c/openvpn/+/555/comment/832e9f3f_055cb4bc :
PS1, Line 525: return;
You might want to consider changing the function to return a boolean to ind=
icate whether it did anything. `send_auth_failure` already does the same ch=
eck and could just use this one instead. And the other callers might also b=
enefit from not doing other actions if exit is already scheduled.
http://gerrit.openvpn.net/c/openvpn/+/555/comment/73f172e8_be13b424 :
PS1, Line 530: event_timeout_init(&c->c2.scheduled_exit, n_seconds, now=
);
> I have only now thought of it: what if the new `n_seconds` is sooner than=
the already scheduled exit [=E2=80=A6]
It is always `c->options.scheduled_exit_interval` which is always 5 at the =
moment.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/555?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9dc4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 1
Gerrit-Owner: reynir
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-Reviewer: reynir
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: reynir
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: reynir
Gerrit-MessageType: comment
--ceCjRPcfAiU=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos, reynir.
View C=
hange
2 comments:
It is always `c->opti=
ons.scheduled_exit_interval` which is always 5 at the moment.
=
To view, visit change 555. To unsubscribe, or for help writing mail=
filters, visit settings=
.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9457f005f4ba970502e6b667d9d=
c4299a588d661
Gerrit-Change-Number: 555
Gerrit-PatchSet: 1
Gerrit-Owner: reynir <reynir@...2756...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-Reviewer: reynir <reynir@...2756...&=
gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: reynir <reynir@...2756...=
>
Gerrit-Comment-Date: Mon, 22 Apr 2024 11:46:20=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: reynir <reynir@...2800...=
...>
Gerrit-MessageType: comment
--ceCjRPcfAiU=--