Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0D5C433E0 for ; Mon, 18 May 2020 16:40:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F44A207D8 for ; Mon, 18 May 2020 16:40:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="hj4/foXp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F44A207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3A2541716; Mon, 18 May 2020 18:39:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3A2541716 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1589820029; bh=3uswkptaJ9f1GsZmaEQSmifHoruEyTDd51+UTrimOQA=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hj4/foXpnusfxAibFU8MS/nW9GN/81XAVcVZ2VN1nbLO9PPmmSdAywEpBNZ1cy12A ayVM5RlyZvG3g9w6ddV7fkGpNE0F3CZHU3lZY3jrIss5baQ+jE7vMv7cETlwajk9LV 3xU+mOlY5ZBQ4c1HH6Xun4DV9Mv0Mf5BYPW+hrpg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 27E93F80274; Mon, 18 May 2020 18:39:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A849BF8028F; Mon, 18 May 2020 18:39:06 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E40ADF8027D for ; Mon, 18 May 2020 18:38:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E40ADF8027D IronPort-SDR: T7gx+UGrkv5oz3IROya4a3vuPtzbASEslQmUHAaqrjGDMmkPye2eTMUcxy1EB1OjuzKI4Zy76x TPndBa83/hJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 09:38:55 -0700 IronPort-SDR: Uca8JzZQYfZr5EHQKa/ie0sQrsASRuLsbacp1WCg4pyOZFxyHLjg7vAyZkYkZjzcIFFHxw03Jo k2cs2fXZPHBg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="465641609" Received: from iremsen-mobl1.amr.corp.intel.com (HELO [10.254.66.150]) ([10.254.66.150]) by fmsmga005.fm.intel.com with ESMTP; 18 May 2020 09:38:54 -0700 Subject: Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for Toshiba Encore WT8-A tablet To: Hans de Goede , Cezary Rojewski , Liam Girdwood , Jie Yang , Mark Brown References: <20200518072416.5348-1-hdegoede@redhat.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 18 May 2020 09:52:52 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200518072416.5348-1-hdegoede@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/18/20 2:24 AM, Hans de Goede wrote: > The Toshiba Encore WT8-A tablet almost fully works with the default > settings for non-CR Bay Trail devices. The only problem is that its > jack-detect switch is not inverted (it is active high instead of > the normal active low). > > Add a quirk for this model using the default settings + > BYT_RT5640_JD_NOT_INV. > > Signed-off-by: Hans de Goede Acked-by: Pierre-Louis Bossart Thanks Hans! > --- > sound/soc/intel/boards/bytcr_rt5640.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c > index 08f4ae964b02..fbfd53874b47 100644 > --- a/sound/soc/intel/boards/bytcr_rt5640.c > +++ b/sound/soc/intel/boards/bytcr_rt5640.c > @@ -742,6 +742,18 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { > BYT_RT5640_SSP0_AIF1 | > BYT_RT5640_MCLK_EN), > }, > + { /* Toshiba Encore WT8-A */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "TOSHIBA"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "TOSHIBA WT8-A"), > + }, > + .driver_data = (void *)(BYT_RT5640_DMIC1_MAP | > + BYT_RT5640_JD_SRC_JD2_IN4N | > + BYT_RT5640_OVCD_TH_2000UA | > + BYT_RT5640_OVCD_SF_0P75 | > + BYT_RT5640_JD_NOT_INV | > + BYT_RT5640_MCLK_EN), > + }, > { /* Catch-all for generic Insyde tablets, must be last */ > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Insyde"), >