Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01EAC4743C for ; Mon, 21 Jun 2021 16:54:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD3006102A for ; Mon, 21 Jun 2021 16:54:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD3006102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 33102829B7; Mon, 21 Jun 2021 18:54:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="s3uD54Tp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E638828A1; Sun, 20 Jun 2021 18:01:33 +0200 (CEST) Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9BCB180563 for ; Sun, 20 Jun 2021 18:01:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=texier.pj2@gmail.com Received: by mail-wr1-x42a.google.com with SMTP id y7so16665646wrh.7 for ; Sun, 20 Jun 2021 09:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dck72eceW+WHYQM81UnhWU2KJxgqX1jeRMuZgbnc0fE=; b=s3uD54Tp0S1VX56/LFOcXM7iGKuzSK2wMrMxULePPA64oAsNdF7UvWvIyhNyP7cZpf FXtpECZjfP/B/u6fznEi/27ByILYBnu8BSmEQJBfMEZH0N15STA4T6ZoN1BYbz2NC68+ Ckj4h+oL52QOkB52muUXWiOLgekR/wpqut/m4hWQAN1TEryOl1vD5KpiX6JACeGyvrae SOiGvd3g6Ki8AcJXwloasxV0ikAnBa9dYRbidVQZQL4RJRWB7DnrSS0HWymAr8M6RhHX 9QKbI3ZwR9qyX2IEmAP2dL/+y9JAogde0kOu2tzzizIb7CVEHWR2jP/ThSXsUL0uKK+u uaEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dck72eceW+WHYQM81UnhWU2KJxgqX1jeRMuZgbnc0fE=; b=ryh1dUBQPH/WvWXjcqEdzxaUzT9MpwVQzKO4RbwzGoo+I1d2NK9SgFwKWSUmTfqpdM 8Oi2cYio4t3CipguaGYjEgDNT/jraZG5b1MsT2EvJwE5A6oM5cPevV3dBS3L6vaEGAwn 5C0GNfN1H2rCWrLodCu2LQXC0AYW2FUqf/8ctauM3ho3lT1AmSqBLxTzu1SGkFajXYCp J7ky1FMS6NnxycFgvsqqFfcg1ql64M4tWuyFsCSPzpwr8ntQPibqk89jUR9W5hvKoKyL tmzKWy5dwUxJKKNCmOnuItBqu9EyJYmeO8dbOJ4LTvwpRKxoyjg2/I3ThPlyMueIzcKE Xg+g== X-Gm-Message-State: AOAM532FuNW+FFB5KsXELNHW8ug8dFAsdpf2PnOe//p4tAaeJ27hjALy cpxwd5oXIhEf99c3n1JRBvI= X-Google-Smtp-Source: ABdhPJwYdvEdM2+QVWg3Ie01KbR3ob8v/ztvqd7f1edoPj6ztYKYIHzcLip4tLsS+CkQJqC5FrqQvA== X-Received: by 2002:adf:f94c:: with SMTP id q12mr23412351wrr.417.1624204890089; Sun, 20 Jun 2021 09:01:30 -0700 (PDT) Received: from ?IPv6:2a01:cb19:190:c500:116b:43c2:a1f1:8b64? ([2a01:cb19:190:c500:116b:43c2:a1f1:8b64]) by smtp.gmail.com with ESMTPSA id j17sm4087353wrx.0.2021.06.20.09.01.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jun 2021 09:01:29 -0700 (PDT) Subject: Re: [PATCH 2/2] usb: ehci-mx6: Do not fail when 'reg' is not found To: Fabio Estevam Cc: marex@denx.de, u-boot@lists.denx.de, sbabic@denx.de, ye.li@nxp.com, peng.fan@nxp.com References: <20210620150052.1628256-1-festevam@denx.de> <20210620150052.1628256-2-festevam@denx.de> From: Pierre-Jean Texier Message-ID: Date: Sun, 20 Jun 2021 18:01:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210620150052.1628256-2-festevam@denx.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 21 Jun 2021 18:53:59 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, Le 20/06/2021 à 17:00, Fabio Estevam a écrit : > Unlike imx6, on imx7 the USB PHY is described as: > > usbphynop1: usbphynop1 { > compatible = "usb-nop-xceiv"; > clocks = <&clks IMX7D_USB_PHY1_CLK>; > clock-names = "main_clk"; > #phy-cells = <0>; > }; > > which does not have the 'reg' property. > > Do not return an error when the 'reg' property is not found > for the USB PHY. > > This fixes USB gadget regression on a imx7s-warp board. > > Successfully tested the "ums 0 mmc 0" command on two boards: > imx7s-warp and imx6dl-pico-pi. > > Signed-off-by: Fabio Estevam Thanks for the fix. Successfully tested on two boards: - imx7s-warp, - imx7d-pico-pi Tested-by: Pierre-Jean Texier > --- > drivers/usb/host/ehci-mx6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-mx6.c b/drivers/usb/host/ehci-mx6.c > index 48b5c8b0c53c..c3e4170513ec 100644 > --- a/drivers/usb/host/ehci-mx6.c > +++ b/drivers/usb/host/ehci-mx6.c > @@ -583,7 +583,7 @@ static int mx6_parse_dt_addrs(struct udevice *dev) > > addr = (void __iomem *)fdtdec_get_addr(blob, phy_off, "reg"); > if ((fdt_addr_t)addr == FDT_ADDR_T_NONE) > - return -EINVAL; > + addr = NULL; > > priv->phy_addr = addr; > > Regards, -- Pierre-Jean Texier