Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B81C433E1 for ; Wed, 19 Aug 2020 13:51:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBE612075E for ; Wed, 19 Aug 2020 13:51:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBE612075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8OV0-0005on-1k for qemu-devel@archiver.kernel.org; Wed, 19 Aug 2020 09:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8OTc-0003zI-Tu for qemu-devel@nongnu.org; Wed, 19 Aug 2020 09:50:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:34540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8OTZ-0003IF-GH for qemu-devel@nongnu.org; Wed, 19 Aug 2020 09:50:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6B3A6B1CC; Wed, 19 Aug 2020 13:50:26 +0000 (UTC) From: Claudio Fontana Subject: Re: [PATCH v5 03/14] cpus: extract out TCG-specific code to accel/tcg To: Richard Henderson , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Roman Bolshakov References: <20200812183250.9221-1-cfontana@suse.de> <20200812183250.9221-4-cfontana@suse.de> <6d14d386-231a-f3b5-8802-167c8979aa03@linaro.org> Message-ID: Date: Wed, 19 Aug 2020 15:49:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <6d14d386-231a-f3b5-8802-167c8979aa03@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/18 22:55:57 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Eduardo Habkost , Marcelo Tosatti , qemu-devel@nongnu.org, Markus Armbruster , Pavel Dovgalyuk , Wenchao Wang , haxm-team@intel.com, Sunil Muthuswamy , Richard Henderson , Colin Xu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/14/20 10:39 PM, Richard Henderson wrote: > On 8/12/20 11:32 AM, Claudio Fontana wrote: >> +static int64_t tcg_get_virtual_clock(void) >> +{ >> + if (icount_enabled()) { >> + return icount_get(); >> + } >> + return cpu_get_clock(); >> +} >> + >> +static int64_t tcg_get_elapsed_ticks(void) >> +{ >> + if (icount_enabled()) { >> + return icount_get(); >> + } >> + return cpu_get_ticks(); >> +} >> + >> +CpusAccel tcg_cpus = { >> + .create_vcpu_thread = tcg_start_vcpu_thread, >> + .kick_vcpu_thread = tcg_kick_vcpu_thread, >> + .get_virtual_clock = tcg_get_virtual_clock, >> + .get_elapsed_ticks = tcg_get_elapsed_ticks, >> +}; > > I think this variable should be const. Which of course means that the previous > patch needs to add const annotations. Will add. > > I think you should actually have multiple dispatch variables: with icount and > without, with mttcg and without. That way these methods don't have to check > icount_enabled() or qemu_tcg_mttcg_enabled() at runtime, only at startup. I gave it a try, it would work, however it is basically a refactoring of the existing qemu_tcg_init_vcpu , I'd do it in a separate series if possible (with some help from Alex?) Claudio > > > r~ >