Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF04B10F994F for ; Wed, 8 Apr 2026 15:14:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 562DD10E3CE; Wed, 8 Apr 2026 15:14:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="IcCoYbsK"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 33D9310E2E7 for ; Wed, 8 Apr 2026 15:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775661269; x=1807197269; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=RA1KpL2iLVujhZTAKojJe1kzMrNwv+3HTs2ncbjl6To=; b=IcCoYbsK3bPXu+AC8lD3eHxwp4XMCvtw/j0+lguH80HuRR5ROOMyYaN+ IAs6BSDR/xQVPSn/pBd+ZXt2U54Mi2MMHSgWQP5azarcqFtqSRFLK4zZT XqeCVz6+lj7cdjaHpHTqopnFtpBEuUd5N0unNW3Ktyn3vYx8SCUW74U+C Zd1S026RSurhl5//vtJBgVYGGmxRmpynkfNi858CNO644CN7e0CE74FtM N6YhF+4gdRXWEjHe55wKyKVZ9Pq/F/lrCKGPSynEo8P+Syy3M4H157N7E FNOmpg3qlsp4ZNO+TYmFwctpgWqnEbq/+mCZWkR8cODRPz1myf3ElfDW2 g==; X-CSE-ConnectionGUID: CDhrz8XtQDqZDt0/WHnZYw== X-CSE-MsgGUID: XMG/kbILQLmOYUjaqYJOow== X-IronPort-AV: E=McAfee;i="6800,10657,11753"; a="88032130" X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="88032130" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:14:28 -0700 X-CSE-ConnectionGUID: LtkzHWiST8iDcw41enEPjA== X-CSE-MsgGUID: LhBNEQTqR4qwLuaimWbiPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,167,1770624000"; d="scan'208";a="233447324" Received: from krybak-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.32]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2026 08:14:26 -0700 From: Jani Nikula To: Maarten Lankhorst , Ville =?utf-8?B?U3ly?= =?utf-8?B?asOkbMOk?= Cc: intel-gfx@lists.freedesktop.org Subject: Re: =?utf-8?Q?=E2=9C=97?= i915.CI.Full: failure for drm/i915/display: stop using the configurable fence timeout (rev2) In-Reply-To: <4d0e3bfe-d3e3-43fb-8964-b9647e914a61@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20251112155612.8320-1-jani.nikula@intel.com> <176310680567.54560.8073003092226406962@10055242dc62> <3692f126b907c442d76a93957073660d7d9ffd12@intel.com> <44f9b69d23678458f0ab3ff4bec5c45cb05535b8@intel.com> <4d0e3bfe-d3e3-43fb-8964-b9647e914a61@intel.com> Date: Wed, 08 Apr 2026 18:14:23 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 02 Apr 2026, Maarten Lankhorst wrote: > Den 2026-04-02 kl. 11:40, skrev Jani Nikula: >> On Wed, 03 Dec 2025, Maarten Lankhorst wro= te: >>> Hey, >>> >>> Den 2025-11-25 kl. 18:24, skrev Ville Syrj=C3=A4l=C3=A4: >>>> On Tue, Nov 25, 2025 at 03:55:02PM +0200, Jani Nikula wrote: >>>>> Maarten, Ville, any ideas what to do about these? >>>> Looks like we need the timeout to unbreak the modeset vs. reset >>>> deadlock in a timely fashion. >>>> >>>> I'm not where we signal/error the fences the modeset is waiting >>>> for, but I guess that must be happening after the whole reset >>>> sequence is done. Doing that earlier would seem like another >>>> solution, but dunno what other fallout it would have. >>> intel_prepare_plane_fb() adds all dma-resv fences for old_obj on >>> intel_crtc_needs_modeset(), does it change anything if we remove that, >>> at least for the GPU reset commit? >> We dropped the ball here a bit, and I'm a bit clueless as to what to >> do. Except we'll need to unify i915 and xe here somehow. >> >> Alternatives: >> >> - Remove the timeout from i915 (the patch at hand), and fix the fallout >> somehow. >> >> - Add the timeout to xe, and fix the fallout, if any. >> >> - Add the timeout to display parent interface, which is a bit meh. >> >> > The mention in the commit is old_obj needs to be wait for flip_done, I do= not believe this > is the case that it was ever used in hardware supported by xe, so for xe = the wait can be dropped entirely. > > Is this required for i915 still? In that case you can just eliminate > the wait only for xe. Trouble is, doing things differently basically means using the parent interface no matter what. BR, Jani. --=20 Jani Nikula, Intel