From: "cron2 (Code Review)" Date: Mon, 19 Jan 2026 17:09:34 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="WELSP14cQZY="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: socket: Avoid conversion warning in get_addr_generic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --WELSP14cQZY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1475?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: socket: Avoid conversion warning in get_addr_generic ...................................................................... socket: Avoid conversion warning in get_addr_generic We already check earlier that bits is smaller that max_bits, so the cast is safe. While reviewing the callers, remove some unused variables. Change-Id: I5ad13bc6674b3403251cc552d1f2c0f057431817 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1475 Message-Id: <20260119122556.15225-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 324.html Signed-off-by: Gert Doering --- M src/openvpn/options.c M src/openvpn/socket.c 2 files changed, 11 insertions(+), 14 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/1475/2 diff --git a/src/openvpn/options.c b/src/openvpn/options.c index cede758..85669e0 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -1144,10 +1144,7 @@ static bool ipv6_addr_safe_hexplusbits(const char *ipv6_prefix_spec) { - struct in6_addr t_addr; - unsigned int t_bits; - - return get_ipv6_addr(ipv6_prefix_spec, &t_addr, &t_bits, M_WARN); + return get_ipv6_addr(ipv6_prefix_spec, NULL, NULL, M_WARN); } static char * diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index 093f822..331249d 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -72,11 +72,6 @@ } } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif - /* * Functions related to the translation of DNS names to IP addresses. */ @@ -180,7 +175,7 @@ if (netbits) { - *netbits =3D bits; + *netbits =3D (unsigned int)bits; } /* restore '/' separator, if any */ @@ -683,6 +678,11 @@ } } +#if defined(__GNUC__) || defined(__clang__) +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wconversion" +#endif + static void create_socket(struct link_socket *sock, struct addrinfo *addr) { @@ -738,6 +738,10 @@ bind_local(sock, addr->ai_family); } +#if defined(__GNUC__) || defined(__clang__) +#pragma GCC diagnostic pop +#endif + #ifdef TARGET_ANDROID static void protect_fd_nonlocal(int fd, const struct sockaddr *addr) @@ -861,10 +865,6 @@ gc_free(&gc); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif - static socket_descriptor_t socket_listen_accept(socket_descriptor_t sd, struct link_socket_actual *ac= t, const struct addrinfo *local, bool do_listen, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1475?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I5ad13bc6674b3403251cc552d1f2c0f057431817 Gerrit-Change-Number: 1475 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --WELSP14cQZY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

socket: Avoid conversion warning in=
 get_addr_generic

We already check earlier that bits is smaller that=
max_bits, so the cast is safe.

While reviewing the callers, remo= ve some unused
variables.

Change-Id: I5ad13bc6674b3403251cc552d1f= 2c0f057431817
Signed-off-by: Frank Lichtenheld <frank@...2641...><= br>Acked-by: Gert Doering <gert@...1296...>
Gerrit URL: https://ge= rrit.openvpn.net/c/openvpn/+/1475
Message-Id: <20260119122556.15225-1= -gert@...1296...>
URL: https://www.mail-archive.com/openvpn-devel@...1484...= ts.sourceforge.net/msg35324.html
Signed-off-by: Gert Doering <gert@...1186...= .1296...>
---
M src/openvpn/options.c
M src/openvpn/socket.c2 files changed, 11 insertions(+), 14 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/75/1475/2<=
/pre>
-    struct in6_addr t_addr;<=
br>-    unsigned int t_bits;
-
- return get_ipv6_addr(ipv6_prefix_spec, &= ;t_addr, &t_bits, M_WARN);
+ return get_ipv6_addr(ipv6_prefix_spec, NULL, NULL, M_WARN);<= /span>
}

static char *<= br>diff --git a/src/openvpn/socket.c b/src/openvpn/socket.cindex 093f822..331249d 100644
--- a/src/openvpn/sock= et.c
+++ b/src/openvpn/socket.c
@@ -72,11 += 72,6 @@
}
}
<= br>-#if defined(__GNUC__) || defi= ned(__clang__)
-#pragma= GCC diagnostic push
-#= pragma GCC diagnostic ignored "-Wconversion"
-#endif
-
/*
* Functions relate= d to the translation of DNS names to IP addresses.
*/
@@ -180,7 +175,7 @@

if = (netbits)
{
- *netbits =3D bits;
+ *netbits =3D (unsigned int)bits;
= }

/* restore '/' separa= tor, if any */
@@ -683,6 +678,11 @@
}<= /span>
}

+#if defined(__GNUC__) || defined(__clang__)
+#pragma GCC diagnostic push
=
+#pragma GCC diagnostic ign= ored "-Wconversion"
+#endif
+
static void
create_socket(struct link_socke= t *sock, struct addrinfo *addr)
{
@@ -738,= 6 +738,10 @@
bind_local(sock, addr->ai_family);
}

+#if defined(__GNUC__) || defined(__clang__)
+#pragma GCC diagnostic pop
= +#endif
+
#ifdef TARGET_ANDROID
static void
protect_fd_nonlocal(int fd, co= nst struct sockaddr *addr)
@@ -861,10 +865,6 @@
<= span> gc_free(&gc);

}

= -#if defined(__GNUC__) || defined= (__clang__)
-#pragma GC= C diagnostic pop
-#endi= f
-
st= atic socket_descriptor_t
socket_listen_accept(socket_descr= iptor_t sd, struct link_socket_actual *act,
= const struct addrinfo *local, bool do_listen,

To view, visit change 1475. To unsubscribe, or for help writing m= ail filters, visit settings.

<= /div>
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I5ad13bc6674b3403251cc552d1f= 2c0f057431817
Gerrit-Change-Number: 1475
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --WELSP14cQZY=--