From: "cron2 (Code Review)" Date: Sat, 25 Apr 2026 20:31:24 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="DZ9laos413Q="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Fixup: prompting password from management List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair , plaisthos Cc: openvpn-devel --DZ9laos413Q= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1638?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: Fixup: prompting password from management ...................................................................... Fixup: prompting password from management Commit b450414 added logic for reading password from management when not in file or inline, but it was made conditional on `response_from_stdin` which is always true! Fix by explicitly checking for `password_from_stdin`. Github: fixes OpenVPN/openvpn#1021 Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202 Signed-off-by: Selva Nair Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638 Message-Id: <20260424161840.5767-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 739.html Signed-off-by: Gert Doering --- M src/openvpn/misc.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1638/2 diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c index 979293f..10bfc35 100644 --- a/src/openvpn/misc.c +++ b/src/openvpn/misc.c @@ -336,6 +336,7 @@ */ if (management && (flags & GET_USER_PASS_MANAGEMENT) && management_query_user_pass_enabled(management) + && password_from_stdin && !(flags & GET_USER_PASS_USERNAME_ONLY)) { msg(D_LOW, -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1638?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d46c3672691b159cbd98a17020c4f30782bc202 Gerrit-Change-Number: 1638 Gerrit-PatchSet: 2 Gerrit-Owner: selvanair Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --DZ9laos413Q= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by selvanair.<= /p>

Vi= ew Change

The following approvals got outdated and were removed: Code-Review+2 by cron2

Fixup: prompting password from mana=
gement

Commit b450414 added logic for reading password from manageme= nt
when not in file or inline, but it was made conditional on
`respon= se_from_stdin` which is always true! Fix by explicitly
checking for `pas= sword_from_stdin`.

Github: fixes OpenVPN/openvpn#1021

Change-= Id: I4d46c3672691b159cbd98a17020c4f30782bc202
Signed-off-by: Selva Nair = <selva.nair@...277...>
Acked-by: Gert Doering <gert@...1296...&= gt;
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1638
Message-I= d: <20260424161840.5767-1-gert@...1296...>
URL: https://www.mail-a= rchive.com/openvpn-devel@lists.sourceforge.net/msg36739.html
Signed-off-= by: Gert Doering <gert@...1296...>
---
M src/openvpn/misc.c
= 1 file changed, 1 insertion(+), 0 deletions(-)

g=
it pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/38/1638/2
=
diff --git a/src/openvpn/misc.c b/src/openvpn/misc.c
ind= ex 979293f..10bfc35 100644
--- a/src/openvpn/misc.c<= br>+++ b/src/openvpn/misc.c
@@ -336,6 +336,7 @@
*/
if (management &am= p;& (flags & GET_USER_PASS_MANAGEMENT)
= && management_query_user_pass_enabled(management)
+ && passw= ord_from_stdin

&& !(flags & GE= T_USER_PASS_USERNAME_ONLY))
{
= msg(D_LOW,

To view, vi= sit chan= ge 1638. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4d46c3672691b159cbd98a17020= c4f30782bc202
Gerrit-Change-Number: 1638
Gerrit-PatchSet: 2
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --DZ9laos413Q=--