Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2315AC4338F for ; Fri, 30 Jul 2021 13:11:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6365960462 for ; Fri, 30 Jul 2021 13:11:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6365960462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m9SIV-0000YR-CS for qemu-devel@archiver.kernel.org; Fri, 30 Jul 2021 09:11:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9SHu-0008Jr-MW for qemu-devel@nongnu.org; Fri, 30 Jul 2021 09:10:54 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2454) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m9SHs-0006hM-3d for qemu-devel@nongnu.org; Fri, 30 Jul 2021 09:10:54 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Gbnjk25WXzZvfG; Fri, 30 Jul 2021 21:07:06 +0800 (CST) Received: from dggpeml500005.china.huawei.com (7.185.36.59) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 30 Jul 2021 21:10:27 +0800 Received: from [10.174.186.51] (10.174.186.51) by dggpeml500005.china.huawei.com (7.185.36.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 30 Jul 2021 21:10:27 +0800 From: Zheng Chuan Subject: [PATCH V5 00/25] Live Update [restart] : fork mode? To: Steve Sistare , Qemu Developers , "Dr. David Alan Gilbert" , "Juan Quintela" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Alex Williamson , "Paolo Bonzini" , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Xiexiangyou Message-ID: Date: Fri, 30 Jul 2021 21:10:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.186.51] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500005.china.huawei.com (7.185.36.59) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.187; envelope-from=zhengchuan@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, Steve I have saw the discussion about the fork+exec mode below: https://www.mail-archive.com/qemu-devel@nongnu.org/msg815956.html And I am still very curious and I want to discuss about the possibility to support both fork+exec and exec in cpr framework. 1.Why fork+exec could have some advantages and also drawbacks versus execvp() directly. Advantages i) fork+exec give the chance to fallback to original process even after we do exec which is important for workload seamless if any error happens. ii) smaller downtime since we could remove the vm_start() downtime out of the frozen window. Drawbacks i)need more codes to handle including fork,address/ports conflict between parent and child. ii)more complex life cycle management for the two processes. 2.How The cpr framework is flexible and scalable, and maybe we can make use of most codes to support both execvp and fork+exec mode. However, we may need to do more work compared to execvp method. i) do fork mode in a thread like migration thread ii) make parent and child talk to each other through socket or anonymous pipe iii)make use of sharing mechanism of fds in cpr framework including memfd, vfio and devices fds iv)deal with the conflict about the socket address and port like vnc (do by reuse port and pass the different args by cprexec) v) do life cycle managements for two qemu processes and need parent exit and reconnection for the child at last by the management service Please tell me if I am missing something important:) -- Regards. Chuan