Return-Path: Received: from sj-iport-1.cisco.com (sj-iport-1-in.cisco.com [171.71.176.70]) by ozlabs.org (Postfix) with ESMTP id AD54EDDD08 for ; Thu, 15 Feb 2007 11:50:23 +1100 (EST) To: Hoang-Nam Nguyen Subject: Re: [PATCH 2.6.21-rc1 4/5] ehca: replace yield() by wait_for_completion() References: <200702141741.35444.hnguyen@linux.vnet.ibm.com> From: Roland Dreier Date: Wed, 14 Feb 2007 16:50:06 -0800 In-Reply-To: <200702141741.35444.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Wed, 14 Feb 2007 17:41:35 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, openib-general@openib.org, hch@infradead.org, linuxppc-dev@ozlabs.org, raisch@de.ibm.com, h.carstens@de.ibm.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , I agree with Christoph -- the use of wait_for_completion() in a loop makes no sense. When you send a new copy of this patch without whitespace damage, please fix that up too...