Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLP2B-00058o-Aj for qemu-devel@nongnu.org; Thu, 17 Dec 2009 17:41:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLP26-00052S-C8 for qemu-devel@nongnu.org; Thu, 17 Dec 2009 17:41:22 -0500 Received: from [199.232.76.173] (port=54098 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLP26-00052C-7t for qemu-devel@nongnu.org; Thu, 17 Dec 2009 17:41:18 -0500 Received: from sj-iport-1.cisco.com ([171.71.176.70]:48053) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1NLP25-0006y2-N4 for qemu-devel@nongnu.org; Thu, 17 Dec 2009 17:41:18 -0500 From: Roland Dreier References: <4B2AB1F2.3060507@codemonkey.ws> Date: Thu, 17 Dec 2009 14:41:15 -0800 In-Reply-To: <4B2AB1F2.3060507@codemonkey.ws> (Anthony Liguori's message of "Thu, 17 Dec 2009 16:34:26 -0600") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH to consider for 0.12] vmware_vga: Don't crash on too-big DEFINE_CURSOR command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Dave Airlie , qemu-devel@nongnu.org > His last patch has the same fix without the printf(). The printf is > probably something to avoid since a malicious guest could create a > storm of them. Since libvirt logs stderr by default, the result could > be pretty nasty. By the way, are the fprintf(stderr, "%s: update width too large x: %d, w: %d\n", __FUNCTION__, x, w); fprintf(stderr, "%s: update height too large y: %d, h: %d\n", __FUNCTION__, y, h); prints triggerable by a guest? (I think so -- if so I can send a patch removing them if you want) How about the printf()s to stdout? eg a guest can cause a flood of the printf("%s: Unknown command 0x%02x in SVGA command FIFO\n", __FUNCTION__, cmd); or printf("%s: guest runs %s.\n", __FUNCTION__, vmsvga_guest_id[value - GUEST_OS_BASE]); output if it wants pretty trivially.