Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 886ECE9DE6C for ; Thu, 9 Apr 2026 08:51:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wAl64-00070v-7S; Thu, 09 Apr 2026 04:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAl61-00070h-1N for qemu-devel@nongnu.org; Thu, 09 Apr 2026 04:50:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wAl5y-0004AH-HH for qemu-devel@nongnu.org; Thu, 09 Apr 2026 04:50:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775724636; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ykMwwxSHx799hRD7fplH8QIxBEfzFAXGUaFWlwntwI=; b=A25kLDM47bPYbzYXeLVmBnMhnx+kgdZHCdLyAi/gRxIRVrWHl41lhsXWYnH9gKOvWXWCZ2 DYCwjqve6a5H/jfuOgdeXtib2HYiQUOlR39CyJJLnHlkCM5znv16k0m42jp3huhKJL4PzG YgZTcIwMyaOcc5IAPxnAJdRXTRchZnY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-PIqJM-oiOGqzpgA1Lsc1rw-1; Thu, 09 Apr 2026 04:50:32 -0400 X-MC-Unique: PIqJM-oiOGqzpgA1Lsc1rw-1 X-Mimecast-MFC-AGG-ID: PIqJM-oiOGqzpgA1Lsc1rw_1775724631 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9AC871955F18; Thu, 9 Apr 2026 08:50:31 +0000 (UTC) Received: from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com [10.2.32.101]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3016C30001BE; Thu, 9 Apr 2026 08:50:29 +0000 (UTC) Date: Thu, 9 Apr 2026 09:50:27 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Yuma Kurogome Subject: Re: [PATCH for 11.0] hw/uefi: fix heap overflow (CVE-2026-5744) Message-ID: References: <20260408073403.3410541-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260408073403.3410541-1-kraxel@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Apr 08, 2026 at 09:34:02AM +0200, Gerd Hoffmann wrote: > When copying the request response into the pio transfer buffer the code > skips the 'struct mm_header' but does not consider that when calculating > transfer size, so it will copy 24 (== sizeof(struct mm_header)) extra > bytes, which can overflow uv->pio_xfer_buffer. > > Fix that by copying the complete buffer, including the header, which > also makes the pio code path consistent with the (unaffected) dma code > path. > > Fixes: CVE-2026-5744 > Fixes: 90ca4e03c27d ("hw/uefi: add var-service-core.c") > Reported-by: Yuma Kurogome > Signed-off-by: Gerd Hoffmann > --- > hw/uefi/var-service-core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|