Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 121EBEB64D9 for ; Thu, 6 Jul 2023 08:13:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F36938621A; Thu, 6 Jul 2023 10:12:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="ItY8DLQc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B41338624A; Thu, 6 Jul 2023 10:12:56 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F5E3801FE for ; Thu, 6 Jul 2023 10:12:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eugen.hristev@collabora.com Received: from [192.168.0.125] (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id BEACF660585C; Thu, 6 Jul 2023 09:12:53 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688631174; bh=cKSlANf/lhNrKJfMTIr3NJ9GuuaEmuSSIq+3/B8wtgg=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=ItY8DLQcHqg8NiL+JjsxUmj2Vn9bgOjrL2d+EvHXVwR1zvPtlcjxB7pezhxuLdnLC yuSXKXUQtxX5snrnWQit9UTttoOgsypV7H3dJGtIzY4R++Bq/xfaZvNPDcKtqXrGZP y7x9sYh5xhEVmOf89jLAPyxjkOjufmeBLmQ9MWaFq7ULv6K3V0LlosE8MKxlI/beiQ WSn4g0zqXbjxam0s22uekoPbeCAg2/9+A2fSonFkNi7ov3SQcx6t7xJ39o7AI8pkLu Xr/EtVeahyzLUXCtmRohUReKOxdO8bQ6LCReud8vc8imvBdt6Gz3+gzJQwb/Tr62hj 5VScx5DrENOxg== Message-ID: Date: Thu, 6 Jul 2023 11:12:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/5] ARM: dts: at91: sam9x60-curiosity: Fix EEPROM type Content-Language: en-US From: Eugen Hristev To: Alexander Dahl Cc: Alexander Dahl , Durai Manickam KR , u-boot@lists.denx.de, Hari.PrasathGE@microchip.com References: <20230705201701.322372-1-post@lespocky.de> <20230705201701.322372-3-post@lespocky.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 7/6/23 11:06, Eugen Hristev wrote: > On 7/5/23 23:16, Alexander Dahl wrote: >> From: Alexander Dahl >> >> The user guide says it's a Microchip 24AA025E48 serial EEPROM, which is >> a 2-Kbit I2C Serial EEPROM with EUI-48™ Identity.  This is the chip >> actually populated on board EV40E67A rev 4. >> >> Signed-off-by: Alexander Dahl >> --- >> >> Notes: >>      Sadly this did not fix the problem, that I could not access that >>      eeprom through I²C. >> >>   arch/arm/dts/at91-sam9x60_curiosity.dts | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/dts/at91-sam9x60_curiosity.dts >> b/arch/arm/dts/at91-sam9x60_curiosity.dts >> index d6ae3d648d..da5e19b66b 100644 >> --- a/arch/arm/dts/at91-sam9x60_curiosity.dts >> +++ b/arch/arm/dts/at91-sam9x60_curiosity.dts >> @@ -31,7 +31,7 @@ >>                       status = "okay"; >>                       eeprom@53 { >> -                        compatible = "atmel,24c32"; >> +                        compatible = "atmel,24c02"; >>                           reg = <0x53>; >>                           pagesize = <16>; >>                       }; > > Hello Alexander, > > Thank you for the patch. > > I remember I tested this a while back and I remember that the 24c32 > compatible is not correct for this eeprom. > > I have this commit that fixed it for sam9x60ek board: > > commit 5ae89b3cfe842ecbb5153a95e2e3ac404abe543c > Author: Eugen Hristev > Date:   Thu May 26 17:04:56 2022 +0300 > >     ARM: dts: at91: sam9x60ek: fix eeprom compatible > > > > 24c32 should be 32K and 24c02 is 2K . > > I remember that with 24c32 it works, but when you read , the offset > changes, and then you read the same data multiple times, as if the 2K is > multiplied to have the 32K the driver thinks it has. > > Do you have any reasoning for wanting to change the compatible to 24c32 ? > I am trying to understand how you found that 24c32 is better. > > Eugen > I am sorry, I misread your patch. You are doing the exact opposite, which appears to be correct ! Ignore the noise.