From: "d12fk (Code Review)" Date: Tue, 9 Jan 2024 14:53:24 +0000 In-Reply-To: References: Reply-To: heiko@...515..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="WOdk/yEd3Qg="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , cron2 , plaisthos , openvpn-devel --WOdk/yEd3Qg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/489?usp=3Demail ) Change subject: Windows: enforce 'block-local' with WFP filters ...................................................................... Patch Set 3: (5 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/489/comment/b1bfa846_8997b555 : PS1, Line 357: Push this flag to defend against the TunnelCrack attac= ks. > Most terminals handle links sensibly these days. Also we publish this as = HTML documentation. [=E2=80=A6] Done File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/2586766b_9e2183fd : PS1, Line 1971: /* Fortify 'redirect-gateway block-local' with fire= wall rules? */ > Okay there's not much to gain with respect to breaking out run_up_down, a= s that one requires too muc [=E2=80=A6] Done File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/2b4628b0_c3b07ee0 : PS1, Line 78: static bool add_route(struct route_ipv4 *r, const struct tunt= ap *tt, unsigned int flags, > Right, failed to spot this. The build results speak for themselves. [=E2= =80=A6] Done File src/openvpn/wfp_block.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/ed619643_4cbcafe1 : PS1, Line 197: FWPM_FILTER_CONDITION0 Condition[2]; > because the filters are zeroed right below, and than copied into [0] and/= or [1] below as needed, so [=E2=80=A6] Done File src/openvpn/win32.c: http://gerrit.openvpn.net/c/openvpn/+/489/comment/a0fa7528_684d91ad : PS1, Line 1225: if (ret =3D=3D false) > Right, but you could just replace the "got out" with "return false" anywa= y. Yes, but no. The function has a single point of return, let's keep it that = way. There's not enough to gain by changing this. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/489?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ic9bf797bfc7e2d471998a84cb0f071db3e4832ba Gerrit-Change-Number: 489 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 09 Jan 2024 14:53:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: d12fk Gerrit-MessageType: comment --WOdk/yEd3Qg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos. <= /p>

View C= hange

5 comments: