Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF792C678DB for ; Mon, 6 Mar 2023 02:37:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DB79885A7B; Mon, 6 Mar 2023 03:37:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CF92385A43; Mon, 6 Mar 2023 03:37:43 +0100 (CET) Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by phobos.denx.de (Postfix) with ESMTP id 8E04185AA0 for ; Mon, 6 Mar 2023 03:37:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=starfivetech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=yanhong.wang@starfivetech.com Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id BF91224E248; Mon, 6 Mar 2023 10:37:33 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 6 Mar 2023 10:37:33 +0800 Received: from [192.168.120.49] (171.223.208.138) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 6 Mar 2023 10:37:32 +0800 Message-ID: Date: Mon, 6 Mar 2023 10:37:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 16/17] riscv: dts: jh7110: Add initial StarFive VisionFive v2 board device tree Content-Language: en-US To: Conor Dooley CC: , Rick Chen , Leo , Lukasz Majewski , Sean Anderson , Lee Kuan Lim , "Jianlong Huang" , Emil Renner Berthing References: <20230303032432.7837-1-yanhong.wang@starfivetech.com> <20230303032432.7837-17-yanhong.wang@starfivetech.com> <1ea9ba0c-1ca2-4a62-8ec0-ffc5efe3ac78@spud> From: yanhong wang In-Reply-To: <1ea9ba0c-1ca2-4a62-8ec0-ffc5efe3ac78@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2023/3/4 5:20, Conor Dooley wrote: > On Fri, Mar 03, 2023 at 11:24:31AM +0800, Yanhong Wang wrote: >> Add initial device tree for StarFive VisionFive v2 board. >> >> Signed-off-by: Yanhong Wang >> --- >> arch/riscv/dts/Makefile | 3 +- >> ...10-starfive-visionfive-2-v1.2a-u-boot.dtsi | 85 ++++++ >> .../jh7110-starfive-visionfive-2-v1.2a.dts | 12 + >> ...10-starfive-visionfive-2-v1.3b-u-boot.dtsi | 85 ++++++ >> .../jh7110-starfive-visionfive-2-v1.3b.dts | 12 + >> .../dts/jh7110-starfive-visionfive-2.dtsi | 253 ++++++++++++++++++ >> 6 files changed, 449 insertions(+), 1 deletion(-) >> create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi >> create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a.dts >> create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.3b-u-boot.dtsi >> create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.3b.dts >> create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi > >> diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi >> new file mode 100644 >> index 0000000000..e669c2a26a >> --- /dev/null >> +++ b/arch/riscv/dts/jh7110-starfive-visionfive-2.dtsi >> @@ -0,0 +1,253 @@ >> +// SPDX-License-Identifier: GPL-2.0 OR MIT >> +/* >> + * Copyright (C) 2022 StarFive Technology Co., Ltd. >> + */ >> + >> +/dts-v1/; >> + >> +#include "jh7110.dtsi" >> +#include >> +/ { >> + aliases { >> + serial0 = &uart0; >> + spi0 = &qspi; >> + mmc0 = &mmc0; >> + mmc1 = &mmc1; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200"; >> + }; >> + >> + cpus { >> + timebase-frequency = <4000000>; >> + }; >> + >> + memory@40000000 { >> + device_type = "memory"; >> + reg = <0x0 0x40000000 0x2 0x0>; >> + }; >> +}; >> + > >> +&S7_0 { >> + status = "okay"; >> +}; > > Please forgive me if I am missing something obvious, but should this be > be in -u-boot.dtsi instead? > Thanks. I will move this node to -u-boot.dtsi. > Cheers, > Conor.