Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 00AEB21161B0E for ; Thu, 4 Oct 2018 17:05:39 -0700 (PDT) From: "Williams, Dan J" Subject: Re: [ndctl PATCH 2/2] ndctl, monitor: in daemon mode, exit successfully if no DIMMs are found Date: Fri, 5 Oct 2018 00:05:37 +0000 Message-ID: References: <20181005000057.30186-1-vishal.l.verma@intel.com> <20181005000057.30186-2-vishal.l.verma@intel.com> In-Reply-To: <20181005000057.30186-2-vishal.l.verma@intel.com> Content-Language: en-US Content-ID: <42A20BE7277D4F488D0047E441F50C03@intel.com> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "linux-nvdimm@lists.01.org" , "Verma, Vishal L" Cc: "andreas@canonical.com" List-ID: On Thu, 2018-10-04 at 18:00 -0600, Vishal Verma wrote: > When we are running as a daemon, it is preferred to exit successfully > when no DIMMs are found. When running in the foreground, retain an > error > return so that the user can be notified that nothing was found to > monitor. > > In the longer term, replace this with a libudev uevent monitor that > will > look for DIMM addition/removal events, and update the running > monitor(s) > if the DIMMs match the active filter spec. > > Link: https://bugs.launchpad.net/ubuntu/+source/ndctl/+bug/1781268 > Reported-by: Andreas Hasenack > Cc: Dan Williams Looks good to me, if no one is sticking around to reap the error might as well claim success. Reviewed-by: Dan Williams _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm