DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1254C2081B
Subject: Re: [RFC PATCH v2] block: add io timeout to sysfs
To:     Weiping Zhang <zwp10758@gmail.com>, linux-block@vger.kernel.org
References: <20181119141145.GA25638@192.168.3.9>
 <CAA70yB6DedBE=yrbQD5qUdPL2HBtRHg9TejcywGMqeuAcqGM6Q@mail.gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <ae7c1cc8-cd0b-1aff-6388-4ada80418350@kernel.dk>
Date:   Wed, 28 Nov 2018 08:20:14 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAA70yB6DedBE=yrbQD5qUdPL2HBtRHg9TejcywGMqeuAcqGM6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-block-owner@vger.kernel.org
Precedence: bulk

On 11/28/18 7:52 AM, Weiping Zhang wrote:
> Hi Jens,
> 
> It's useful if user want a short timeout when a disk doesn't work normally.
> Would you give some comments for this patch,

I'm fine with the patch, in fact I've posted a similar/identical one in
the past but just never got around to merging it. I think we should
expose the value in seconds or msecs, however, not in jiffies. That
makes it hard to use for people.

So modify it to do a msecs_to_jiffies() on the value passed in.

-- 
Jens Axboe