From: "flichtenheld (Code Review)" Date: Tue, 7 Apr 2026 20:06:35 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="EzLp3jky1gs="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: openvpnserv: Remove redundant bit-wise operation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --EzLp3jky1gs= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=3Demail to review the following change. Change subject: openvpnserv: Remove redundant bit-wise operation ...................................................................... openvpnserv: Remove redundant bit-wise operation Found by cppcheck. Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Signed-off-by: Frank Lichtenheld --- M src/openvpnserv/interactive.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/23/1623/1 diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index a2f9f09..ace25b9 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -3410,7 +3410,7 @@ ea[0].Trustee.TrusteeForm =3D TRUSTEE_IS_SID; ea[0].Trustee.TrusteeType =3D TRUSTEE_IS_UNKNOWN; ea[0].Trustee.ptstrName =3D (LPWSTR)svc_user->User.Sid; - ea[1].grfAccessPermissions =3D READ_CONTROL | SYNCHRONIZE | PROCESS_VM= _READ | SYNCHRONIZE + ea[1].grfAccessPermissions =3D READ_CONTROL | PROCESS_VM_READ | SYNCHR= ONIZE | PROCESS_TERMINATE | PROCESS_QUERY_INFOR= MATION; ea[1].grfAccessMode =3D SET_ACCESS; ea[1].grfInheritance =3D NO_INHERITANCE; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1623?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newchange Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7f983168c263e49da7665fc20bd1ecdd426c21d0 Gerrit-Change-Number: 1623 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --EzLp3jky1gs= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

openvpnserv: Remove redundant bit-wise oper=
ation

Found by cppcheck.

Change-Id: I7f983168c263e49da7665fc2= 0bd1ecdd426c21d0
Signed-off-by: Frank Lichtenheld <frank@...2641...&g= t;
---
M src/openvpnserv/interactive.c
1 file changed, 1 insertion= (+), 1 deletion(-)

git pull ssh://gerrit.openvpn=
.net:29418/openvpn refs/changes/23/1623/1
diff --git a/src/openvpns=
erv/interactive.c b/src/openvpnserv/interactive.c
index a2f= 9f09..ace25b9 100644
--- a/src/openvpnserv/interactive.c
+++ b/src/openvpnserv/interactive.c
@@ -3410,= 7 +3410,7 @@
ea[0].Trustee.TrusteeForm =3D TRUSTEE_IS_= SID;
ea[0].Trustee.TrusteeType =3D TRUSTEE_IS_UNKNOWN;=
ea[0].Trustee.ptstrName =3D (LPWSTR)svc_user->User= .Sid;
- ea[1].grfAcc= essPermissions =3D READ_CONTROL | SYNCHRONIZE | PROCESS_VM_READ | SYNCHRONI= ZE
+ ea[1].grfAcce= ssPermissions =3D READ_CONTROL | PROCESS_VM_READ | SYNCHRONIZE
| PROCESS_TERMINATE | PROCESS_QUERY_I= NFORMATION;

ea[1].grfAccessMode =3D SET_ACCESS;=
ea[1].grfInheritance =3D NO_INHERITANCE;

To view, visit change 1623. To unsubscribe, or for help writin= g mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7f983168c263e49da7665fc20bd= 1ecdd426c21d0
Gerrit-Change-Number: 1623
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --EzLp3jky1gs=--