Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175B2C169C4 for ; Wed, 6 Feb 2019 22:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF78D218B0 for ; Wed, 6 Feb 2019 22:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BK9OlsdA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfBFWdL (ORCPT ); Wed, 6 Feb 2019 17:33:11 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:45496 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbfBFWdL (ORCPT ); Wed, 6 Feb 2019 17:33:11 -0500 Received: by mail-pf1-f194.google.com with SMTP id j3so1656828pfi.12 for ; Wed, 06 Feb 2019 14:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oBdzk86nc5Pmr/uNSzaxh9m32WFeDQ3IjvnUt3eoxmE=; b=BK9OlsdA6Rme8vk+5c00hdQV6zOwnmYH53VILIPVYWfZZAWocZXCFp/nmqjY4IB/qb 5SZ5Q38KHoHkf7a//2IrgR2X57CEU3H/3PYgOxbXhwPrPf/TI6ew9gLwqSJfpnT3CGUg 4vK4Fd+sCoH9CKg5WTQFfityoyrcA2WXJFJw7nQCFDtOWds4aDpxy7/e9x/hegXSL+Un YVhNRc+Pf4M+JCugVUtfBwG1E08H6clfYdeiWAOrNpRdDkIxdb8jESItRoiTZGe1X4N0 RQMCMXTr01J0TAWSJ1xQrN5FBv+j9vLENZstCEdUcIehYe29AnoY8rM31RuGmV4LA76G bkTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=oBdzk86nc5Pmr/uNSzaxh9m32WFeDQ3IjvnUt3eoxmE=; b=ceCiBK/WuQTcO2MsCyN4DuyWq/v0fICOy46eb/8XAQpKEBn77sIkf7TqRxVbZqF3z/ 5O42J4DfldKm6cJD/ZDH1ujtJkkzPzK1RNodrBz8xyVtbSoHe+NYXT09U+o4j9EU+3Mh ywJrWWPEq+eZa10f0w3/t5XNV4MOiH/MYrzdkxeIX8zfuIv+U6l57wk4HpbHIKXPfa/t qo1CM1lZkwVb71oQTcBreOvqrWjzKfEI7ixYiNRO6Aei4QERWC7hKsTp84AC6RjCgQLG iyqATbXcNBe/Ebo9/B+DAm9Y2KBKV1gq1Ol3nffipRc89ndh/gppwvuQ8ylJv+/EZd6T YyLA== X-Gm-Message-State: AHQUAuYbVBbmo/7FtyKnO+aeUFS3DiBNh6CeaoTkbbeu+4IiQukhHMRN YlkJ++GoXogNDkEkS7EfKxk= X-Google-Smtp-Source: AHgI3IbcYNs5FFx4dRm9+aIKvYd2h0ixbUyhzTPKqv/Zb4PxptwuRdyRIAb36D1eHXcNUWRZ7HNXLA== X-Received: by 2002:a63:4744:: with SMTP id w4mr11612462pgk.110.1549492390276; Wed, 06 Feb 2019 14:33:10 -0800 (PST) Received: from [10.67.48.231] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id 19sm15298713pfs.108.2019.02.06.14.33.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 14:33:09 -0800 (PST) Subject: Re: [PATCH v1] net: dsa: qca8k: implement DT-based ports <-> phy translation From: Florian Fainelli To: Christian Lamparter Cc: Andrew Lunn , netdev@vger.kernel.org, Vivien Didelot References: <20190204213555.26054-1-chunkeey@gmail.com> <2061891.QOleSDBFsG@debian64> <699dfb8a-11d4-b27a-e762-ff4fdff1a3d7@gmail.com> <3897570.9hORRSCDvi@debian64> <14f73250-4255-6f4e-336a-9bf289539b75@gmail.com> Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Wed, 6 Feb 2019 14:32:56 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <14f73250-4255-6f4e-336a-9bf289539b75@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/6/19 2:29 PM, Florian Fainelli wrote: > On 2/6/19 1:57 PM, Christian Lamparter wrote: >> On Tuesday, February 5, 2019 11:29:36 PM CET Florian Fainelli wrote: >>> On 2/5/19 2:12 PM, Christian Lamparter wrote: >>>> On Tuesday, February 5, 2019 10:29:34 PM CET Andrew Lunn wrote: >>>>>> For now, I added the DT binding update to the patch as well. >>>>>> But if this is indeed the way to go, it'll get a separate patch. >>>>> >>>>> Hi Christian >>>>> >>>>> You need to be careful with the DT binding. You need to keep backwards >>>>> compatible with it. An old DT blob needs to keep working. I don't >>>>> think this is true with this change. >>>> >>>> Do you mean because of the >>>> >>>> - switch0@0 { >>>> + switch@10 { >>>> compatible = "qca,qca8337"; >>>> #address-cells = <1>; >>>> #size-cells = <0>; >>>> >>>> - reg = <0>; >>>> + reg = <0x10>; >>>> >>>> change? >>>> >>>> or because I removed the phy-handles?> >>>> The reg = <0x10>; will be necessary regardless. Because this >>>> is really a bug in the existing binding example and if it is >>>> copied it will prevent the qca8k driver from loading. >>>> This is due to a resource conflict, because there will be >>>> already a "phy_port1: phy@0" registered at reg = <0>; >>>> So this never worked would have worked. >>> >>> That part is fine, it is the removal of the phy-handle properties that >>> is possibly a problem, but in hindsight, I do not believe it will be a >>> compatibility issue. Lack of "phy-handle" property within the core DSA >>> layer means: utilize the switch's internal MDIO bus (ds->slave_mii_bus) >>> instance, which you are not removing, you are just changing how the PHYs >>> map to port numbers. >>> >> Ok, thanks. >> >> I think I'm almost ready for v2. I have fully addressed the compatibility >> issue by forking off the qca8k_switch_ops depending on whenever a phy-handle >> property on one of the ports was found or not. If there was no phy-handle the >> driver adds the slave-bus accessors to the ops which tells DSA to allocate >> the slave bus and allows the phys can be enumerated. If the phy-handles are >> found the driver will not have the accessors and DSA will not setup a >> redundant/fake bus and this prevents the second/double/duplicated discovery >> and enumeration of the same PHYs again. > > The logic you have sounds a little too broad since it stops as soon as > one port is found with a 'phy-handle' property and assumes that the > parent MDIO bus from which qca8k itself is a child device, is the MDIO > bus to be used. There are possibly 3 cases: > > 1) All ports using internal/build-in PHYs. In that case, you can either > not specify a 'phy-handle' property and DSA assumes that they are part > of the switch's internal MDIO bus. You can also specify a 'phy-handle' > property that references the internal MDIO bus, although then we also > expect qca8k to register its internal MDIO bus (ala mv88e6xxx) > > 2) Some ports using internal PHYs, some using external PHYs. Similar > situation again, ports may, or may not specify a 'phy-handle' property, > so without a 'phy-handle' property that means the port connects to an > internal PHY, with a 'phy-handle' it could connect to either internal > PHY or external PHY > > 3) All ports using external PHYs, in that case, we must have a > 'phy-handle' for each port to specify where and how they connect to > their external PHYs. > > With respect to your patch, what I would do is register QCA8k's internal > MDIO bus as a proper mdio bus and use ds->slave_mii_bus as a storage for > that bus, such that tell the DSA layer: look, here is the internal MDIO > bus, would you ever find a port that needs to use a PHY in there. > > Then you can still scan each enabled port device, and for each of them, > populate ds->phys_mii_mask, thus telling DSA exacly which ports are > using an internal PHY because that would be the ports that do not have a > 'phy-handle' property. Ports that have a 'phy-handle' property. Forgot to finish my sentence here. This should read: Ports that have a 'phy-handle' property will either point to the QCA8k's internal MDIO bus or an external one, but that will be transparently be handled during PHY device creation. Thanks! -- Florian