From: "cron2 (Code Review)" Date: Mon, 26 Jan 2026 15:41:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="aFQXgN8devk="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: GHA: Run openvpnserv UT for MinGW builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --aFQXgN8devk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1487?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: GHA: Run openvpnserv UT for MinGW builds ...................................................................... GHA: Run openvpnserv UT for MinGW builds Should have been added in commit b10ee38ccde5f155d02fcd3e8f1b1ab454826ab0. Note that test_openvpnserv.exe lives in a separate directory, so we need to make the code a bit more flexible. Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487 Message-Id: <20260126151122.588-1-gert@...1296...> Signed-off-by: Gert Doering --- M .github/workflows/build.yaml 1 file changed, 6 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/3 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 4570417..7d1574c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -100,13 +100,13 @@ path: | ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/*.dll - !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${= { matrix.build }}/test_*.exe + !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**= /${{ matrix.build }}/test_*.exe - uses: actions/upload-artifact@...2978... # v6.0.0 with: name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: | - ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{= matrix.build }}/test_*.exe + ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/= ${{ matrix.build }}/test_*.exe ${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{= matrix.build }}/*.dll mingw-unittest: @@ -115,7 +115,7 @@ fail-fast: false matrix: arch: [x86, x64] - test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_= parse, ncp, packet_id, pkt, provider, ssl, tls_crypt, user_pass] + test: [argv, auth_token, buffer, cryptoapi, crypto, misc, options_= parse, ncp, openvpnserv, packet_id, pkt, provider, ssl, tls_crypt, user_pas= s] build: [Release, Debug] runs-on: windows-2025 @@ -129,7 +129,9 @@ name: openvpn-mingw-${{ matrix.arch }}-${{ matrix.build }}-tests path: unittests - name: Run ${{ matrix.test }} unit test - run: ./unittests/test_${{ matrix.test }}.exe + run: | + $test_file=3D(Get-ChildItem -Path unittests -Filter test_${{ mat= rix.test }}.exe -Recurse).fullname + & $test_file env: srcdir: "${{ github.workspace }}/tests/unit_tests/openvpn" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1487?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If61a91b4580864fd22162c94467ba3dda2045b7b Gerrit-Change-Number: 1487 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --aFQXgN8devk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #3 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

GHA: Run openvpnserv UT for MinGW b=
uilds

Should have been added in commit
b10ee38ccde5f155d02fcd3e8f= 1b1ab454826ab0.

Note that test_openvpnserv.exe lives in a
separat= e directory, so we need to make the
code a bit more flexible.

Cha= nge-Id: If61a91b4580864fd22162c94467ba3dda2045b7b
Signed-off-by: Frank L= ichtenheld <frank@...2641...>
Acked-by: Gert Doering <gert@...1386...= 296...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1487
Me= ssage-Id: <20260126151122.588-1-gert@...1296...>
Signed-off-by: Ge= rt Doering <gert@...1296...>
---
M .github/workflows/build.yaml=
1 file changed, 6 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/87/1487/3<=
/pre>
-           =
 !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/${{ matrix.bui=
ld }}/test_*.exe
+ = !${{ github.workspace }}/out/build/mingw/${{ matrix.arch }}/**/${{= matrix.build }}/test_*.exe

- uses= : actions/upload-artifact@...2978... # v6.0.0
with= :
name: openvpn-mingw-${{ matrix.arch }}-${{ mat= rix.build }}-tests
path: |
- ${{ github.workspace }}/out/bui= ld/mingw/${{ matrix.arch }}/${{ matrix.build }}/test_*.exe
+ ${{ github.workspace }}/= out/build/mingw/${{ matrix.arch }}/**/${{ matrix.build }}/test_*.exe=
${{ github.workspace }}/out/build/mingw/${{ matrix.a= rch }}/${{ matrix.build }}/*.dll

mingw= -unittest:
@@ -115,7 +115,7 @@
fail-= fast: false
matrix:
arch: [= x86, x64]
- test= : [argv, auth_token, buffer, cryptoapi, crypto, misc, options_parse, ncp, p= acket_id, pkt, provider, ssl, tls_crypt, user_pass]
+ test: [argv, auth_token, buffer, = cryptoapi, crypto, misc, options_parse, ncp, openvpnserv, packet_id, pkt, p= rovider, ssl, tls_crypt, user_pass]
build: [Releas= e, Debug]

runs-on: windows-2025
@@ -129,7 +129,9 @@
name: openvpn-mi= ngw-${{ matrix.arch }}-${{ matrix.build }}-tests
= path: unittests
- name: Run ${{ matrix.test }} unit= test
- run: ./u= nittests/test_${{ matrix.test }}.exe
+ run: |
+ $test_file=3D(Get-ChildItem -Path unittests -Filter t= est_${{ matrix.test }}.exe -Recurse).fullname
+ & $test_file
= env:
srcdir: "${{ github.workspace }}/te= sts/unit_tests/openvpn"


<= /pre>

To view, visit change 1487. To unsubscribe, or for help writing mail fi= lters, visit set= tings.

=
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If61a91b4580864fd22162c94467= ba3dda2045b7b
Gerrit-Change-Number: 1487
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --aFQXgN8devk=--