From: Maxime Coquelin Subject: Re: [PATCH v7 2/2] examples/vdpa: introduce a new sample for vDPA Date: Fri, 28 Sep 2018 09:49:41 +0200 Message-ID: References: <20180926090638.4705-1-xiaolong.ye@intel.com> <20180928112344.42791-1-xiaolong.ye@intel.com> <20180928112344.42791-3-xiaolong.ye@intel.com> <20180928143353.GA44187@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Tiwei Bie , Zhihong Wang , xiao.w.wang@intel.com, Rami Rosen , Wang Haiyue To: Ye Xiaolong Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D9BC31B13B for ; Fri, 28 Sep 2018 09:49:46 +0200 (CEST) In-Reply-To: <20180928143353.GA44187@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/28/2018 04:33 PM, Ye Xiaolong wrote: > On 09/28, Maxime Coquelin wrote: >>> + ret = rte_eal_init(argc, argv); >>> + if (ret < 0) >>> + rte_exit(EXIT_FAILURE, "eal init failed\n"); >>> + argc -= ret; >>> + argv += ret; >>> + >>> + data_init(); >> >> You need to check return from data_init(). >> If this is fine for you, I can change to below code when applying: >> >> ret = data_init(); >> if (ret < 0) >> rte_exit(EXIT_FAILURE, "data init failed\n"); >> >> > > I'm fine with this change. Or even better, get rid of data_init and call rte_vdpa_get_device_num(); in main directly. > Thanks, > Xiaolong >