Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFF7DFF8867 for ; Wed, 29 Apr 2026 11:31:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wI38D-0003WF-8G; Wed, 29 Apr 2026 07:31:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wI387-0003Ug-Ge for qemu-devel@nongnu.org; Wed, 29 Apr 2026 07:31:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wI37v-0008Nf-BP for qemu-devel@nongnu.org; Wed, 29 Apr 2026 07:30:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777462246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GUyYWsRV0uIzVe6NWszNJFG7WKLY7C8xMB6sbo3od28=; b=U/8tkpj72PkvHxgIvC4bn1/DLwGXHsoaMaRR6ijL18opJvP+hpFss7v9da1KYi5hVyjByA AZHfqtbJwM36eyAWWoRdJKbnVdXEGENSdkbNhpW9cUS68KEdKP/Pk7+4GC9MX4lgDIKnCm 57P35+Wp5QtJ4jpwKmsGV4guuibjFuw= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-3mIEgUvcONeUX5gE3HASGw-1; Wed, 29 Apr 2026 07:30:45 -0400 X-MC-Unique: 3mIEgUvcONeUX5gE3HASGw-1 X-Mimecast-MFC-AGG-ID: 3mIEgUvcONeUX5gE3HASGw_1777462244 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b4678c6171so117348075ad.1 for ; Wed, 29 Apr 2026 04:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777462244; x=1778067044; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GUyYWsRV0uIzVe6NWszNJFG7WKLY7C8xMB6sbo3od28=; b=NUmTL80QbsIuQx3Zk65GYicX1b5HTYZbqmiCZHsiMXew+r/pn8J5SD7Q4/Lr1gCcJu INtlB1yZAa8GGzPSXo4g6xhI7YtSGX88JR9Z0aAbTnKf/Uyx7XIwsLa/hTA3QsJAXPoS sIJout6Npj9QNFxlQ0pJrmU177y0ijlhXtA9Qsas5r9+iTaIEml6l43H2dLJ3Nh7yzye kVxJAKOJj368DFlByg3fic+MC+5Jk/Gtr6CusTrXeQfuNPSykeON07/e24V2kEwgwwMl xfxnHbKOnssFFlrfu56BPUYbB52WBnK1qRcWb+UuWnTDTRoiQk93X9R3sspco/uznhYa iRFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777462244; x=1778067044; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GUyYWsRV0uIzVe6NWszNJFG7WKLY7C8xMB6sbo3od28=; b=AXnIT7OhdaVAk6nrcoEsbgY/089eR+Rvr4nVg/zfmrFLSbRUyXCjlbv0Z6WVwLmgHq rZUfuN8IcdZlzFImELGXuq3fmeymBqzJ8afyiTzQJDt5hvFmD63CMYid8gOQLZBitPiB 2pS4UmE4axomhvPim09k9mTWTjyP3JM3J3u9DEkLs+8MYicCmnxKha5dhLywhURldgIW kmk6WWBJwebVqrwiBr3i/mLK9vbRCGFT+/wtuqO4LVibkP1omS35xwPBXnuAmImJ8XUk qhgkuKDTb3lySDMQ6vPuYkmqxKfMVx+O+363/SMrgAtKwG+OkpzkK2VekYcoV7aFEYrh NaNg== X-Gm-Message-State: AOJu0Yx8dW/mCAtvxyqwoW37VCnrU//O1BJuxDdk09MMmvmCtq6Le2Ib Cb/ZeFlo8MgJ8tss45ooE9ft9sDHg8xOiF4hkZR+9thu4MAf1TgJkrPpQDq3rbhCL7jFE8eDVZb a1MI/pPPLMfyHk9x6n1jd/9H9NY/1/rI4SxF9D3k9brvYYdwRORLBuYpQnSpQVp9f X-Gm-Gg: AeBDiet2mGqyuuyVmMmImjL2KIi5YTLuft5dKVc5Zrz5i5OewwoYVNBfls4LbzaH9N2 d/Ou+r1Wf5RUJKWk53YftvXw7Y8oRrl4b2ljZWQf903nH7fEiQidM6AyOePnIzCUPmWDiz4RU2i GzvCpqQMeTcJMrRxEDSWjrfbRn1s94WZnYu3viIMZP3qoGOmGosdcTStrnhmoowTMM7CT+pJXOy ITMxz9CWn/xk1s8dScHEzvpIM0vifaBp4TIZ0EAYy70QEidk36hM8zUSRi8ObBbi4cJhDxfQwVS sOrIZBgdhJ35wf6EycrY7hProtgHw+vSs/JS7Bu9oEVUtDDBmaHiu+VQ/s6avs3jVVDBeNzb/tD DPlrfoTXGsDsWmESpeimzVWk= X-Received: by 2002:a17:902:c952:b0:2a9:e8b:5326 with SMTP id d9443c01a7336-2b97c47982emr73755455ad.23.1777462243279; Wed, 29 Apr 2026 04:30:43 -0700 (PDT) X-Received: by 2002:a17:902:c952:b0:2a9:e8b:5326 with SMTP id d9443c01a7336-2b97c47982emr73754925ad.23.1777462242394; Wed, 29 Apr 2026 04:30:42 -0700 (PDT) Received: from fedora ([49.36.106.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b98895a919sm19426095ad.55.2026.04.29.04.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 04:30:42 -0700 (PDT) Date: Wed, 29 Apr 2026 17:00:37 +0530 From: Arun Menon To: Stefan Berger Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com Subject: Re: [PATCH 2/6] tests: Have TPM I2C read/write functions take QTestState as first parameter Message-ID: References: <20260428130718.1325177-1-stefanb@linux.ibm.com> <20260428130718.1325177-3-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428130718.1325177-3-stefanb@linux.ibm.com> Received-SPF: pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi, On Tue, Apr 28, 2026 at 01:07:14PM +0000, Stefan Berger wrote: > Pass the QTestState as first parameter to the TPM I2C functions. Use > global_qtest in existing test cases. > > Signed-off-by: Stefan Berger > --- > tests/qtest/tpm-tis-i2c-test.c | 171 +++++++++++++++++---------------- > tests/qtest/tpm-tis-i2c-util.c | 32 +++--- > tests/qtest/tpm-tis-i2c-util.h | 10 +- > 3 files changed, 110 insertions(+), 103 deletions(-) > > diff --git a/tests/qtest/tpm-tis-i2c-test.c b/tests/qtest/tpm-tis-i2c-test.c > index 02ddf76c2c..f614f888f3 100644 > --- a/tests/qtest/tpm-tis-i2c-test.c > +++ b/tests/qtest/tpm-tis-i2c-test.c > @@ -50,62 +50,64 @@ static void tpm_tis_i2c_test_basic(const void *data) > * All register accesses below must work without locality 0 being the > * active locality. Therefore, ensure access is released. > */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > - access = tpm_tis_i2c_readb(0, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* read interrupt capability -- none are supported */ > - v = tpm_tis_i2c_readl(0, TPM_I2C_REG_INT_CAPABILITY); > + v = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_INT_CAPABILITY); > g_assert_cmpint(v, ==, 0); > > /* try to enable all interrupts */ > - tpm_tis_i2c_writel(0, TPM_I2C_REG_INT_ENABLE, 0xffffffff); > - v = tpm_tis_i2c_readl(0, TPM_I2C_REG_INT_ENABLE); > + tpm_tis_i2c_writel(global_qtest, 0, TPM_I2C_REG_INT_ENABLE, 0xffffffff); > + v = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_INT_ENABLE); > /* none could be enabled */ > g_assert_cmpint(v, ==, 0); > > /* enable csum */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_DATA_CSUM_ENABLE, TPM_DATA_CSUM_ENABLED); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE, > + TPM_DATA_CSUM_ENABLED); > /* check csum enable register has bit 0 set */ > - v = tpm_tis_i2c_readb(0, TPM_I2C_REG_DATA_CSUM_ENABLE); > + v = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE); > g_assert_cmpint(v, ==, TPM_DATA_CSUM_ENABLED); > /* reading it as 32bit register returns same result */ > - v = tpm_tis_i2c_readl(0, TPM_I2C_REG_DATA_CSUM_ENABLE); > + v = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE); > g_assert_cmpint(v, ==, TPM_DATA_CSUM_ENABLED); > > /* disable csum */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_DATA_CSUM_ENABLE, 0); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE, 0); > /* check csum enable register has bit 0 clear */ > - v = tpm_tis_i2c_readb(0, TPM_I2C_REG_DATA_CSUM_ENABLE); > + v = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE); > g_assert_cmpint(v, ==, 0); > > /* write to unsupported register '1' */ > - tpm_tis_i2c_writel(0, 1, 0x12345678); > - v = tpm_tis_i2c_readl(0, 1); > + tpm_tis_i2c_writel(global_qtest, 0, 1, 0x12345678); > + v = tpm_tis_i2c_readl(global_qtest, 0, 1); > g_assert_cmpint(v, ==, 0xffffffff); > > /* request use of locality */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_REQUEST_USE); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_ACCESS, > + TPM_TIS_ACCESS_REQUEST_USE); > > /* read byte from STS + 3 */ > - v = tpm_tis_i2c_readb(0, TPM_I2C_REG_STS + 3); > + v = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_STS + 3); > g_assert_cmpint(v, ==, 0); > > /* check STS after writing to STS + 3 */ > - v = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_STS + 3, 0xf); > - v2 = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + v = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_STS + 3, 0xf); > + v2 = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > g_assert_cmpint(v, ==, v2); > > /* release access */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > > /* select locality 5 -- must not be possible */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_LOC_SEL, 5); > - v = tpm_tis_i2c_readb(0, TPM_I2C_REG_LOC_SEL); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_LOC_SEL, 5); > + v = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_LOC_SEL); > g_assert_cmpint(v, ==, 0); > } > > @@ -118,11 +120,12 @@ static void tpm_tis_i2c_test_check_localities(const void *data) > uint32_t rid; > > for (locty = 0; locty < TPM_TIS_NUM_LOCALITIES; locty++) { > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > - capability = tpm_tis_i2c_readl(locty, TPM_I2C_REG_INTF_CAPABILITY); > + capability = tpm_tis_i2c_readl(global_qtest, locty, > + TPM_I2C_REG_INTF_CAPABILITY); > i2c_cap = (TPM_I2C_CAP_INTERFACE_TYPE | > TPM_I2C_CAP_INTERFACE_VER | > TPM_I2C_CAP_TPM2_FAMILY | > @@ -131,15 +134,15 @@ static void tpm_tis_i2c_test_check_localities(const void *data) > TPM_I2C_CAP_DEV_ADDR_CHANGE); > g_assert_cmpint(capability, ==, i2c_cap); > > - didvid = tpm_tis_i2c_readl(locty, TPM_I2C_REG_DID_VID); > + didvid = tpm_tis_i2c_readl(global_qtest, locty, TPM_I2C_REG_DID_VID); > g_assert_cmpint(didvid, ==, (1 << 16) | PCI_VENDOR_ID_IBM); > > - rid = tpm_tis_i2c_readl(locty, TPM_I2C_REG_RID); > + rid = tpm_tis_i2c_readl(global_qtest, locty, TPM_I2C_REG_RID); > g_assert_cmpint(rid, !=, 0); > g_assert_cmpint(rid, !=, 0xffffffff); > > /* locality selection must be at locty */ > - l = tpm_tis_i2c_readb(locty, TPM_I2C_REG_LOC_SEL); > + l = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_LOC_SEL); > g_assert_cmpint(l, ==, locty); > } > } > @@ -151,23 +154,23 @@ static void tpm_tis_i2c_test_check_access_reg(const void *data) > > /* do not test locality 4 (hw only) */ > for (locty = 0; locty < TPM_TIS_NUM_LOCALITIES - 1; locty++) { > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* request use of locality */ > - tpm_tis_i2c_writeb(locty, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, locty, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_REQUEST_USE); > > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* release access */ > - tpm_tis_i2c_writeb(locty, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, locty, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > } > @@ -186,14 +189,14 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > for (locty = 0; locty < TPM_TIS_NUM_LOCALITIES - 1; locty++) { > pending_request_flag = 0; > > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* request use of locality */ > - tpm_tis_i2c_writeb(locty, > + tpm_tis_i2c_writeb(global_qtest, locty, > TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_REQUEST_USE); > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > @@ -201,14 +204,14 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > /* lower localities cannot seize access */ > for (l = 0; l < locty; l++) { > /* lower locality is not active */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > pending_request_flag | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* try to request use from 'l' */ > - tpm_tis_i2c_writeb(l, > + tpm_tis_i2c_writeb(global_qtest, l, > TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_REQUEST_USE); > > @@ -216,7 +219,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > * requesting use from 'l' was not possible; > * we must see REQUEST_USE and possibly PENDING_REQUEST > */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_REQUEST_USE | > @@ -227,17 +230,17 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > * locality 'locty' must be unchanged; > * we must see PENDING_REQUEST > */ > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_PENDING_REQUEST | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* try to seize from 'l' */ > - tpm_tis_i2c_writeb(l, > + tpm_tis_i2c_writeb(global_qtest, l, > TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_SEIZE); > /* seize from 'l' was not possible */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_REQUEST_USE | > @@ -245,7 +248,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* locality 'locty' must be unchanged */ > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_PENDING_REQUEST | > @@ -264,14 +267,14 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > */ > for (l = locty + 1; l < TPM_TIS_NUM_LOCALITIES - 1; l++) { > /* try to 'request use' from 'l' */ > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_REQUEST_USE); > > /* > * requesting use from 'l' was not possible; we should see > * REQUEST_USE and may see PENDING_REQUEST > */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_REQUEST_USE | > @@ -282,7 +285,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > * locality 'l-1' must be unchanged; we should always > * see PENDING_REQUEST from 'l' requesting access > */ > - access = tpm_tis_i2c_readb(l - 1, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l - 1, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > @@ -290,10 +293,11 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* try to seize from 'l' */ > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_SEIZE); > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > + TPM_TIS_ACCESS_SEIZE); > > /* seize from 'l' was possible */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > @@ -301,7 +305,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* l - 1 should show that it has BEEN_SEIZED */ > - access = tpm_tis_i2c_readb(l - 1, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l - 1, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_BEEN_SEIZED | > @@ -309,10 +313,10 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* clear the BEEN_SEIZED flag and make sure it's gone */ > - tpm_tis_i2c_writeb(l - 1, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l - 1, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_BEEN_SEIZED); > > - access = tpm_tis_i2c_readb(l - 1, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l - 1, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > pending_request_flag | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > @@ -330,22 +334,22 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > /* release access from l - 1; this activates locty - 1 */ > l--; > > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > > DPRINTF("%s: %d: relinquishing control on l = %d\n", > __func__, __LINE__, l); > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > pending_request_flag | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > for (l = locty - 1; l >= 0; l--) { > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > @@ -353,7 +357,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* release this locality */ > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > > if (l == 1) { > @@ -363,7 +367,7 @@ static void tpm_tis_i2c_test_check_access_reg_seize(const void *data) > > /* no locality may be active now */ > for (l = 0; l < TPM_TIS_NUM_LOCALITIES - 1; l++) { > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > @@ -384,14 +388,14 @@ static void tpm_tis_i2c_test_check_access_reg_release(const void *data) > for (locty = TPM_TIS_NUM_LOCALITIES - 2; locty >= 0; locty--) { > pending_request_flag = 0; > > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > /* request use of locality */ > - tpm_tis_i2c_writeb(locty, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, locty, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_REQUEST_USE); > - access = tpm_tis_i2c_readb(locty, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, locty, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > @@ -405,9 +409,9 @@ static void tpm_tis_i2c_test_check_access_reg_release(const void *data) > * request use of locality 'l' -- we MUST see REQUEST USE and > * may see PENDING_REQUEST > */ > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_REQUEST_USE); > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_REQUEST_USE | > @@ -416,7 +420,7 @@ static void tpm_tis_i2c_test_check_access_reg_release(const void *data) > pending_request_flag = TPM_TIS_ACCESS_PENDING_REQUEST; > } > /* release locality 'locty' */ > - tpm_tis_i2c_writeb(locty, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, locty, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > /* > * highest locality should now be active; release it and make sure the > @@ -427,16 +431,16 @@ static void tpm_tis_i2c_test_check_access_reg_release(const void *data) > continue; > } > /* 'l' should be active now */ > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > pending_request_flag | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > /* 'l' relinquishes access */ > - tpm_tis_i2c_writeb(l, TPM_I2C_REG_ACCESS, > + tpm_tis_i2c_writeb(global_qtest, l, TPM_I2C_REG_ACCESS, > TPM_TIS_ACCESS_ACTIVE_LOCALITY); > - access = tpm_tis_i2c_readb(l, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, l, TPM_I2C_REG_ACCESS); > DPRINTF_ACCESS; > if (l == 1 || (locty <= 1 && l == 2)) { > pending_request_flag = 0; > @@ -460,22 +464,24 @@ static void tpm_tis_i2c_test_check_transmit(const void *data) > size_t i; > > /* enable csum */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_DATA_CSUM_ENABLE, TPM_DATA_CSUM_ENABLED); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE, > + TPM_DATA_CSUM_ENABLED); > /* check csum enable register has bit 0 set */ > - v = tpm_tis_i2c_readb(0, TPM_I2C_REG_DATA_CSUM_ENABLE); > + v = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE); > g_assert_cmpint(v, ==, TPM_DATA_CSUM_ENABLED); > /* reading it as 32bit register returns same result */ > - v = tpm_tis_i2c_readl(0, TPM_I2C_REG_DATA_CSUM_ENABLE); > + v = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_ENABLE); > g_assert_cmpint(v, ==, TPM_DATA_CSUM_ENABLED); > > /* request use of locality 0 */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_REQUEST_USE); > - access = tpm_tis_i2c_readb(0, TPM_I2C_REG_ACCESS); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_ACCESS, > + TPM_TIS_ACCESS_REQUEST_USE); > + access = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_ACCESS); > g_assert_cmpint(access, ==, TPM_TIS_ACCESS_TPM_REG_VALID_STS | > TPM_TIS_ACCESS_ACTIVE_LOCALITY | > TPM_TIS_ACCESS_TPM_ESTABLISHMENT); > > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > DPRINTF_STS; > > g_assert_cmpint(sts & 0xff, ==, 0); > @@ -484,21 +490,22 @@ static void tpm_tis_i2c_test_check_transmit(const void *data) > g_assert_cmpint(bcount, >=, 128); > > /* read bcount from STS + 1 must work also */ > - bcount2 = tpm_tis_i2c_readw(0, TPM_I2C_REG_STS + 1); > + bcount2 = tpm_tis_i2c_readw(global_qtest, 0, TPM_I2C_REG_STS + 1); > g_assert_cmpint(bcount, ==, bcount2); > > /* ic2 must have bits 26-31 zero */ > g_assert_cmpint(sts & (0x1f << 26), ==, 0); > > - tpm_tis_i2c_writel(0, TPM_I2C_REG_STS, TPM_TIS_STS_COMMAND_READY); > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + tpm_tis_i2c_writel(global_qtest, 0, TPM_I2C_REG_STS, > + TPM_TIS_STS_COMMAND_READY); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > DPRINTF_STS; > g_assert_cmpint(sts & 0xff, ==, TPM_TIS_STS_COMMAND_READY); > > /* transmit command */ > for (i = 0; i < sizeof(TPM_CMD); i++) { > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_DATA_FIFO, TPM_CMD[i]); > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_DATA_FIFO, TPM_CMD[i]); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > DPRINTF_STS; > if (i < sizeof(TPM_CMD) - 1) { > g_assert_cmpint(sts & 0xff, ==, > @@ -509,21 +516,21 @@ static void tpm_tis_i2c_test_check_transmit(const void *data) > g_assert_cmpint((sts >> 8) & 0xffff, ==, --bcount); > } > /* read the checksum */ > - csum = tpm_tis_i2c_readw(0, TPM_I2C_REG_DATA_CSUM_GET); > + csum = tpm_tis_i2c_readw(global_qtest, 0, TPM_I2C_REG_DATA_CSUM_GET); > g_assert_cmpint(csum, ==, 0x6733); > > /* start processing */ > - tpm_tis_i2c_writeb(0, TPM_I2C_REG_STS, TPM_TIS_STS_TPM_GO); > + tpm_tis_i2c_writeb(global_qtest, 0, TPM_I2C_REG_STS, TPM_TIS_STS_TPM_GO); > > uint64_t end_time = g_get_monotonic_time() + 50 * G_TIME_SPAN_SECOND; > do { > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > if ((sts & TPM_TIS_STS_DATA_AVAILABLE) != 0) { > break; > } > } while (g_get_monotonic_time() < end_time); > > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > DPRINTF_STS; > g_assert_cmpint(sts & 0xff, == , > TPM_TIS_STS_VALID | TPM_TIS_STS_DATA_AVAILABLE); > @@ -534,8 +541,8 @@ static void tpm_tis_i2c_test_check_transmit(const void *data) > g_assert_cmpint(sizeof(tpm_msg), ==, bcount); > > for (i = 0; i < sizeof(tpm_msg); i++) { > - tpm_msg[i] = tpm_tis_i2c_readb(0, TPM_I2C_REG_DATA_FIFO); > - sts = tpm_tis_i2c_readl(0, TPM_I2C_REG_STS); > + tpm_msg[i] = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_DATA_FIFO); > + sts = tpm_tis_i2c_readl(global_qtest, 0, TPM_I2C_REG_STS); > DPRINTF_STS; > if (sts & TPM_TIS_STS_DATA_AVAILABLE) { > g_assert_cmpint((sts >> 8) & 0xffff, ==, --bcount); > @@ -544,9 +551,9 @@ static void tpm_tis_i2c_test_check_transmit(const void *data) > g_assert_cmpmem(tpm_msg, sizeof(tpm_msg), s->tpm_msg, sizeof(*s->tpm_msg)); > > /* relinquish use of locality 0 */ > - tpm_tis_i2c_writeb(0, > + tpm_tis_i2c_writeb(global_qtest, 0, > TPM_I2C_REG_ACCESS, TPM_TIS_ACCESS_ACTIVE_LOCALITY); > - access = tpm_tis_i2c_readb(0, TPM_I2C_REG_ACCESS); > + access = tpm_tis_i2c_readb(global_qtest, 0, TPM_I2C_REG_ACCESS); > } > > int main(int argc, char **argv) > diff --git a/tests/qtest/tpm-tis-i2c-util.c b/tests/qtest/tpm-tis-i2c-util.c > index 07b1eeba69..6e724a4a47 100644 > --- a/tests/qtest/tpm-tis-i2c-util.c > +++ b/tests/qtest/tpm-tis-i2c-util.c > @@ -20,45 +20,45 @@ uint32_t aspeed_bus_addr; > > static uint8_t cur_locty = 0xff; > > -static void tpm_tis_i2c_set_locty(uint8_t locty) > +static void tpm_tis_i2c_set_locty(QTestState *s, uint8_t locty) > { > if (cur_locty != locty) { > cur_locty = locty; > - aspeed_i2c_writeb(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, > + aspeed_i2c_writeb(s, aspeed_bus_addr, I2C_SLAVE_ADDR, > TPM_I2C_REG_LOC_SEL, locty); > } > } > > -uint8_t tpm_tis_i2c_readb(uint8_t locty, uint8_t reg) > +uint8_t tpm_tis_i2c_readb(QTestState *s, uint8_t locty, uint8_t reg) > { > - tpm_tis_i2c_set_locty(locty); > - return aspeed_i2c_readb(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, reg); > + tpm_tis_i2c_set_locty(s, locty); > + return aspeed_i2c_readb(s, aspeed_bus_addr, I2C_SLAVE_ADDR, reg); > } > > -uint16_t tpm_tis_i2c_readw(uint8_t locty, uint8_t reg) > +uint16_t tpm_tis_i2c_readw(QTestState *s, uint8_t locty, uint8_t reg) > { > - tpm_tis_i2c_set_locty(locty); > + tpm_tis_i2c_set_locty(s, locty); > return aspeed_i2c_readw(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, reg); > } > > -uint32_t tpm_tis_i2c_readl(uint8_t locty, uint8_t reg) > +uint32_t tpm_tis_i2c_readl(QTestState *s, uint8_t locty, uint8_t reg) > { > - tpm_tis_i2c_set_locty(locty); > - return aspeed_i2c_readl(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, reg); > + tpm_tis_i2c_set_locty(s, locty); > + return aspeed_i2c_readl(s, aspeed_bus_addr, I2C_SLAVE_ADDR, reg); > } > > -void tpm_tis_i2c_writeb(uint8_t locty, uint8_t reg, uint8_t v) > +void tpm_tis_i2c_writeb(QTestState *s, uint8_t locty, uint8_t reg, uint8_t v) > { > if (reg != TPM_I2C_REG_LOC_SEL) { > - tpm_tis_i2c_set_locty(locty); > + tpm_tis_i2c_set_locty(s, locty); > } > - aspeed_i2c_writeb(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, reg, v); > + aspeed_i2c_writeb(s, aspeed_bus_addr, I2C_SLAVE_ADDR, reg, v); > } > > -void tpm_tis_i2c_writel(uint8_t locty, uint8_t reg, uint32_t v) > +void tpm_tis_i2c_writel(QTestState *s, uint8_t locty, uint8_t reg, uint32_t v) > { > if (reg != TPM_I2C_REG_LOC_SEL) { > - tpm_tis_i2c_set_locty(locty); > + tpm_tis_i2c_set_locty(s, locty); > } > - aspeed_i2c_writel(global_qtest, aspeed_bus_addr, I2C_SLAVE_ADDR, reg, v); > + aspeed_i2c_writel(s, aspeed_bus_addr, I2C_SLAVE_ADDR, reg, v); > } > diff --git a/tests/qtest/tpm-tis-i2c-util.h b/tests/qtest/tpm-tis-i2c-util.h > index dfe626b43d..3289545f61 100644 > --- a/tests/qtest/tpm-tis-i2c-util.h > +++ b/tests/qtest/tpm-tis-i2c-util.h > @@ -20,11 +20,11 @@ extern uint32_t aspeed_bus_addr; > #define I2C_SLAVE_ADDR 0x2e > #define I2C_DEV_BUS_NUM 10 > > -uint8_t tpm_tis_i2c_readb(uint8_t locty, uint8_t reg); > -uint16_t tpm_tis_i2c_readw(uint8_t locty, uint8_t reg); > -uint32_t tpm_tis_i2c_readl(uint8_t locty, uint8_t reg); > +uint8_t tpm_tis_i2c_readb(QTestState *s, uint8_t locty, uint8_t reg); > +uint16_t tpm_tis_i2c_readw(QTestState *s, uint8_t locty, uint8_t reg); > +uint32_t tpm_tis_i2c_readl(QTestState *s, uint8_t locty, uint8_t reg); > > -void tpm_tis_i2c_writeb(uint8_t locty, uint8_t reg, uint8_t v); > -void tpm_tis_i2c_writel(uint8_t locty, uint8_t reg, uint32_t v); > +void tpm_tis_i2c_writeb(QTestState *s, uint8_t locty, uint8_t reg, uint8_t v); > +void tpm_tis_i2c_writel(QTestState *s, uint8_t locty, uint8_t reg, uint32_t v); > > #endif /* TESTS_TPM_TIS_I2C_UTIL_H */ > -- > 2.43.0 > Reviewed-by: Arun Menon Regards, Arun Menon