Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EE44375F65 for ; Thu, 30 Apr 2026 06:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777529755; cv=none; b=Kp3xFK0zqW05ess1KYTmFnaGTYDTFe67Xxc1pS9FbgcJYDPM71ZWjyqvhir+7zaQiinLl6ZsTbcOcieGsfhi9ga9HyG06O/i8ubd3vRB1MfE32fVTM0MNfeba2J7LYYlZPhRfFxn+3/9G9+hhmYK9UnF28uad2Ctb+NAhSkhwf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777529755; c=relaxed/simple; bh=xL42ZWKrTVrSC2jDeY0hsvPfU3p9FbDy5krFUYRLQXE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=R/K2aXgwsU4X6WypIGbj+maQzhLO/+eZ0QGLq8VZ2ta9s21BCtC9CalzUf3FoPGS2Qnq3uoZBQ8JPrdgiFSbOtTYwOMEBUrGoJp7ctehGYZsMhmxiE/4YoBVoI0J0T41hPBPTu6SLY9cYxIeJ9gNUm494GAN0Npfd53KpQyaQc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TLBQ4EmC; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TLBQ4EmC" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso3265625e9.0 for ; Wed, 29 Apr 2026 23:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777529752; x=1778134552; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=4eBgl8Ld1ZWw/9cbt4soJzSAn0Jr0mSS+YG3PesXQEU=; b=TLBQ4EmCZNU1xW3xGmi0Gs4ptvMebe2b3TLJLOu8eRcyRLG+XeT9JQL1xUcxHTMFs0 sjkg7IAMCriqxbcjaj9zBQNhptBYx8M0MladOpqvI5to3FPzvZvmbm/LIglQmUGzG0Bd S1WEC90IyBjZHT9QpELVEzqPi0Ya/x8oilJA5jO+nnFzpDohIzGZImyVLpyVSbvtTtVe lVVhFxaeGGWP9fq5SLw6rgsDCU4uOxzPBzX/+8OUhyd/0GFlhyBz8gie7j/+/H7/SsMz lNj04w04Hu8NCRdJ8vXV1gNmju8nc3J3fl/l9QJU6w/mlwmLbPyGNu6MU6zXdRKNCMd8 u7ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777529752; x=1778134552; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4eBgl8Ld1ZWw/9cbt4soJzSAn0Jr0mSS+YG3PesXQEU=; b=oehmWoINp13nRdVTjf7yvdQiw1uhFvAfm9ZmCRTtaQ5CpNOsf2VW9kUcNOdplMVsAQ o6+bdcSNdYvY8Apew4wHkQv5wqKque12/Ob5mU8azvQOYjnauk/zLSbSB+ezVzhdqSB/ NoV5NBAHA40EOZNjoxPvKMa6aDFl5fQxukBMMsVatiWRzOFtjFraqA4TLaScoTAyHSYv K+dLHsZ0yRLhNusXrHcvZQQpfItdFVgKzFh1Z9RZjru8o0Seq6wM48iXo+eipB8PJg8R i08amxxoS/hMd/53nNb3y4iGJkBq59qzhtvpt/Per4rod+Tw3D51Gz6lhnC7MVOAHaGy 8YKA== X-Forwarded-Encrypted: i=1; AFNElJ+ygiYxhla/paU6gql1a19WuvQxKJ0KNoZGHyzSsAcAyfJBbpXGRCLSoi39R5yM5jvt7PLTrKXCQJArCUgKz1U=@vger.kernel.org X-Gm-Message-State: AOJu0YwV0NoP6lUs8W4Bl+quHi0Ip5Wdxa+OlO2Xm7g2yOOhYe2VfEpX gT2TK9nDzL3bsoUqkd3uqIrDuHqhnBBlxrvsLWIVc3lLqT4tTON8Fono X-Gm-Gg: AeBDietzDVoxX2aiEJtDCfPUe2OAVxSc3SRrWE497x60CQzofVj96jsR5jMrrKlCogI JrTxDNBlFh0qRXbsBKKgV9K27g0KuvkVCAsLK1zFj5L608JDFpJ9qYRhzcuWAxBzdbmyDqORMm0 FbJMlDk94oiTIQ3ej6aw1tzD+Y+383wwM4VOOJWie4AJoB3LwjuGQwxAj/2+a2afpN7+uwsYKRf 6MZUw/GM1WIhb9MGq1d6MPuf/J42M2XVz8Lse6R9395+fETMdQJG8lZu+cHIO7yJxiMcTzwvfjU YLvKozvcjhHMzHsl10+sX9ooDsDWeMQPtIQ9tRmbwiR76I2OqApQzcbMv/Fm1+fvMjhPz3TLr9K 5XYcWXZETIQJqD4g971gA6LpLew20mdwk7aCNqWqC3hFTCyexdItU9uHZy5vu0+UJgWNYD5bzt4 VsUKghI4Qrypm/chFKR2nUwmNFhLxy0g== X-Received: by 2002:a05:600d:6:b0:48a:7a10:4f3d with SMTP id 5b1f17b1804b1-48a83d031fbmr20499035e9.0.1777529752266; Wed, 29 Apr 2026 23:15:52 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a81ed6bafsm68748675e9.2.2026.04.29.23.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 23:15:51 -0700 (PDT) Date: Thu, 30 Apr 2026 09:15:48 +0300 From: Dan Carpenter To: Kalle Valo Cc: Johannes Berg , Raja Mani , Vasanthakumar Thiagarajan , Jouni Malinen , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] wifi: cfg80211: don't allow negative key_len values Message-ID: Precedence: bulk X-Mailing-List: kernel-janitors@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding The ath6kl_cfg80211_add_key() function has an upper bounds check on params->key_len which ensures that it can't go over WLAN_MAX_KEY_LEN but it doesn't check for negatives. This could potentially lead to memory corruption. Put a bounds check on negative values in cfg80211_validate_key_settings() to prevent this sort of bug in the future. Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") Cc: stable@vger.kernel.org Signed-off-by: Dan Carpenter --- This is from static analysis. I can't think why a driver would ever want a negative length and I think this is the safest solution. But I have not tested it. net/wireless/util.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/wireless/util.c b/net/wireless/util.c index b78530c3e3f8..4552229eb2d2 100644 --- a/net/wireless/util.c +++ b/net/wireless/util.c @@ -397,6 +397,8 @@ int cfg80211_validate_key_settings(struct cfg80211_registered_device *rdev, * or not the driver supports this algorithm, * of course. */ + if (params->key_len < 0) + return -EINVAL; break; } -- 2.53.0