From: Sagar Arun Kamble Subject: Re: [PATCH v8 1/8] drm/i915: Create GEM runtime resume helper and handle GEM suspend/resume errors Date: Tue, 26 Sep 2017 18:59:27 +0530 Message-ID: References: <1506432285-14979-1-git-send-email-sagar.a.kamble@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB0E76E219 for ; Tue, 26 Sep 2017 13:29:31 +0000 (UTC) In-Reply-To: <1506432285-14979-1-git-send-email-sagar.a.kamble@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Paulo Zanoni , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org QW5kIEkgaGF2ZSBmb3Jnb3QgdG8gYW1lbmQgdGhlIG9yZGVyaW5nIG9mIHRhZ3MgY2MsIHMtby1i IGV0Yy4gU29ycnkgZm9yIAp0aGUgc2FtZS4KCgpPbiA5LzI2LzIwMTcgNjo1NCBQTSwgU2FnYXIg QXJ1biBLYW1ibGUgd3JvdGU6Cj4gUHJlcGFyZWQgaGVscGVyIGk5MTVfZ2VtX3J1bnRpbWVfcmVz dW1lIHRvIHJlY3JlYXRlIGdlbSBzZXR1cC4KPiBSZXR1cm5pbmcgc3RhdHVzIGZyb20gaTkxNV9n ZW1fcnVudGltZV9zdXNwZW5kIGFuZCBpOTE1X2dlbV9yZXN1bWUuCj4gVGhpcyB3aWxsIGJlIHBs YWNlaG9sZGVyIGZvciBoYW5kbGluZyBhbnkgZXJyb3JzIGZyb20gdUMgc3VzcGVuZC9yZXN1bWUK PiBpbiB1cGNvbWluZyBwYXRjaGVzLiBSZXN0cnVjdHVyZWQgdGhlIHN1c3BlbmQvcmVzdW1lIHJv dXRpbmVzIHcuci50IHNldHVwCj4gY3JlYXRpb24gYW5kIHJvbGxiYWNrIG9yZGVyLgo+IFRoaXMg YWxzbyBmaXhlcyBpc3N1ZSBvZiBvcmRlcmluZyBvZiBpOTE1X2dlbV9ydW50aW1lX3Jlc3VtZSB3 aXRoCj4gaW50ZWxfcnVudGltZV9wbV9lbmFibGVfaW50ZXJydXB0cy4KPgo+IHYyOiBGaXhlZCBy ZXR1cm4gZnJvbSBpbnRlbF9ydW50aW1lX3Jlc3VtZS4gKE1pY2hhxYIgV2luaWFyc2tpKQo+Cj4g Q2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBJbXJlIERl YWsgPGltcmUuZGVha0BpbnRlbC5jb20+Cj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5v bmlAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+ Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENj OiBNaWNoYcWCIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiAt LS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAzNCArKysrKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IHwgIDUgKysrLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMCArKysr KysrKysrKysrKysrKystLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCA0MSBpbnNlcnRpb25zKCspLCAx OCBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IDcwNTZiYjIu LmEzYmJmMTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtMTY1NSw2ICsxNjU1 LDcgQEAgc3RhdGljIGludCBpOTE1X3N1c3BlbmRfc3dpdGNoZXJvbyhzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCBwbV9tZXNzYWdlX3Qgc3RhdGUpCj4gICBzdGF0aWMgaW50IGk5MTVfZHJtX3Jlc3Vt ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiArCXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0g ZGV2X3ByaXYtPmRybS5wZGV2Owo+ICAgCWludCByZXQ7Cj4gICAKPiAgIAlkaXNhYmxlX3JwbV93 YWtlcmVmX2Fzc2VydHMoZGV2X3ByaXYpOwo+IEBAIC0xNjY2LDcgKzE2NjcsOSBAQCBzdGF0aWMg aW50IGk5MTVfZHJtX3Jlc3VtZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAgCj4gICAJaW50 ZWxfY3NyX3Vjb2RlX3Jlc3VtZShkZXZfcHJpdik7Cj4gICAKPiAtCWk5MTVfZ2VtX3Jlc3VtZShk ZXZfcHJpdik7Cj4gKwlyZXQgPSBpOTE1X2dlbV9yZXN1bWUoZGV2X3ByaXYpOwo+ICsJaWYgKHJl dCkKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJHRU0gcmVzdW1lIGZhaWxlZFxuIik7Cj4gICAK PiAgIAlpOTE1X3Jlc3RvcmVfc3RhdGUoZGV2X3ByaXYpOwo+ICAgCWludGVsX3Bwc191bmxvY2tf cmVnc193YShkZXZfcHJpdik7Cj4gQEAgLTI0OTUsNyArMjQ5OCwxMSBAQCBzdGF0aWMgaW50IGlu dGVsX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICprZGV2KQo+ICAgCSAqIFdlIGFyZSBz YWZlIGhlcmUgYWdhaW5zdCByZS1mYXVsdHMsIHNpbmNlIHRoZSBmYXVsdCBoYW5kbGVyIHRha2Vz Cj4gICAJICogYW4gUlBNIHJlZmVyZW5jZS4KPiAgIAkgKi8KPiAtCWk5MTVfZ2VtX3J1bnRpbWVf c3VzcGVuZChkZXZfcHJpdik7Cj4gKwlyZXQgPSBpOTE1X2dlbV9ydW50aW1lX3N1c3BlbmQoZGV2 X3ByaXYpOwo+ICsJaWYgKHJldCkgewo+ICsJCWVuYWJsZV9ycG1fd2FrZXJlZl9hc3NlcnRzKGRl dl9wcml2KTsKPiArCQlyZXR1cm4gcmV0Owo+ICsJfQo+ICAgCj4gICAJaW50ZWxfZ3VjX3N1c3Bl bmQoZGV2X3ByaXYpOwo+ICAgCj4gQEAgLTI1MTUsNiArMjUyMiw4IEBAIHN0YXRpYyBpbnQgaW50 ZWxfcnVudGltZV9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmtkZXYpCj4gICAJCURSTV9FUlJPUigi UnVudGltZSBzdXNwZW5kIGZhaWxlZCwgZGlzYWJsaW5nIGl0ICglZClcbiIsIHJldCk7Cj4gICAJ CWludGVsX3J1bnRpbWVfcG1fZW5hYmxlX2ludGVycnVwdHMoZGV2X3ByaXYpOwo+ICAgCj4gKwkJ aW50ZWxfZ3VjX3Jlc3VtZShkZXZfcHJpdik7Cj4gKwkJaTkxNV9nZW1fcnVudGltZV9yZXN1bWUo ZGV2X3ByaXYpOwo+ICAgCQllbmFibGVfcnBtX3dha2VyZWZfYXNzZXJ0cyhkZXZfcHJpdik7Cj4g ICAKPiAgIAkJcmV0dXJuIHJldDsKPiBAQCAtMjU2Nyw3ICsyNTc2LDcgQEAgc3RhdGljIGludCBp bnRlbF9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICprZGV2KQo+ICAgCXN0cnVjdCBwY2lf ZGV2ICpwZGV2ID0gdG9fcGNpX2RldihrZGV2KTsKPiAgIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gcGNpX2dldF9kcnZkYXRhKHBkZXYpOwo+ICAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAtCWludCByZXQgPSAwOwo+ICsJaW50IGVyciA9IDAs IHJldDsKPiAgIAo+ICAgCWlmIChXQVJOX09OX09OQ0UoIUhBU19SVU5USU1FX1BNKGRldl9wcml2 KSkpCj4gICAJCXJldHVybiAtRU5PREVWOwo+IEBAIC0yNTkzLDE2ICsyNjAyLDkgQEAgc3RhdGlj IGludCBpbnRlbF9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZGV2aWNlICprZGV2KQo+ICAgCX0gZWxz ZSBpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkgewo+ ICAgCQloc3dfZGlzYWJsZV9wYzgoZGV2X3ByaXYpOwo+ICAgCX0gZWxzZSBpZiAoSVNfVkFMTEVZ VklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPiAtCQlyZXQgPSB2 bHZfcmVzdW1lX3ByZXBhcmUoZGV2X3ByaXYsIHRydWUpOwo+ICsJCWVyciA9IHZsdl9yZXN1bWVf cHJlcGFyZShkZXZfcHJpdiwgdHJ1ZSk7Cj4gICAJfQo+ICAgCj4gLQkvKgo+IC0JICogTm8gcG9p bnQgb2Ygcm9sbGluZyBiYWNrIHRoaW5ncyBpbiBjYXNlIG9mIGFuIGVycm9yLCBhcyB0aGUgYmVz dAo+IC0JICogd2UgY2FuIGRvIGlzIHRvIGhvcGUgdGhhdCB0aGluZ3Mgd2lsbCBzdGlsbCB3b3Jr IChhbmQgZGlzYWJsZSBSUE0pLgo+IC0JICovCj4gLQlpOTE1X2dlbV9pbml0X3N3aXp6bGluZyhk ZXZfcHJpdik7Cj4gLQlpOTE1X2dlbV9yZXN0b3JlX2ZlbmNlcyhkZXZfcHJpdik7Cj4gLQo+ICAg CWludGVsX3J1bnRpbWVfcG1fZW5hYmxlX2ludGVycnVwdHMoZGV2X3ByaXYpOwo+ICAgCj4gICAJ LyoKPiBAQCAtMjYxNSwxNCArMjYxNywxOCBAQCBzdGF0aWMgaW50IGludGVsX3J1bnRpbWVfcmVz dW1lKHN0cnVjdCBkZXZpY2UgKmtkZXYpCj4gICAKPiAgIAlpbnRlbF9lbmFibGVfaXBjKGRldl9w cml2KTsKPiAgIAo+ICsJcmV0ID0gaTkxNV9nZW1fcnVudGltZV9yZXN1bWUoZGV2X3ByaXYpOwo+ ICsJaWYgKCFlcnIpCj4gKwkJZXJyID0gcmV0Owo+ICsKPiAgIAllbmFibGVfcnBtX3dha2VyZWZf YXNzZXJ0cyhkZXZfcHJpdik7Cj4gICAKPiAtCWlmIChyZXQpCj4gLQkJRFJNX0VSUk9SKCJSdW50 aW1lIHJlc3VtZSBmYWlsZWQsIGRpc2FibGluZyBpdCAoJWQpXG4iLCByZXQpOwo+ICsJaWYgKGVy cikKPiArCQlEUk1fRVJST1IoIlJ1bnRpbWUgcmVzdW1lIGZhaWxlZCwgZGlzYWJsaW5nIGl0ICgl ZClcbiIsIGVycik7Cj4gICAJZWxzZQo+ICAgCQlEUk1fREVCVUdfS01TKCJEZXZpY2UgcmVzdW1l ZFxuIik7Cj4gICAKPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gZXJyOwo+ICAgfQo+ICAgCj4g ICBjb25zdCBzdHJ1Y3QgZGV2X3BtX29wcyBpOTE1X3BtX29wcyA9IHsKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiBpbmRleCA2MWE0YmU5Li42OTM3MGMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5oCj4gQEAgLTM0NzEsNyArMzQ3MSw4IEBAIHN0cnVjdCBpOTE1X3ZtYSAqIF9fbXVzdF9j aGVjawo+ICAgaW50IGk5MTVfZ2VtX29iamVjdF91bmJpbmQoc3RydWN0IGRybV9pOTE1X2dlbV9v YmplY3QgKm9iaik7Cj4gICB2b2lkIGk5MTVfZ2VtX3JlbGVhc2VfbW1hcChzdHJ1Y3QgZHJtX2k5 MTVfZ2VtX29iamVjdCAqb2JqKTsKPiAgIAo+IC12b2lkIGk5MTVfZ2VtX3J1bnRpbWVfc3VzcGVu ZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICtpbnQgaTkxNV9nZW1fcnVu dGltZV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gK2ludCBp OTE1X2dlbV9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICAgCj4gICBzdGF0aWMgaW5saW5lIGludCBfX3NnX3BhZ2VfY291bnQoY29uc3Qgc3RydWN0 IHNjYXR0ZXJsaXN0ICpzZykKPiAgIHsKPiBAQCAtMzY3NCw3ICszNjc1LDcgQEAgdm9pZCBpOTE1 X2dlbV9yZXNldF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lLAo+ICAgaW50 IGk5MTVfZ2VtX3dhaXRfZm9yX2lkbGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAgCQkJICAgdW5zaWduZWQgaW50IGZsYWdzKTsKPiAgIGludCBfX211c3RfY2hlY2sgaTkx NV9nZW1fc3VzcGVuZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+IC12b2lk IGk5MTVfZ2VtX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICtp bnQgaTkxNV9nZW1fcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4g ICBpbnQgaTkxNV9nZW1fZmF1bHQoc3RydWN0IHZtX2ZhdWx0ICp2bWYpOwo+ICAgaW50IGk5MTVf Z2VtX29iamVjdF93YWl0KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gICAJCQkg dW5zaWduZWQgaW50IGZsYWdzLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDczZWVi NmIuLmRiZTE4MWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0u Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMjAyMiw3ICsy MDIyLDcgQEAgaW50IGk5MTVfZ2VtX2ZhdWx0KHN0cnVjdCB2bV9mYXVsdCAqdm1mKQo+ICAgCWlu dGVsX3J1bnRpbWVfcG1fcHV0KGk5MTUpOwo+ICAgfQo+ICAgCj4gLXZvaWQgaTkxNV9nZW1fcnVu dGltZV9zdXNwZW5kKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAraW50IGk5 MTVfZ2VtX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgKm9uOwo+ICAgCWlu dCBpOwo+IEBAIC0yMDY1LDYgKzIwNjUsMjAgQEAgdm9pZCBpOTE1X2dlbV9ydW50aW1lX3N1c3Bl bmQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgCQlHRU1fQlVHX09OKCFs aXN0X2VtcHR5KCZyZWctPnZtYS0+b2JqLT51c2VyZmF1bHRfbGluaykpOwo+ICAgCQlyZWctPmRp cnR5ID0gdHJ1ZTsKPiAgIAl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK2ludCBpOTE1 X2dlbV9ydW50aW1lX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g K3sKPiArCS8qCj4gKwkgKiBObyBwb2ludCBvZiByb2xsaW5nIGJhY2sgdGhpbmdzIGluIGNhc2Ug b2YgYW4gZXJyb3IsIGFzIHRoZSBiZXN0Cj4gKwkgKiB3ZSBjYW4gZG8gaXMgdG8gaG9wZSB0aGF0 IHRoaW5ncyB3aWxsIHN0aWxsIHdvcmsgKGFuZCBkaXNhYmxlIFJQTSkuCj4gKwkgKi8KPiArCWk5 MTVfZ2VtX2luaXRfc3dpenpsaW5nKGRldl9wcml2KTsKPiArCWk5MTVfZ2VtX3Jlc3RvcmVfZmVu Y2VzKGRldl9wcml2KTsKPiArCj4gKwlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGlu dCBpOTE1X2dlbV9vYmplY3RfY3JlYXRlX21tYXBfb2Zmc2V0KHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpvYmopCj4gQEAgLTQ1ODcsNyArNDYwMSw3IEBAIGludCBpOTE1X2dlbV9zdXNwZW5k KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlyZXR1cm4gcmV0Owo+ICAg fQo+ICAgCj4gLXZvaWQgaTkxNV9nZW1fcmVzdW1lKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAraW50IGk5MTVfZ2VtX3Jlc3VtZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYpCj4gICB7Cj4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ ZHJtOwo+ICAgCj4gQEAgLTQ2MDMsNiArNDYxNyw4IEBAIHZvaWQgaTkxNV9nZW1fcmVzdW1lKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlkZXZfcHJpdi0+Z3QucmVzdW1l KGRldl9wcml2KTsKPiAgIAo+ICAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ ICsKPiArCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gICB2b2lkIGk5MTVfZ2VtX2luaXRfc3dpenps aW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=