Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA845C4332E for ; Sat, 21 Mar 2020 10:07:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B3992072C for ; Sat, 21 Mar 2020 10:07:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QEq+rLMQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B3992072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vanmierlo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ID3aEAzqt4d75+JqvwDTwEezsZwcTqqfA/IZsPTwmfE=; b=QEq+rLMQMAA04vo7kcrGVyWC7 qvLfmj79AYJfly+5lO2FeEP3gQyLny50Up+6qspe1jcnqLezX/t919TRubyLW8ObfHvYAp1/vQlyN rU6+/recfc1yq5euBiJle6JzJGxSwOu7ptkGyMY+JsItCvWv6fhhVrM5PI8TgeGW2T4QtAX8b6iKj 11uU62w9BZwUsaUlf4ZdHfCZOpBCSJ4LGKrFDWUxUExsueLRxKu4lmRheFpYebmNa3X2pxWd5i8dx n9EkORrdwRqks5fZ+2Z5qYuHxL9o0CF52CIxHF/Yjw5/V+e9AQsxZ4SWwsY6P4aY4AA1eTSyZrTbv HjAlK2CnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFb2R-0002ZK-0w; Sat, 21 Mar 2020 10:07:31 +0000 Received: from fieber.vanmierlo.com ([84.243.197.177] helo=kerio9.vanmierlo.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jFb2O-0002Yg-0N for linux-arm-kernel@lists.infradead.org; Sat, 21 Mar 2020 10:07:29 +0000 X-Footer: dmFubWllcmxvLmNvbQ== Received: from roundcube.vanmierlo.com ([192.168.37.37]) (authenticated user m.brock@vanmierlo.com) by kerio9.vanmierlo.com (Kerio Connect 9.2.11 beta 1) with ESMTPA; Sat, 21 Mar 2020 11:07:11 +0100 MIME-Version: 1.0 Date: Sat, 21 Mar 2020 11:07:10 +0100 From: Maarten Brock To: Shubhrajyoti Datta Subject: Re: [PATCH v4 2/2] serial: uartps: Add TACTIVE check in cdns_uart_tx_empty function In-Reply-To: References: Message-ID: X-Sender: m.brock@vanmierlo.com User-Agent: Roundcube Webmail/1.3.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200321_030728_192178_48C7F009 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Raviteja Narayanam , linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, michal.simek@xilinx.com, linux-serial-owner@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-03-19 10:44, Shubhrajyoti Datta wrote: > From: Raviteja Narayanam > > Make sure that all bytes are transmitted out of Uart by monitoring > CDNS_UART_SR_TACTIVE bit as well. > > Signed-off-by: Raviteja Narayanam > Signed-off-by: Shubhrajyoti Datta > --- > drivers/tty/serial/xilinx_uartps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/xilinx_uartps.c > b/drivers/tty/serial/xilinx_uartps.c > index 662b8ab..38cb76a9 100644 > --- a/drivers/tty/serial/xilinx_uartps.c > +++ b/drivers/tty/serial/xilinx_uartps.c > @@ -663,8 +663,8 @@ static unsigned int cdns_uart_tx_empty(struct > uart_port *port) > unsigned int status; > > status = readl(port->membase + CDNS_UART_SR) & > - CDNS_UART_SR_TXEMPTY; > - return status ? TIOCSER_TEMT : 0; > + (CDNS_UART_SR_TXEMPTY | CDNS_UART_SR_TACTIVE); > + return (status == CDNS_UART_SR_TXEMPTY) ? TIOCSER_TEMT : 0; > } > > /** Acked-by: Maarten Brock _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel