From: "cron2 (Code Review)" Date: Sun, 25 May 2025 16:36:28 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="D51TFYKP/l8="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Remove uncrustify config and scripts, switch GHA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --D51TFYKP/l8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/830?usp=3Demail ) Change subject: Remove uncrustify config and scripts, switch GHA ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: we need to keep "a pre-commit" script for easy local installation of the pr= e-commit hook. For those that change beween 2.6 and master/2.7 branches an= d commit to either of them, a git hook that does "is this an uncrustif bran= ch? call uncrustify, if not, call clang-format" would be helpful. ("dev-tools/" changes appropriately when changing branches, but .git/hooks/= does not) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/830?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I15d4946800cbfaead67a73450ff3b12193814e54 Gerrit-Change-Number: 830 Gerrit-PatchSet: 8 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Sun, 25 May 2025 16:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --D51TFYKP/l8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 8:Code-Review -1=

Vi= ew Change

1 comment:

  • Patchset:

    • Patch Set #8:

      we need to keep "a pre-commit" scrip= t for easy local installation of the pre-commit hook. For those that chang= e beween 2.6 and master/2.7 branches and commit to either of them, a git ho= ok that does "is this an uncrustif branch? call uncrustify, if not, c= all clang-format" would be helpful.

      ("dev-tools/" changes appropriately w= hen changing branches, but .git/hooks/ does not)

= To view, visit change 830. To unsubscribe, or for help writing mail filters, vis= it settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I15d4946800cbfaead67a73450ff= 3b12193814e54
Gerrit-Change-Number: 830
Gerrit-PatchSet: 8
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Sun, 25 May 2025 16:36:28= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--D51TFYKP/l8=--